All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: jeffrey.l.hugo@gmail.com, vkoul@kernel.org, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] dmaengine: qcom: bam_dma: Fix resource leak" failed to apply to 4.14-stable tree
Date: Mon, 4 Nov 2019 09:07:13 -0500	[thread overview]
Message-ID: <20191104140713.GE4787@sasha-vm> (raw)
In-Reply-To: <15728601263783@kroah.com>

On Mon, Nov 04, 2019 at 10:35:26AM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.14-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 7667819385457b4aeb5fac94f67f52ab52cc10d5 Mon Sep 17 00:00:00 2001
>From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
>Date: Thu, 17 Oct 2019 08:26:06 -0700
>Subject: [PATCH] dmaengine: qcom: bam_dma: Fix resource leak
>
>bam_dma_terminate_all() will leak resources if any of the transactions are
>committed to the hardware (present in the desc fifo), and not complete.
>Since bam_dma_terminate_all() does not cause the hardware to be updated,
>the hardware will still operate on any previously committed transactions.
>This can cause memory corruption if the memory for the transaction has been
>reassigned, and will cause a sync issue between the BAM and its client(s).
>
>Fix this by properly updating the hardware in bam_dma_terminate_all().
>
>Fixes: e7c0fe2a5c84 ("dmaengine: add Qualcomm BAM dma driver")
>Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
>Cc: stable@vger.kernel.org
>Link: https://lore.kernel.org/r/20191017152606.34120-1-jeffrey.l.hugo@gmail.com
>Signed-off-by: Vinod Koul <vkoul@kernel.org>

Is the "Fixes:" tag correct here? Is it an issue without 6b4faeac05bc
("dmaengine: qcom-bam: Process multiple pending descriptors")?

-- 
Thanks,
Sasha

  reply	other threads:[~2019-11-04 14:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04  9:35 FAILED: patch "[PATCH] dmaengine: qcom: bam_dma: Fix resource leak" failed to apply to 4.14-stable tree gregkh
2019-11-04 14:07 ` Sasha Levin [this message]
2019-11-04 14:39   ` Jeffrey Hugo
2019-11-04 17:12     ` Sasha Levin
2019-11-04 17:15       ` Jeffrey Hugo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191104140713.GE4787@sasha-vm \
    --to=sashal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeffrey.l.hugo@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.