From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E5FBCA9EB5 for ; Mon, 4 Nov 2019 16:39:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7270E2089C for ; Mon, 4 Nov 2019 16:39:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EISj5KjZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729091AbfKDQjh (ORCPT ); Mon, 4 Nov 2019 11:39:37 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:24213 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728346AbfKDQjh (ORCPT ); Mon, 4 Nov 2019 11:39:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572885575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZKRtyHtWqxotoMRVCD2L231GIf5CzzOu6K7yMpGCV1E=; b=EISj5KjZrUl3kZNHgeVxg9gzAbcLy4Tpe15p04ZJX+1X/PP0zhFi/jqdDWYjMDEhoU+i0C JuU/cWz6scDZOZMQlwE2N2QuxICFFYXRzNVTjImH796mEQWD/wjXHkzq8BvJ4gOxbXcJlq N9g+v2tQVhedXU+Lsqq3rbwA789furQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-XcpsC-lSP4a7ehsn9d2sxg-1; Mon, 04 Nov 2019 11:39:31 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D6C88017DD; Mon, 4 Nov 2019 16:39:27 +0000 (UTC) Received: from redhat.com (unknown [10.20.6.178]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F0A6F5C240; Mon, 4 Nov 2019 16:39:20 +0000 (UTC) Date: Mon, 4 Nov 2019 11:39:19 -0500 From: Jerome Glisse To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML , "Kirill A . Shutemov" Subject: Re: [PATCH v2 01/18] mm/gup: pass flags arg to __gup_device_* functions Message-ID: <20191104163919.GA5134@redhat.com> References: <20191103211813.213227-1-jhubbard@nvidia.com> <20191103211813.213227-2-jhubbard@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20191103211813.213227-2-jhubbard@nvidia.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: XcpsC-lSP4a7ehsn9d2sxg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sun, Nov 03, 2019 at 01:17:56PM -0800, John Hubbard wrote: > A subsequent patch requires access to gup flags, so > pass the flags argument through to the __gup_device_* > functions. >=20 > Also placate checkpatch.pl by shortening a nearby line. >=20 > Reviewed-by: Ira Weiny > Cc: Kirill A. Shutemov > Signed-off-by: John Hubbard Reviewed-by: J=E9r=F4me Glisse > --- > mm/gup.c | 28 ++++++++++++++++++---------- > 1 file changed, 18 insertions(+), 10 deletions(-) >=20 > diff --git a/mm/gup.c b/mm/gup.c > index 8f236a335ae9..85caf76b3012 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1890,7 +1890,8 @@ static int gup_pte_range(pmd_t pmd, unsigned long a= ddr, unsigned long end, > =20 > #if defined(CONFIG_ARCH_HAS_PTE_DEVMAP) && defined(CONFIG_TRANSPARENT_HU= GEPAGE) > static int __gup_device_huge(unsigned long pfn, unsigned long addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09 struct page **pages, int *nr) > { > =09int nr_start =3D *nr; > =09struct dev_pagemap *pgmap =3D NULL; > @@ -1916,13 +1917,14 @@ static int __gup_device_huge(unsigned long pfn, u= nsigned long addr, > } > =20 > static int __gup_device_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long = addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09unsigned long fault_pfn; > =09int nr_start =3D *nr; > =20 > =09fault_pfn =3D pmd_pfn(orig) + ((addr & ~PMD_MASK) >> PAGE_SHIFT); > -=09if (!__gup_device_huge(fault_pfn, addr, end, pages, nr)) > +=09if (!__gup_device_huge(fault_pfn, addr, end, flags, pages, nr)) > =09=09return 0; > =20 > =09if (unlikely(pmd_val(orig) !=3D pmd_val(*pmdp))) { > @@ -1933,13 +1935,14 @@ static int __gup_device_huge_pmd(pmd_t orig, pmd_= t *pmdp, unsigned long addr, > } > =20 > static int __gup_device_huge_pud(pud_t orig, pud_t *pudp, unsigned long = addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09unsigned long fault_pfn; > =09int nr_start =3D *nr; > =20 > =09fault_pfn =3D pud_pfn(orig) + ((addr & ~PUD_MASK) >> PAGE_SHIFT); > -=09if (!__gup_device_huge(fault_pfn, addr, end, pages, nr)) > +=09if (!__gup_device_huge(fault_pfn, addr, end, flags, pages, nr)) > =09=09return 0; > =20 > =09if (unlikely(pud_val(orig) !=3D pud_val(*pudp))) { > @@ -1950,14 +1953,16 @@ static int __gup_device_huge_pud(pud_t orig, pud_= t *pudp, unsigned long addr, > } > #else > static int __gup_device_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long = addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09BUILD_BUG(); > =09return 0; > } > =20 > static int __gup_device_huge_pud(pud_t pud, pud_t *pudp, unsigned long a= ddr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09BUILD_BUG(); > =09return 0; > @@ -2062,7 +2067,8 @@ static int gup_huge_pmd(pmd_t orig, pmd_t *pmdp, un= signed long addr, > =09if (pmd_devmap(orig)) { > =09=09if (unlikely(flags & FOLL_LONGTERM)) > =09=09=09return 0; > -=09=09return __gup_device_huge_pmd(orig, pmdp, addr, end, pages, nr); > +=09=09return __gup_device_huge_pmd(orig, pmdp, addr, end, flags, > +=09=09=09=09=09 pages, nr); > =09} > =20 > =09refs =3D 0; > @@ -2092,7 +2098,8 @@ static int gup_huge_pmd(pmd_t orig, pmd_t *pmdp, un= signed long addr, > } > =20 > static int gup_huge_pud(pud_t orig, pud_t *pudp, unsigned long addr, > -=09=09unsigned long end, unsigned int flags, struct page **pages, int *n= r) > +=09=09=09unsigned long end, unsigned int flags, > +=09=09=09struct page **pages, int *nr) > { > =09struct page *head, *page; > =09int refs; > @@ -2103,7 +2110,8 @@ static int gup_huge_pud(pud_t orig, pud_t *pudp, un= signed long addr, > =09if (pud_devmap(orig)) { > =09=09if (unlikely(flags & FOLL_LONGTERM)) > =09=09=09return 0; > -=09=09return __gup_device_huge_pud(orig, pudp, addr, end, pages, nr); > +=09=09return __gup_device_huge_pud(orig, pudp, addr, end, flags, > +=09=09=09=09=09 pages, nr); > =09} > =20 > =09refs =3D 0; > --=20 > 2.23.0 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E64CA9EB5 for ; Mon, 4 Nov 2019 16:49:00 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D0792084D for ; Mon, 4 Nov 2019 16:49:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hiYtuOZI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D0792084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 476JfK3y6pzF0mS for ; Tue, 5 Nov 2019 03:48:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=205.139.110.120; helo=us-smtp-1.mimecast.com; envelope-from=jglisse@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="hiYtuOZI"; dkim-atps=neutral Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 476JRb0dqdzF40C for ; Tue, 5 Nov 2019 03:39:38 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572885576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZKRtyHtWqxotoMRVCD2L231GIf5CzzOu6K7yMpGCV1E=; b=hiYtuOZIrS4Dtq2A70Yyrgqf0kG1a7RCsS289tkO9EWgEgzteBkLAB+wq4x1k88h8JNJIy vtFFStsbzSqMmhcDwISQiQ/L+jD38xPMmplP6s3npI7am82vDNnaE0K1x+0Hv03IDHADLU +7tFiaCT/Oq+UsMx7W4MKHtfPF9rv5I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-XcpsC-lSP4a7ehsn9d2sxg-1; Mon, 04 Nov 2019 11:39:31 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D6C88017DD; Mon, 4 Nov 2019 16:39:27 +0000 (UTC) Received: from redhat.com (unknown [10.20.6.178]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F0A6F5C240; Mon, 4 Nov 2019 16:39:20 +0000 (UTC) Date: Mon, 4 Nov 2019 11:39:19 -0500 From: Jerome Glisse To: John Hubbard Subject: Re: [PATCH v2 01/18] mm/gup: pass flags arg to __gup_device_* functions Message-ID: <20191104163919.GA5134@redhat.com> References: <20191103211813.213227-1-jhubbard@nvidia.com> <20191103211813.213227-2-jhubbard@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20191103211813.213227-2-jhubbard@nvidia.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: XcpsC-lSP4a7ehsn9d2sxg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, Alex Williamson , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, LKML , Daniel Vetter , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , "Kirill A . Shutemov" , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, Nov 03, 2019 at 01:17:56PM -0800, John Hubbard wrote: > A subsequent patch requires access to gup flags, so > pass the flags argument through to the __gup_device_* > functions. >=20 > Also placate checkpatch.pl by shortening a nearby line. >=20 > Reviewed-by: Ira Weiny > Cc: Kirill A. Shutemov > Signed-off-by: John Hubbard Reviewed-by: J=E9r=F4me Glisse > --- > mm/gup.c | 28 ++++++++++++++++++---------- > 1 file changed, 18 insertions(+), 10 deletions(-) >=20 > diff --git a/mm/gup.c b/mm/gup.c > index 8f236a335ae9..85caf76b3012 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1890,7 +1890,8 @@ static int gup_pte_range(pmd_t pmd, unsigned long a= ddr, unsigned long end, > =20 > #if defined(CONFIG_ARCH_HAS_PTE_DEVMAP) && defined(CONFIG_TRANSPARENT_HU= GEPAGE) > static int __gup_device_huge(unsigned long pfn, unsigned long addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09 struct page **pages, int *nr) > { > =09int nr_start =3D *nr; > =09struct dev_pagemap *pgmap =3D NULL; > @@ -1916,13 +1917,14 @@ static int __gup_device_huge(unsigned long pfn, u= nsigned long addr, > } > =20 > static int __gup_device_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long = addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09unsigned long fault_pfn; > =09int nr_start =3D *nr; > =20 > =09fault_pfn =3D pmd_pfn(orig) + ((addr & ~PMD_MASK) >> PAGE_SHIFT); > -=09if (!__gup_device_huge(fault_pfn, addr, end, pages, nr)) > +=09if (!__gup_device_huge(fault_pfn, addr, end, flags, pages, nr)) > =09=09return 0; > =20 > =09if (unlikely(pmd_val(orig) !=3D pmd_val(*pmdp))) { > @@ -1933,13 +1935,14 @@ static int __gup_device_huge_pmd(pmd_t orig, pmd_= t *pmdp, unsigned long addr, > } > =20 > static int __gup_device_huge_pud(pud_t orig, pud_t *pudp, unsigned long = addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09unsigned long fault_pfn; > =09int nr_start =3D *nr; > =20 > =09fault_pfn =3D pud_pfn(orig) + ((addr & ~PUD_MASK) >> PAGE_SHIFT); > -=09if (!__gup_device_huge(fault_pfn, addr, end, pages, nr)) > +=09if (!__gup_device_huge(fault_pfn, addr, end, flags, pages, nr)) > =09=09return 0; > =20 > =09if (unlikely(pud_val(orig) !=3D pud_val(*pudp))) { > @@ -1950,14 +1953,16 @@ static int __gup_device_huge_pud(pud_t orig, pud_= t *pudp, unsigned long addr, > } > #else > static int __gup_device_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long = addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09BUILD_BUG(); > =09return 0; > } > =20 > static int __gup_device_huge_pud(pud_t pud, pud_t *pudp, unsigned long a= ddr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09BUILD_BUG(); > =09return 0; > @@ -2062,7 +2067,8 @@ static int gup_huge_pmd(pmd_t orig, pmd_t *pmdp, un= signed long addr, > =09if (pmd_devmap(orig)) { > =09=09if (unlikely(flags & FOLL_LONGTERM)) > =09=09=09return 0; > -=09=09return __gup_device_huge_pmd(orig, pmdp, addr, end, pages, nr); > +=09=09return __gup_device_huge_pmd(orig, pmdp, addr, end, flags, > +=09=09=09=09=09 pages, nr); > =09} > =20 > =09refs =3D 0; > @@ -2092,7 +2098,8 @@ static int gup_huge_pmd(pmd_t orig, pmd_t *pmdp, un= signed long addr, > } > =20 > static int gup_huge_pud(pud_t orig, pud_t *pudp, unsigned long addr, > -=09=09unsigned long end, unsigned int flags, struct page **pages, int *n= r) > +=09=09=09unsigned long end, unsigned int flags, > +=09=09=09struct page **pages, int *nr) > { > =09struct page *head, *page; > =09int refs; > @@ -2103,7 +2110,8 @@ static int gup_huge_pud(pud_t orig, pud_t *pudp, un= signed long addr, > =09if (pud_devmap(orig)) { > =09=09if (unlikely(flags & FOLL_LONGTERM)) > =09=09=09return 0; > -=09=09return __gup_device_huge_pud(orig, pudp, addr, end, pages, nr); > +=09=09return __gup_device_huge_pud(orig, pudp, addr, end, flags, > +=09=09=09=09=09 pages, nr); > =09} > =20 > =09refs =3D 0; > --=20 > 2.23.0 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Glisse Subject: Re: [PATCH v2 01/18] mm/gup: pass flags arg to __gup_device_* functions Date: Mon, 4 Nov 2019 11:39:19 -0500 Message-ID: <20191104163919.GA5134@redhat.com> References: <20191103211813.213227-1-jhubbard@nvidia.com> <20191103211813.213227-2-jhubbard@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20191103211813.213227-2-jhubbard@nvidia.com> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko List-Id: dri-devel@lists.freedesktop.org On Sun, Nov 03, 2019 at 01:17:56PM -0800, John Hubbard wrote: > A subsequent patch requires access to gup flags, so > pass the flags argument through to the __gup_device_* > functions. >=20 > Also placate checkpatch.pl by shortening a nearby line. >=20 > Reviewed-by: Ira Weiny > Cc: Kirill A. Shutemov > Signed-off-by: John Hubbard Reviewed-by: J=E9r=F4me Glisse > --- > mm/gup.c | 28 ++++++++++++++++++---------- > 1 file changed, 18 insertions(+), 10 deletions(-) >=20 > diff --git a/mm/gup.c b/mm/gup.c > index 8f236a335ae9..85caf76b3012 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1890,7 +1890,8 @@ static int gup_pte_range(pmd_t pmd, unsigned long a= ddr, unsigned long end, > =20 > #if defined(CONFIG_ARCH_HAS_PTE_DEVMAP) && defined(CONFIG_TRANSPARENT_HU= GEPAGE) > static int __gup_device_huge(unsigned long pfn, unsigned long addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09 struct page **pages, int *nr) > { > =09int nr_start =3D *nr; > =09struct dev_pagemap *pgmap =3D NULL; > @@ -1916,13 +1917,14 @@ static int __gup_device_huge(unsigned long pfn, u= nsigned long addr, > } > =20 > static int __gup_device_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long = addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09unsigned long fault_pfn; > =09int nr_start =3D *nr; > =20 > =09fault_pfn =3D pmd_pfn(orig) + ((addr & ~PMD_MASK) >> PAGE_SHIFT); > -=09if (!__gup_device_huge(fault_pfn, addr, end, pages, nr)) > +=09if (!__gup_device_huge(fault_pfn, addr, end, flags, pages, nr)) > =09=09return 0; > =20 > =09if (unlikely(pmd_val(orig) !=3D pmd_val(*pmdp))) { > @@ -1933,13 +1935,14 @@ static int __gup_device_huge_pmd(pmd_t orig, pmd_= t *pmdp, unsigned long addr, > } > =20 > static int __gup_device_huge_pud(pud_t orig, pud_t *pudp, unsigned long = addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09unsigned long fault_pfn; > =09int nr_start =3D *nr; > =20 > =09fault_pfn =3D pud_pfn(orig) + ((addr & ~PUD_MASK) >> PAGE_SHIFT); > -=09if (!__gup_device_huge(fault_pfn, addr, end, pages, nr)) > +=09if (!__gup_device_huge(fault_pfn, addr, end, flags, pages, nr)) > =09=09return 0; > =20 > =09if (unlikely(pud_val(orig) !=3D pud_val(*pudp))) { > @@ -1950,14 +1953,16 @@ static int __gup_device_huge_pud(pud_t orig, pud_= t *pudp, unsigned long addr, > } > #else > static int __gup_device_huge_pmd(pmd_t orig, pmd_t *pmdp, unsigned long = addr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09BUILD_BUG(); > =09return 0; > } > =20 > static int __gup_device_huge_pud(pud_t pud, pud_t *pudp, unsigned long a= ddr, > -=09=09unsigned long end, struct page **pages, int *nr) > +=09=09=09=09 unsigned long end, unsigned int flags, > +=09=09=09=09 struct page **pages, int *nr) > { > =09BUILD_BUG(); > =09return 0; > @@ -2062,7 +2067,8 @@ static int gup_huge_pmd(pmd_t orig, pmd_t *pmdp, un= signed long addr, > =09if (pmd_devmap(orig)) { > =09=09if (unlikely(flags & FOLL_LONGTERM)) > =09=09=09return 0; > -=09=09return __gup_device_huge_pmd(orig, pmdp, addr, end, pages, nr); > +=09=09return __gup_device_huge_pmd(orig, pmdp, addr, end, flags, > +=09=09=09=09=09 pages, nr); > =09} > =20 > =09refs =3D 0; > @@ -2092,7 +2098,8 @@ static int gup_huge_pmd(pmd_t orig, pmd_t *pmdp, un= signed long addr, > } > =20 > static int gup_huge_pud(pud_t orig, pud_t *pudp, unsigned long addr, > -=09=09unsigned long end, unsigned int flags, struct page **pages, int *n= r) > +=09=09=09unsigned long end, unsigned int flags, > +=09=09=09struct page **pages, int *nr) > { > =09struct page *head, *page; > =09int refs; > @@ -2103,7 +2110,8 @@ static int gup_huge_pud(pud_t orig, pud_t *pudp, un= signed long addr, > =09if (pud_devmap(orig)) { > =09=09if (unlikely(flags & FOLL_LONGTERM)) > =09=09=09return 0; > -=09=09return __gup_device_huge_pud(orig, pudp, addr, end, pages, nr); > +=09=09return __gup_device_huge_pud(orig, pudp, addr, end, flags, > +=09=09=09=09=09 pages, nr); > =09} > =20 > =09refs =3D 0; > --=20 > 2.23.0 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 061A2CA9EB5 for ; Mon, 4 Nov 2019 16:39:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D89DA21928 for ; Mon, 4 Nov 2019 16:39:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D89DA21928 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F344F6E226; Mon, 4 Nov 2019 16:39:38 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC9236E226 for ; Mon, 4 Nov 2019 16:39:36 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-XcpsC-lSP4a7ehsn9d2sxg-1; Mon, 04 Nov 2019 11:39:31 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D6C88017DD; Mon, 4 Nov 2019 16:39:27 +0000 (UTC) Received: from redhat.com (unknown [10.20.6.178]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F0A6F5C240; Mon, 4 Nov 2019 16:39:20 +0000 (UTC) Date: Mon, 4 Nov 2019 11:39:19 -0500 From: Jerome Glisse To: John Hubbard Subject: Re: [PATCH v2 01/18] mm/gup: pass flags arg to __gup_device_* functions Message-ID: <20191104163919.GA5134@redhat.com> References: <20191103211813.213227-1-jhubbard@nvidia.com> <20191103211813.213227-2-jhubbard@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20191103211813.213227-2-jhubbard@nvidia.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: XcpsC-lSP4a7ehsn9d2sxg-1 X-Mimecast-Spam-Score: 0 Content-Disposition: inline X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572885575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZKRtyHtWqxotoMRVCD2L231GIf5CzzOu6K7yMpGCV1E=; b=EISj5KjZrUl3kZNHgeVxg9gzAbcLy4Tpe15p04ZJX+1X/PP0zhFi/jqdDWYjMDEhoU+i0C JuU/cWz6scDZOZMQlwE2N2QuxICFFYXRzNVTjImH796mEQWD/wjXHkzq8BvJ4gOxbXcJlq N9g+v2tQVhedXU+Lsqq3rbwA789furQ= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Jan Kara , kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , Dave Chinner , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Paul Mackerras , linux-kselftest@vger.kernel.org, Ira Weiny , Jonathan Corbet , linux-rdma@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Jason Gunthorpe , Vlastimil Babka , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , linux-media@vger.kernel.org, Shuah Khan , linux-block@vger.kernel.org, Alex Williamson , Al Viro , Dan Williams , Mauro Carvalho Chehab , bpf@vger.kernel.org, Magnus Karlsson , Jens Axboe , netdev@vger.kernel.org, LKML , linux-fsdevel@vger.kernel.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" , "Kirill A . Shutemov" , Mike Kravetz Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191104163919.kvIKxL-s2YnMndMJ25MHCeT1QID_uqtZq_WLizXdeIQ@z> T24gU3VuLCBOb3YgMDMsIDIwMTkgYXQgMDE6MTc6NTZQTSAtMDgwMCwgSm9obiBIdWJiYXJkIHdy b3RlOgo+IEEgc3Vic2VxdWVudCBwYXRjaCByZXF1aXJlcyBhY2Nlc3MgdG8gZ3VwIGZsYWdzLCBz bwo+IHBhc3MgdGhlIGZsYWdzIGFyZ3VtZW50IHRocm91Z2ggdG8gdGhlIF9fZ3VwX2RldmljZV8q Cj4gZnVuY3Rpb25zLgo+IAo+IEFsc28gcGxhY2F0ZSBjaGVja3BhdGNoLnBsIGJ5IHNob3J0ZW5p bmcgYSBuZWFyYnkgbGluZS4KPiAKPiBSZXZpZXdlZC1ieTogSXJhIFdlaW55IDxpcmEud2VpbnlA aW50ZWwuY29tPgo+IENjOiBLaXJpbGwgQS4gU2h1dGVtb3YgPGtpcmlsbC5zaHV0ZW1vdkBsaW51 eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSm9obiBIdWJiYXJkIDxqaHViYmFyZEBudmlk aWEuY29tPgoKUmV2aWV3ZWQtYnk6IErDqXLDtG1lIEdsaXNzZSA8amdsaXNzZUByZWRoYXQuY29t PgoKPiAtLS0KPiAgbW0vZ3VwLmMgfCAyOCArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvbW0vZ3VwLmMgYi9tbS9ndXAuYwo+IGluZGV4IDhmMjM2YTMzNWFlOS4uODVj YWY3NmIzMDEyIDEwMDY0NAo+IC0tLSBhL21tL2d1cC5jCj4gKysrIGIvbW0vZ3VwLmMKPiBAQCAt MTg5MCw3ICsxODkwLDggQEAgc3RhdGljIGludCBndXBfcHRlX3JhbmdlKHBtZF90IHBtZCwgdW5z aWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBsb25nIGVuZCwKPiAgCj4gICNpZiBkZWZpbmVkKENP TkZJR19BUkNIX0hBU19QVEVfREVWTUFQKSAmJiBkZWZpbmVkKENPTkZJR19UUkFOU1BBUkVOVF9I VUdFUEFHRSkKPiAgc3RhdGljIGludCBfX2d1cF9kZXZpY2VfaHVnZSh1bnNpZ25lZCBsb25nIHBm biwgdW5zaWduZWQgbG9uZyBhZGRyLAo+IC0JCXVuc2lnbmVkIGxvbmcgZW5kLCBzdHJ1Y3QgcGFn ZSAqKnBhZ2VzLCBpbnQgKm5yKQo+ICsJCQkgICAgIHVuc2lnbmVkIGxvbmcgZW5kLCB1bnNpZ25l ZCBpbnQgZmxhZ3MsCj4gKwkJCSAgICAgc3RydWN0IHBhZ2UgKipwYWdlcywgaW50ICpucikKPiAg ewo+ICAJaW50IG5yX3N0YXJ0ID0gKm5yOwo+ICAJc3RydWN0IGRldl9wYWdlbWFwICpwZ21hcCA9 IE5VTEw7Cj4gQEAgLTE5MTYsMTMgKzE5MTcsMTQgQEAgc3RhdGljIGludCBfX2d1cF9kZXZpY2Vf aHVnZSh1bnNpZ25lZCBsb25nIHBmbiwgdW5zaWduZWQgbG9uZyBhZGRyLAo+ICB9Cj4gIAo+ICBz dGF0aWMgaW50IF9fZ3VwX2RldmljZV9odWdlX3BtZChwbWRfdCBvcmlnLCBwbWRfdCAqcG1kcCwg dW5zaWduZWQgbG9uZyBhZGRyLAo+IC0JCXVuc2lnbmVkIGxvbmcgZW5kLCBzdHJ1Y3QgcGFnZSAq KnBhZ2VzLCBpbnQgKm5yKQo+ICsJCQkJIHVuc2lnbmVkIGxvbmcgZW5kLCB1bnNpZ25lZCBpbnQg ZmxhZ3MsCj4gKwkJCQkgc3RydWN0IHBhZ2UgKipwYWdlcywgaW50ICpucikKPiAgewo+ICAJdW5z aWduZWQgbG9uZyBmYXVsdF9wZm47Cj4gIAlpbnQgbnJfc3RhcnQgPSAqbnI7Cj4gIAo+ICAJZmF1 bHRfcGZuID0gcG1kX3BmbihvcmlnKSArICgoYWRkciAmIH5QTURfTUFTSykgPj4gUEFHRV9TSElG VCk7Cj4gLQlpZiAoIV9fZ3VwX2RldmljZV9odWdlKGZhdWx0X3BmbiwgYWRkciwgZW5kLCBwYWdl cywgbnIpKQo+ICsJaWYgKCFfX2d1cF9kZXZpY2VfaHVnZShmYXVsdF9wZm4sIGFkZHIsIGVuZCwg ZmxhZ3MsIHBhZ2VzLCBucikpCj4gIAkJcmV0dXJuIDA7Cj4gIAo+ICAJaWYgKHVubGlrZWx5KHBt ZF92YWwob3JpZykgIT0gcG1kX3ZhbCgqcG1kcCkpKSB7Cj4gQEAgLTE5MzMsMTMgKzE5MzUsMTQg QEAgc3RhdGljIGludCBfX2d1cF9kZXZpY2VfaHVnZV9wbWQocG1kX3Qgb3JpZywgcG1kX3QgKnBt ZHAsIHVuc2lnbmVkIGxvbmcgYWRkciwKPiAgfQo+ICAKPiAgc3RhdGljIGludCBfX2d1cF9kZXZp Y2VfaHVnZV9wdWQocHVkX3Qgb3JpZywgcHVkX3QgKnB1ZHAsIHVuc2lnbmVkIGxvbmcgYWRkciwK PiAtCQl1bnNpZ25lZCBsb25nIGVuZCwgc3RydWN0IHBhZ2UgKipwYWdlcywgaW50ICpucikKPiAr CQkJCSB1bnNpZ25lZCBsb25nIGVuZCwgdW5zaWduZWQgaW50IGZsYWdzLAo+ICsJCQkJIHN0cnVj dCBwYWdlICoqcGFnZXMsIGludCAqbnIpCj4gIHsKPiAgCXVuc2lnbmVkIGxvbmcgZmF1bHRfcGZu Owo+ICAJaW50IG5yX3N0YXJ0ID0gKm5yOwo+ICAKPiAgCWZhdWx0X3BmbiA9IHB1ZF9wZm4ob3Jp ZykgKyAoKGFkZHIgJiB+UFVEX01BU0spID4+IFBBR0VfU0hJRlQpOwo+IC0JaWYgKCFfX2d1cF9k ZXZpY2VfaHVnZShmYXVsdF9wZm4sIGFkZHIsIGVuZCwgcGFnZXMsIG5yKSkKPiArCWlmICghX19n dXBfZGV2aWNlX2h1Z2UoZmF1bHRfcGZuLCBhZGRyLCBlbmQsIGZsYWdzLCBwYWdlcywgbnIpKQo+ ICAJCXJldHVybiAwOwo+ICAKPiAgCWlmICh1bmxpa2VseShwdWRfdmFsKG9yaWcpICE9IHB1ZF92 YWwoKnB1ZHApKSkgewo+IEBAIC0xOTUwLDE0ICsxOTUzLDE2IEBAIHN0YXRpYyBpbnQgX19ndXBf ZGV2aWNlX2h1Z2VfcHVkKHB1ZF90IG9yaWcsIHB1ZF90ICpwdWRwLCB1bnNpZ25lZCBsb25nIGFk ZHIsCj4gIH0KPiAgI2Vsc2UKPiAgc3RhdGljIGludCBfX2d1cF9kZXZpY2VfaHVnZV9wbWQocG1k X3Qgb3JpZywgcG1kX3QgKnBtZHAsIHVuc2lnbmVkIGxvbmcgYWRkciwKPiAtCQl1bnNpZ25lZCBs b25nIGVuZCwgc3RydWN0IHBhZ2UgKipwYWdlcywgaW50ICpucikKPiArCQkJCSB1bnNpZ25lZCBs b25nIGVuZCwgdW5zaWduZWQgaW50IGZsYWdzLAo+ICsJCQkJIHN0cnVjdCBwYWdlICoqcGFnZXMs IGludCAqbnIpCj4gIHsKPiAgCUJVSUxEX0JVRygpOwo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4g IHN0YXRpYyBpbnQgX19ndXBfZGV2aWNlX2h1Z2VfcHVkKHB1ZF90IHB1ZCwgcHVkX3QgKnB1ZHAs IHVuc2lnbmVkIGxvbmcgYWRkciwKPiAtCQl1bnNpZ25lZCBsb25nIGVuZCwgc3RydWN0IHBhZ2Ug KipwYWdlcywgaW50ICpucikKPiArCQkJCSB1bnNpZ25lZCBsb25nIGVuZCwgdW5zaWduZWQgaW50 IGZsYWdzLAo+ICsJCQkJIHN0cnVjdCBwYWdlICoqcGFnZXMsIGludCAqbnIpCj4gIHsKPiAgCUJV SUxEX0JVRygpOwo+ICAJcmV0dXJuIDA7Cj4gQEAgLTIwNjIsNyArMjA2Nyw4IEBAIHN0YXRpYyBp bnQgZ3VwX2h1Z2VfcG1kKHBtZF90IG9yaWcsIHBtZF90ICpwbWRwLCB1bnNpZ25lZCBsb25nIGFk ZHIsCj4gIAlpZiAocG1kX2Rldm1hcChvcmlnKSkgewo+ICAJCWlmICh1bmxpa2VseShmbGFncyAm IEZPTExfTE9OR1RFUk0pKQo+ICAJCQlyZXR1cm4gMDsKPiAtCQlyZXR1cm4gX19ndXBfZGV2aWNl X2h1Z2VfcG1kKG9yaWcsIHBtZHAsIGFkZHIsIGVuZCwgcGFnZXMsIG5yKTsKPiArCQlyZXR1cm4g X19ndXBfZGV2aWNlX2h1Z2VfcG1kKG9yaWcsIHBtZHAsIGFkZHIsIGVuZCwgZmxhZ3MsCj4gKwkJ CQkJICAgICBwYWdlcywgbnIpOwo+ICAJfQo+ICAKPiAgCXJlZnMgPSAwOwo+IEBAIC0yMDkyLDcg KzIwOTgsOCBAQCBzdGF0aWMgaW50IGd1cF9odWdlX3BtZChwbWRfdCBvcmlnLCBwbWRfdCAqcG1k cCwgdW5zaWduZWQgbG9uZyBhZGRyLAo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IGd1cF9odWdlX3B1 ZChwdWRfdCBvcmlnLCBwdWRfdCAqcHVkcCwgdW5zaWduZWQgbG9uZyBhZGRyLAo+IC0JCXVuc2ln bmVkIGxvbmcgZW5kLCB1bnNpZ25lZCBpbnQgZmxhZ3MsIHN0cnVjdCBwYWdlICoqcGFnZXMsIGlu dCAqbnIpCj4gKwkJCXVuc2lnbmVkIGxvbmcgZW5kLCB1bnNpZ25lZCBpbnQgZmxhZ3MsCj4gKwkJ CXN0cnVjdCBwYWdlICoqcGFnZXMsIGludCAqbnIpCj4gIHsKPiAgCXN0cnVjdCBwYWdlICpoZWFk LCAqcGFnZTsKPiAgCWludCByZWZzOwo+IEBAIC0yMTAzLDcgKzIxMTAsOCBAQCBzdGF0aWMgaW50 IGd1cF9odWdlX3B1ZChwdWRfdCBvcmlnLCBwdWRfdCAqcHVkcCwgdW5zaWduZWQgbG9uZyBhZGRy LAo+ICAJaWYgKHB1ZF9kZXZtYXAob3JpZykpIHsKPiAgCQlpZiAodW5saWtlbHkoZmxhZ3MgJiBG T0xMX0xPTkdURVJNKSkKPiAgCQkJcmV0dXJuIDA7Cj4gLQkJcmV0dXJuIF9fZ3VwX2RldmljZV9o dWdlX3B1ZChvcmlnLCBwdWRwLCBhZGRyLCBlbmQsIHBhZ2VzLCBucik7Cj4gKwkJcmV0dXJuIF9f Z3VwX2RldmljZV9odWdlX3B1ZChvcmlnLCBwdWRwLCBhZGRyLCBlbmQsIGZsYWdzLAo+ICsJCQkJ CSAgICAgcGFnZXMsIG5yKTsKPiAgCX0KPiAgCj4gIAlyZWZzID0gMDsKPiAtLSAKPiAyLjIzLjAK PiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==