From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35023CA9EC9 for ; Mon, 4 Nov 2019 21:52:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 072E721850 for ; Mon, 4 Nov 2019 21:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572904370; bh=eB8OcREBndT+A5hyfQrTyGkWl3QxuRF+jZflQikaaIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=KxBtgUvcBHBO1YRdRO5GLpq9QilB/LUhtcY9KYtpAz/FmzmjCPZy3SsMXIw2Wn4Eq pLkUrjsdStWQuAJp/qk7P7LAVim23rECOsQS/jKNKR7vehXHC7joBN+mCfwr1h2I5f Y0AKIjxFYeFagdXoWJBKehEkKBuVNSeLBilYHNP0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730837AbfKDVws (ORCPT ); Mon, 4 Nov 2019 16:52:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:46376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730796AbfKDVwo (ORCPT ); Mon, 4 Nov 2019 16:52:44 -0500 Received: from localhost (6.204-14-84.ripe.coltfrance.com [84.14.204.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7350B217F5; Mon, 4 Nov 2019 21:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572904364; bh=eB8OcREBndT+A5hyfQrTyGkWl3QxuRF+jZflQikaaIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v1QRgc2XDSMATgUVC/XwdHbHwMuX1O5BuGUuLA6v0oOhoLYXit7AIZpZCqhccYYWq we6mZaR4GOOAWkLBdXnIz0WGQobQW3ysO83wz69V5igXgLJ9c50lRI1RmurdUIjmuY VZ8EYJa34c46zZf3Bbg5YqIy/PR6TUdLW/BDtFQE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sven Van Asbroeck , Bjorn Helgaas , Sinan Kaya , Frederick Lawler , Mika Westerberg , Keith Busch , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 4.14 22/95] PCI/PME: Fix possible use-after-free on remove Date: Mon, 4 Nov 2019 22:44:20 +0100 Message-Id: <20191104212052.393906364@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191104212038.056365853@linuxfoundation.org> References: <20191104212038.056365853@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sven Van Asbroeck [ Upstream commit 7cf58b79b3072029af127ae865ffc6f00f34b1f8 ] In remove(), ensure that the PME work cannot run after kfree() is called. Otherwise, this could result in a use-after-free. This issue was detected with the help of Coccinelle. Signed-off-by: Sven Van Asbroeck Signed-off-by: Bjorn Helgaas Cc: Sinan Kaya Cc: Frederick Lawler Cc: Mika Westerberg Cc: Keith Busch Cc: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/pci/pcie/pme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c index c2e6e3d1073f8..5500660bbb104 100644 --- a/drivers/pci/pcie/pme.c +++ b/drivers/pci/pcie/pme.c @@ -441,6 +441,7 @@ static void pcie_pme_remove(struct pcie_device *srv) pcie_pme_disable_interrupt(srv->port, data); free_irq(srv->irq, srv); + cancel_work_sync(&data->work); kfree(data); } -- 2.20.1