From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C19DCA9ED3 for ; Mon, 4 Nov 2019 22:04:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E366214D8 for ; Mon, 4 Nov 2019 22:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905064; bh=WD4dEYGfx+vDqZ++erXNFlqFoVPlAJ90CR+pwNc7X8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lWwURtpIFm5/VseyWcun9xKO/4tiY/FgGsxeVQK49jFTnVeqMvmYGKy4fkgOISTPl I1r6KM7av5aMYJ3AVtWbT4sBkF3nZDOhMUl/0JEOIeGmPlRDjW6H9PZfDavqpHJjv3 qbhBz//swT5+Sj4fVP1Ngwu5lIGsdYsgeErtv/Dc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389654AbfKDWEW (ORCPT ); Mon, 4 Nov 2019 17:04:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:34950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388315AbfKDWEU (ORCPT ); Mon, 4 Nov 2019 17:04:20 -0500 Received: from localhost (6.204-14-84.ripe.coltfrance.com [84.14.204.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0ACB9214D8; Mon, 4 Nov 2019 22:04:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905059; bh=WD4dEYGfx+vDqZ++erXNFlqFoVPlAJ90CR+pwNc7X8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bq0OudHQdFVKq6/DEniIDhvHi+wO/E7ueumKxqi+OBp26gGS4YSE3GYuOk+j9+xYO ZFv4/L3TrF8y43hSdf1xEYHB9inRUfZzSFVkzeiXJwwND/I/7XQEA2wSx617re0jmY eDiPNF3ihKBcuUGtXRm2hmbyd/S4R7W3qgrVtfXI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Russell King - ARM Linux admin , Adrian Hunter , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Will Deacon , Arnaldo Carvalho de Melo , Sasha Levin , Peter Zijlstra Subject: [PATCH 5.3 015/163] perf annotate: Fix the signedness of failure returns Date: Mon, 4 Nov 2019 22:43:25 +0100 Message-Id: <20191104212141.543471665@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191104212140.046021995@linuxfoundation.org> References: <20191104212140.046021995@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo [ Upstream commit 28f4417c3333940b242af03d90214f713bbef232 ] Callers of symbol__annotate() expect a errno value or some other extended error value range in symbol__strerror_disassemble() to convert to a proper error string, fix it when propagating a failure to find the arch specific annotation routines via arch__find(arch_name). Reported-by: Russell King - ARM Linux admin Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra , Cc: Will Deacon Link: https://lkml.kernel.org/n/tip-o0k6dw7cas0vvmjjvgsyvu1i@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 6d9642c082e52..2dac51e9e4180 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -2069,7 +2069,7 @@ int symbol__annotate(struct symbol *sym, struct map *map, args.arch = arch = arch__find(arch_name); if (arch == NULL) - return -ENOTSUP; + return ENOTSUP; if (parch) *parch = arch; -- 2.20.1