From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC69CA9ED3 for ; Mon, 4 Nov 2019 22:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 074DD218BA for ; Mon, 4 Nov 2019 22:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905138; bh=NjxgLiEaplHS39J1mvZTecb/FKS7xh3ECqXe5Meeb1E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1VxpF/SHtAEjDlS91HM8bFqGTbtM+W6xsmZf57cnji3csi3EBrnzHjHkGr25v1yKf 18UtAWhOYZwcAQLJikr3uI6oZvkAsz6GzlN/ss867NZ/qRlERBB2I6lsabQ7oo7OA2 cKy3Zu3flYf9G92bT+w0zPHhiah9aEIbmhaCld+E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389851AbfKDWFg (ORCPT ); Mon, 4 Nov 2019 17:05:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:36852 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388444AbfKDWF3 (ORCPT ); Mon, 4 Nov 2019 17:05:29 -0500 Received: from localhost (6.204-14-84.ripe.coltfrance.com [84.14.204.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A182E2084D; Mon, 4 Nov 2019 22:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905129; bh=NjxgLiEaplHS39J1mvZTecb/FKS7xh3ECqXe5Meeb1E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FdiwL18mZDpu6kEsp5i85i1dCXuR1t4mTmy0p+0BH8B8q47pwC4kbO9cm8JoHIAPf 5chXSz4JXu62ThtCMigsuZ0yV/GiKBOEjg0aG9em8CT7U7BB0uE2j4K7Qgso9YBitQ Cspbzz74MOAVbDsopL8o7542hNgjcHYam8T3bpm0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.3 037/163] RDMA/core: Fix an error handling path in res_get_common_doit() Date: Mon, 4 Nov 2019 22:43:47 +0100 Message-Id: <20191104212142.888554239@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191104212140.046021995@linuxfoundation.org> References: <20191104212140.046021995@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit ab59ca3eb4e7059727df85eee68bda169d26c8f8 ] According to surrounding error paths, it is likely that 'goto err_get;' is expected here. Otherwise, a call to 'rdma_restrack_put(res);' would be missing. Fixes: c5dfe0ea6ffa ("RDMA/nldev: Add resource tracker doit callback") Link: https://lore.kernel.org/r/20190818091044.8845-1-christophe.jaillet@wanadoo.fr Signed-off-by: Christophe JAILLET Reviewed-by: Jason Gunthorpe Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/core/nldev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c index 020c269765584..91e2cc9ddb9f8 100644 --- a/drivers/infiniband/core/nldev.c +++ b/drivers/infiniband/core/nldev.c @@ -1230,7 +1230,7 @@ static int res_get_common_doit(struct sk_buff *skb, struct nlmsghdr *nlh, msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); if (!msg) { ret = -ENOMEM; - goto err; + goto err_get; } nlh = nlmsg_put(msg, NETLINK_CB(skb).portid, nlh->nlmsg_seq, -- 2.20.1