From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 1/1] errno.h: Provide EFSBADCRC for everybody Date: Tue, 5 Nov 2019 10:05:35 +0100 Message-ID: <20191105090535.GI22379@quack2.suse.cz> References: <20191105024618.194134-1-Valdis.Kletnieks@vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191105024618.194134-1-Valdis.Kletnieks@vt.edu> Sender: linux-kernel-owner@vger.kernel.org To: Valdis Kletnieks Cc: Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Chao Yu , "Darrick J. Wong" , linux-xfs@vger.kernel.org, Jan Kara , Arnd Bergmann , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Mon 04-11-19 21:46:14, Valdis Kletnieks wrote: > Four filesystems have their own defines for this. Move it > into errno.h so it's defined in just one place. > > Signed-off-by: Valdis Kletnieks Thanks for the patch! It looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/ext4.h | 2 -- > fs/f2fs/f2fs.h | 2 -- > fs/xfs/xfs_linux.h | 1 - > include/linux/jbd2.h | 2 -- > include/uapi/asm-generic/errno.h | 1 + > 5 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > index a86c2585457d..79b3fd8291ab 100644 > --- a/fs/ext4/ext4.h > +++ b/fs/ext4/ext4.h > @@ -3395,6 +3395,4 @@ static inline int ext4_buffer_uptodate(struct buffer_head *bh) > > #endif /* __KERNEL__ */ > > -#define EFSBADCRC EBADMSG /* Bad CRC detected */ > - > #endif /* _EXT4_H */ > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 04ebe77569a3..ba23fd18d44a 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -3751,6 +3751,4 @@ static inline bool is_journalled_quota(struct f2fs_sb_info *sbi) > return false; > } > > -#define EFSBADCRC EBADMSG /* Bad CRC detected */ > - > #endif /* _LINUX_F2FS_H */ > diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h > index 3409d02a7d21..abdfc506618d 100644 > --- a/fs/xfs/xfs_linux.h > +++ b/fs/xfs/xfs_linux.h > @@ -123,7 +123,6 @@ typedef __u32 xfs_nlink_t; > > #define ENOATTR ENODATA /* Attribute not found */ > #define EWRONGFS EINVAL /* Mount with wrong filesystem type */ > -#define EFSBADCRC EBADMSG /* Bad CRC detected */ > > #define SYNCHRONIZE() barrier() > #define __return_address __builtin_return_address(0) > diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h > index 69411d7e0431..e07692fe6f20 100644 > --- a/include/linux/jbd2.h > +++ b/include/linux/jbd2.h > @@ -1656,6 +1656,4 @@ static inline tid_t jbd2_get_latest_transaction(journal_t *journal) > > #endif /* __KERNEL__ */ > > -#define EFSBADCRC EBADMSG /* Bad CRC detected */ > - > #endif /* _LINUX_JBD2_H */ > diff --git a/include/uapi/asm-generic/errno.h b/include/uapi/asm-generic/errno.h > index 1d5ffdf54cb0..e4cae9a9ae79 100644 > --- a/include/uapi/asm-generic/errno.h > +++ b/include/uapi/asm-generic/errno.h > @@ -55,6 +55,7 @@ > #define EMULTIHOP 72 /* Multihop attempted */ > #define EDOTDOT 73 /* RFS specific error */ > #define EBADMSG 74 /* Not a data message */ > +#define EFSBADCRC EBADMSG /* Bad CRC detected */ > #define EOVERFLOW 75 /* Value too large for defined data type */ > #define ENOTUNIQ 76 /* Name not unique on network */ > #define EBADFD 77 /* File descriptor in bad state */ > -- > 2.24.0.rc1 > -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F96C49EAB for ; Tue, 5 Nov 2019 09:05:47 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 013AF20869 for ; Tue, 5 Nov 2019 09:05:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="eFVaMgWI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="KT1HGnky" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 013AF20869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iRumY-0003tf-GT; Tue, 05 Nov 2019 09:05:46 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iRumW-0003tS-9K for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Nov 2019 09:05:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P7H+YqU9aJWbQaIxlTVGUu5tzah04zY7vQSJsu9rw/M=; b=eFVaMgWIE0lUdGIHV5V2+leUrp s/PlFlO39yXOFqhVUZLlTN2R8H8WpCz0uix7yoqMVMrNBHJ7i8xIQxdf0Ldb4kjVe2k0iCB3qg/xs ILKennYKmi9i54FaJzv7PciKj47VXESackUSvuWoyEXP3h4WAET0h+lygd7fB86DZZ4Y=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=P7H+YqU9aJWbQaIxlTVGUu5tzah04zY7vQSJsu9rw/M=; b=KT1HGnkyHbIkkg4clw+gggWMyY W4EptTJpLEUHsiQcbxoZFI1cUxMOVPv+NBQn426SpGcOh2NGpgiWgBK6bZJjMdPlKPlZY5u7Yk1nz 68+8mpFfmCb4QZbb1T5WytQS7uNzMo4JyjBUEBH+eCN78xoynaMdrSQhwq4lnWfS2+FM=; Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iRumU-000gKN-D3 for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Nov 2019 09:05:44 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B056DAC71; Tue, 5 Nov 2019 09:05:35 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 220971E4407; Tue, 5 Nov 2019 10:05:35 +0100 (CET) Date: Tue, 5 Nov 2019 10:05:35 +0100 From: Jan Kara To: Valdis Kletnieks Message-ID: <20191105090535.GI22379@quack2.suse.cz> References: <20191105024618.194134-1-Valdis.Kletnieks@vt.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191105024618.194134-1-Valdis.Kletnieks@vt.edu> User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1iRumU-000gKN-D3 Subject: Re: [f2fs-dev] [PATCH 1/1] errno.h: Provide EFSBADCRC for everybody X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Theodore Ts'o , Arnd Bergmann , "Darrick J. Wong" , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Andreas Dilger , Jan Kara , Jaegeuk Kim , linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon 04-11-19 21:46:14, Valdis Kletnieks wrote: > Four filesystems have their own defines for this. Move it > into errno.h so it's defined in just one place. > > Signed-off-by: Valdis Kletnieks Thanks for the patch! It looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/ext4.h | 2 -- > fs/f2fs/f2fs.h | 2 -- > fs/xfs/xfs_linux.h | 1 - > include/linux/jbd2.h | 2 -- > include/uapi/asm-generic/errno.h | 1 + > 5 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > index a86c2585457d..79b3fd8291ab 100644 > --- a/fs/ext4/ext4.h > +++ b/fs/ext4/ext4.h > @@ -3395,6 +3395,4 @@ static inline int ext4_buffer_uptodate(struct buffer_head *bh) > > #endif /* __KERNEL__ */ > > -#define EFSBADCRC EBADMSG /* Bad CRC detected */ > - > #endif /* _EXT4_H */ > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 04ebe77569a3..ba23fd18d44a 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -3751,6 +3751,4 @@ static inline bool is_journalled_quota(struct f2fs_sb_info *sbi) > return false; > } > > -#define EFSBADCRC EBADMSG /* Bad CRC detected */ > - > #endif /* _LINUX_F2FS_H */ > diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h > index 3409d02a7d21..abdfc506618d 100644 > --- a/fs/xfs/xfs_linux.h > +++ b/fs/xfs/xfs_linux.h > @@ -123,7 +123,6 @@ typedef __u32 xfs_nlink_t; > > #define ENOATTR ENODATA /* Attribute not found */ > #define EWRONGFS EINVAL /* Mount with wrong filesystem type */ > -#define EFSBADCRC EBADMSG /* Bad CRC detected */ > > #define SYNCHRONIZE() barrier() > #define __return_address __builtin_return_address(0) > diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h > index 69411d7e0431..e07692fe6f20 100644 > --- a/include/linux/jbd2.h > +++ b/include/linux/jbd2.h > @@ -1656,6 +1656,4 @@ static inline tid_t jbd2_get_latest_transaction(journal_t *journal) > > #endif /* __KERNEL__ */ > > -#define EFSBADCRC EBADMSG /* Bad CRC detected */ > - > #endif /* _LINUX_JBD2_H */ > diff --git a/include/uapi/asm-generic/errno.h b/include/uapi/asm-generic/errno.h > index 1d5ffdf54cb0..e4cae9a9ae79 100644 > --- a/include/uapi/asm-generic/errno.h > +++ b/include/uapi/asm-generic/errno.h > @@ -55,6 +55,7 @@ > #define EMULTIHOP 72 /* Multihop attempted */ > #define EDOTDOT 73 /* RFS specific error */ > #define EBADMSG 74 /* Not a data message */ > +#define EFSBADCRC EBADMSG /* Bad CRC detected */ > #define EOVERFLOW 75 /* Value too large for defined data type */ > #define ENOTUNIQ 76 /* Name not unique on network */ > #define EBADFD 77 /* File descriptor in bad state */ > -- > 2.24.0.rc1 > -- Jan Kara SUSE Labs, CR _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel