From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1] cgroup_fj_stress: Avoid killall
Date: Tue, 5 Nov 2019 14:20:04 +0100 [thread overview]
Message-ID: <20191105132004.GA20849@dell5510> (raw)
In-Reply-To: <20191105112000.20633-1-cfamullaconrad@suse.de>
Hi Clements,
> We discovered problems that killall didn't catched all processes. With
> this patch, we collect the pids manually and kill them one after the
> other.
LGTM.
I wonder if we also want to kill cgroup_fj_proc this way (see cgroup_fj_common.sh).
I guess you're not planning to create minimal reproducer to prove the problem of
left processes after killall, are you?
> Signed-off-by: Clemens Famulla-Conrad <cfamullaconrad@suse.de>
> ---
> testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
> diff --git a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh
> index 698aa4979..27ea7634a 100755
> --- a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh
> +++ b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh
> @@ -74,6 +74,7 @@ setup
> export TMPFILE=./tmp_tasks.$$
> count=0
> +collected_pids=""
nit:
collected_pids=
...
Kind regards,
Petr
next prev parent reply other threads:[~2019-11-05 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 11:20 [LTP] [PATCH v1] cgroup_fj_stress: Avoid killall Clemens Famulla-Conrad
2019-11-05 13:20 ` Petr Vorel [this message]
2019-11-05 13:49 ` Clemens Famulla-Conrad
2019-11-06 17:12 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105132004.GA20849@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.