From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95358C5DF60 for ; Tue, 5 Nov 2019 23:34:21 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 14D8E217F5 for ; Tue, 5 Nov 2019 23:34:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14D8E217F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E0031BFA6; Wed, 6 Nov 2019 00:34:20 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 0805C1BF33 for ; Wed, 6 Nov 2019 00:34:18 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 15:34:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,271,1569308400"; d="scan'208";a="232661903" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga002.fm.intel.com with ESMTP; 05 Nov 2019 15:34:16 -0800 Date: Wed, 6 Nov 2019 07:30:18 +0800 From: Ye Xiaolong To: Ferruh Yigit Cc: "Yang, Qiming" , "Di, ChenxuX" , "dev@dpdk.org" , "Lu, Wenzhuo" Message-ID: <20191105233018.GB40305@intel.com> References: <20191024010310.35882-1-chenxux.di@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh On 11/05, Ferruh Yigit wrote: >On 10/28/2019 5:51 AM, Yang, Qiming wrote: >> Hi, >> >>> -----Original Message----- >>> From: Di, ChenxuX >>> Sent: Thursday, October 24, 2019 9:03 AM >>> To: dev@dpdk.org >>> Cc: Lu, Wenzhuo ; Yang, Qiming >>> ; Di, ChenxuX >>> Subject: [PATCH] app/testpmd: fix device hotplug remove >>> >>> Hotplug remove cause infinite loops. Fix by canceling port_close before >>> port_detach function when rmv_port_callback. >>> >>> Fixes: ac89d46096d5 ("net/i40e: release port upon close") >>> >>> Signed-off-by: Di ChenxuX >>> --- >>> app/test-pmd/testpmd.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index >>> 5701f3141..a264644a1 100644 >>> --- a/app/test-pmd/testpmd.c >>> +++ b/app/test-pmd/testpmd.c >>> @@ -2708,7 +2708,6 @@ rmv_port_callback(void *arg) >>> no_link_check = 1; >>> stop_port(port_id); >>> no_link_check = org_no_link_check; >>> - close_port(port_id); >>> detach_port_device(port_id); >>> if (need_to_start) >>> start_packet_forwarding(0); >>> -- >>> 2.17.1 >> >> NACK, this patch is not acceptable. >> > >I can't really follow what is the root cause of the failure here, @Qiming, if it >is a driver issue, can you please briefly describe what is wrong in the driver? The real issue lays in i40e driver's remove ops after it adopts the RTE_ETH_DEV_CLOSE_REMOVE flag, I've talked with chenxu and he'll send a new patch to fix this issue this patch tried to solve. Thanks, Xiaolong > >Thanks, >ferruh