diff for duplicates of <20191106140228.GA28081@renesas.com> diff --git a/a/1.txt b/N1/1.txt index 74a5c4f..253944b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,17 +1,30 @@ -T24gV2VkLCBOb3YgMDYsIDIwMTkgYXQgMDY6NTM6MDhBTSBFU1QsIFdlaSBZb25nanVuIHdyb3Rl -Og0KPkFkZCB0aGUgbWlzc2luZyB1bmxvY2sgYmVmb3JlIHJldHVybiBmcm9tIGZ1bmN0aW9uIGlk -dGNtX3Byb2JlKCkNCj5pbiB0aGUgZXJyb3IgaGFuZGxpbmcgY2FzZS4NCj4NCj5GaXhlczogM2E2 -YmE3ZGM3Nzk5ICgicHRwOiBBZGQgYSBwdHAgY2xvY2sgZHJpdmVyIGZvciBJRFQgQ2xvY2tNYXRy -aXguIikNCj5TaWduZWQtb2ZmLWJ5OiBXZWkgWW9uZ2p1biA8d2VpeW9uZ2p1bjFAaHVhd2VpLmNv -bT4NCj4tLS0NCj4gZHJpdmVycy9wdHAvcHRwX2Nsb2NrbWF0cml4LmMgfCA0ICsrKy0NCj4gMSBm -aWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPg0KPmRpZmYgLS1n -aXQgYS9kcml2ZXJzL3B0cC9wdHBfY2xvY2ttYXRyaXguYyBiL2RyaXZlcnMvcHRwL3B0cF9jbG9j -a21hdHJpeC5jDQo+aW5kZXggY2Y1ODg5YjdkODI1Li5hNTExMGI3YjRlY2UgMTAwNjQ0DQo+LS0t -IGEvZHJpdmVycy9wdHAvcHRwX2Nsb2NrbWF0cml4LmMNCj4rKysgYi9kcml2ZXJzL3B0cC9wdHBf -Y2xvY2ttYXRyaXguYw0KPkBAIC0xMjk0LDggKzEyOTQsMTAgQEAgc3RhdGljIGludCBpZHRjbV9w -cm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50LA0KPiANCj4gCWVyciA9IHNldF90b2Rfd3Jp -dGVfb3ZlcmhlYWQoaWR0Y20pOw0KPiANCj4tCWlmIChlcnIpDQo+KwlpZiAoZXJyKSB7DQo+KwkJ -bXV0ZXhfdW5sb2NrKCZpZHRjbS0+cmVnX2xvY2spOw0KPiAJCXJldHVybiBlcnI7DQo+Kwl9DQo+ -IA0KPiAJZXJyID0gaWR0Y21fbG9hZF9maXJtd2FyZShpZHRjbSwgJmNsaWVudC0+ZGV2KTsNCj4N -Cg0KWWVzLCBnb29kIGNhdGNoLiAgVGhhbmsteW91IGZvciB0aGUgZml4Lg0KDQpSZXZpZXdlZC1i -eTogVmluY2VudCBDaGVuZyAgPHZpbmNlbnQuY2hlbmcueGhAcmVuZXNhcy5jb20+DQo +On Wed, Nov 06, 2019 at 06:53:08AM EST, Wei Yongjun wrote: +>Add the missing unlock before return from function idtcm_probe() +>in the error handling case. +> +>Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.") +>Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> +>--- +> drivers/ptp/ptp_clockmatrix.c | 4 +++- +> 1 file changed, 3 insertions(+), 1 deletion(-) +> +>diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c +>index cf5889b7d825..a5110b7b4ece 100644 +>--- a/drivers/ptp/ptp_clockmatrix.c +>+++ b/drivers/ptp/ptp_clockmatrix.c +>@@ -1294,8 +1294,10 @@ static int idtcm_probe(struct i2c_client *client, +> +> err = set_tod_write_overhead(idtcm); +> +>- if (err) +>+ if (err) { +>+ mutex_unlock(&idtcm->reg_lock); +> return err; +>+ } +> +> err = idtcm_load_firmware(idtcm, &client->dev); +> + +Yes, good catch. Thank-you for the fix. + +Reviewed-by: Vincent Cheng <vincent.cheng.xh@renesas.com> diff --git a/a/content_digest b/N1/content_digest index 4b2cf04..66c1ebc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,29 +1,42 @@ "ref\020191106115308.112645-1-weiyongjun1@huawei.com\0" "From\0Vincent Cheng <vincent.cheng.xh@renesas.com>\0" "Subject\0Re: [PATCH -next] ptp: Fix missing unlock on error in idtcm_probe()\0" - "Date\0Wed, 06 Nov 2019 14:02:43 +0000\0" + "Date\0Wed, 6 Nov 2019 14:02:43 +0000\0" "To\0Wei Yongjun <weiyongjun1@huawei.com>\0" "Cc\0Richard Cochran <richardcochran@gmail.com>" netdev@vger.kernel.org <netdev@vger.kernel.org> " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gV2VkLCBOb3YgMDYsIDIwMTkgYXQgMDY6NTM6MDhBTSBFU1QsIFdlaSBZb25nanVuIHdyb3Rl\n" - "Og0KPkFkZCB0aGUgbWlzc2luZyB1bmxvY2sgYmVmb3JlIHJldHVybiBmcm9tIGZ1bmN0aW9uIGlk\n" - "dGNtX3Byb2JlKCkNCj5pbiB0aGUgZXJyb3IgaGFuZGxpbmcgY2FzZS4NCj4NCj5GaXhlczogM2E2\n" - "YmE3ZGM3Nzk5ICgicHRwOiBBZGQgYSBwdHAgY2xvY2sgZHJpdmVyIGZvciBJRFQgQ2xvY2tNYXRy\n" - "aXguIikNCj5TaWduZWQtb2ZmLWJ5OiBXZWkgWW9uZ2p1biA8d2VpeW9uZ2p1bjFAaHVhd2VpLmNv\n" - "bT4NCj4tLS0NCj4gZHJpdmVycy9wdHAvcHRwX2Nsb2NrbWF0cml4LmMgfCA0ICsrKy0NCj4gMSBm\n" - "aWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPg0KPmRpZmYgLS1n\n" - "aXQgYS9kcml2ZXJzL3B0cC9wdHBfY2xvY2ttYXRyaXguYyBiL2RyaXZlcnMvcHRwL3B0cF9jbG9j\n" - "a21hdHJpeC5jDQo+aW5kZXggY2Y1ODg5YjdkODI1Li5hNTExMGI3YjRlY2UgMTAwNjQ0DQo+LS0t\n" - "IGEvZHJpdmVycy9wdHAvcHRwX2Nsb2NrbWF0cml4LmMNCj4rKysgYi9kcml2ZXJzL3B0cC9wdHBf\n" - "Y2xvY2ttYXRyaXguYw0KPkBAIC0xMjk0LDggKzEyOTQsMTAgQEAgc3RhdGljIGludCBpZHRjbV9w\n" - "cm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50LA0KPiANCj4gCWVyciA9IHNldF90b2Rfd3Jp\n" - "dGVfb3ZlcmhlYWQoaWR0Y20pOw0KPiANCj4tCWlmIChlcnIpDQo+KwlpZiAoZXJyKSB7DQo+KwkJ\n" - "bXV0ZXhfdW5sb2NrKCZpZHRjbS0+cmVnX2xvY2spOw0KPiAJCXJldHVybiBlcnI7DQo+Kwl9DQo+\n" - "IA0KPiAJZXJyID0gaWR0Y21fbG9hZF9maXJtd2FyZShpZHRjbSwgJmNsaWVudC0+ZGV2KTsNCj4N\n" - "Cg0KWWVzLCBnb29kIGNhdGNoLiAgVGhhbmsteW91IGZvciB0aGUgZml4Lg0KDQpSZXZpZXdlZC1i\n" - eTogVmluY2VudCBDaGVuZyAgPHZpbmNlbnQuY2hlbmcueGhAcmVuZXNhcy5jb20+DQo + "On Wed, Nov 06, 2019 at 06:53:08AM EST, Wei Yongjun wrote:\n" + ">Add the missing unlock before return from function idtcm_probe()\n" + ">in the error handling case.\n" + ">\n" + ">Fixes: 3a6ba7dc7799 (\"ptp: Add a ptp clock driver for IDT ClockMatrix.\")\n" + ">Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>\n" + ">---\n" + "> drivers/ptp/ptp_clockmatrix.c | 4 +++-\n" + "> 1 file changed, 3 insertions(+), 1 deletion(-)\n" + ">\n" + ">diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c\n" + ">index cf5889b7d825..a5110b7b4ece 100644\n" + ">--- a/drivers/ptp/ptp_clockmatrix.c\n" + ">+++ b/drivers/ptp/ptp_clockmatrix.c\n" + ">@@ -1294,8 +1294,10 @@ static int idtcm_probe(struct i2c_client *client,\n" + "> \n" + "> \terr = set_tod_write_overhead(idtcm);\n" + "> \n" + ">-\tif (err)\n" + ">+\tif (err) {\n" + ">+\t\tmutex_unlock(&idtcm->reg_lock);\n" + "> \t\treturn err;\n" + ">+\t}\n" + "> \n" + "> \terr = idtcm_load_firmware(idtcm, &client->dev);\n" + ">\n" + "\n" + "Yes, good catch. Thank-you for the fix.\n" + "\n" + Reviewed-by: Vincent Cheng <vincent.cheng.xh@renesas.com> -ff0b2d87758ec2b11ab174047d39330d0cf6c85cbc2441d5b728761478ddd9db +fafbde18c5b80232f00e128139701f56f6f8de5465b5df3c35f987dc6e081c4d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.