From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 1/2] xfs: add missing early termination checks to record scrubbing functions
Date: Wed, 6 Nov 2019 15:43:53 +0100 [thread overview]
Message-ID: <20191106144353.GA17196@lst.de> (raw)
In-Reply-To: <157301538007.678524.17905821115324746213.stgit@magnolia>
On Tue, Nov 05, 2019 at 08:43:00PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Scrubbing directories, quotas, and fs counters all involve iterating
> some collection of metadata items. The per-item scrub functions for
> these three are missing some of the components they need to be able to
> check for a fatal signal and terminate early.
>
> Per-item scrub functions need to call xchk_should_terminate to look for
> fatal signals, and they need to check the scrub context's corruption
> flag because there's no point in continuing a scan once we've decided
> the data structure is bad. Add both of these where missing.
Looks sensible, but take this with a grain of salt as I'm not very
familiar with the scrub code:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-11-06 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 4:42 [PATCH 0/2] xfs: fix scrub timeout warnings Darrick J. Wong
2019-11-06 4:43 ` [PATCH 1/2] xfs: add missing early termination checks to record scrubbing functions Darrick J. Wong
2019-11-06 14:43 ` Christoph Hellwig [this message]
2019-11-06 4:43 ` [PATCH 2/2] xfs: periodically yield scrub threads to the scheduler Darrick J. Wong
2019-11-06 14:44 ` Christoph Hellwig
2019-11-06 16:13 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106144353.GA17196@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.