From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04C00C5DF63 for ; Wed, 6 Nov 2019 19:58:26 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B16912075C for ; Wed, 6 Nov 2019 19:58:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B16912075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 477clz00B0zF3Kq for ; Thu, 7 Nov 2019 06:58:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=sean.j.christopherson@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 477Wgh6fkhzF3Ys for ; Thu, 7 Nov 2019 03:09:18 +1100 (AEDT) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 08:09:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,275,1569308400"; d="scan'208";a="200752952" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga008.fm.intel.com with ESMTP; 06 Nov 2019 08:09:13 -0800 Date: Wed, 6 Nov 2019 08:09:13 -0800 From: Sean Christopherson To: David Hildenbrand Subject: Re: [PATCH v1 03/10] KVM: Prepare kvm_is_reserved_pfn() for PG_reserved changes Message-ID: <20191106160913.GD16249@linux.intel.com> References: <613f3606-748b-0e56-a3ad-1efaffa1a67b@redhat.com> <20191105160000.GC8128@linux.intel.com> <20191105231316.GE23297@linux.intel.com> <20191106000315.GI23297@linux.intel.com> <694202e7-d8e6-6ac8-6e47-3553b298bbcc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <694202e7-d8e6-6ac8-6e47-3553b298bbcc@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Mailman-Approved-At: Thu, 07 Nov 2019 06:55:50 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Michal Hocko , Radim =?utf-8?B?S3LEjW3DocWZ?= , KVM list , Pavel Tatashin , KarimAllah Ahmed , Dave Hansen , Alexander Duyck , Michal Hocko , Linux MM , Paul Mackerras , "H. Peter Anvin" , Wanpeng Li , Alexander Duyck , "K. Y. Srinivasan" , Boris Ostrovsky , Kees Cook , devel@driverdev.osuosl.org, Stefano Stabellini , Stephen Hemminger , "Aneesh Kumar K.V" , Joerg Roedel , X86 ML , YueHaibing , "Matthew Wilcox \(Oracle\)" , Mike Rapoport , Peter Zijlstra , Ingo Molnar , Vlastimil Babka , Anthony Yznaga , Oscar Salvador , "Isaac J. Manjarres" , Matt Sickler , Juergen Gross , Anshuman Khandual , Haiyang Zhang , Sasha Levin , kvm-ppc@vger.kernel.org, Qian Cai , Alex Williamson , Mike Rapoport , Borislav Petkov , Nicholas Piggin , Andy Lutomirski , xen-devel , Dan Williams , Vitaly Kuznetsov , Allison Randal , Jim Mattson , Mel Gorman , Adam Borowski , Cornelia Huck , Pavel Tatashin , Linux Kernel Mailing List , Thomas Gleixner , Johannes Weiner , Paolo Bonzini , Andrew Morton , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Nov 06, 2019 at 07:56:34AM +0100, David Hildenbrand wrote: > On 06.11.19 01:08, Dan Williams wrote: > >On Tue, Nov 5, 2019 at 4:03 PM Sean Christopherson > >>But David's proposed fix for the above refcount bug is to omit the patch > >>so that KVM no longer treats ZONE_DEVICE pages as reserved. That seems > >>like the right thing to do, including for thp_adjust(), e.g. it would > >>naturally let KVM use 2mb pages for the guest when a ZONE_DEVICE page is > >>mapped with a huge page (2mb or above) in the host. The only hiccup is > >>figuring out how to correctly transfer the reference. > > > >That might not be the only hiccup. There's currently no such thing as > >huge pages for ZONE_DEVICE, there are huge *mappings* (pmd and pud), > >but the result of pfn_to_page() on such a mapping does not yield a > >huge 'struct page'. It seems there are other paths in KVM that assume > >that more typical page machinery is active like SetPageDirty() based > >on kvm_is_reserved_pfn(). While I told David that I did not want to > >see more usage of is_zone_device_page(), this patch below (untested) > >seems a cleaner path with less surprises: > > > >diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > >index 4df0aa6b8e5c..fbea17c1810c 100644 > >--- a/virt/kvm/kvm_main.c > >+++ b/virt/kvm/kvm_main.c > >@@ -1831,7 +1831,8 @@ EXPORT_SYMBOL_GPL(kvm_release_page_clean); > > > > void kvm_release_pfn_clean(kvm_pfn_t pfn) > > { > >- if (!is_error_noslot_pfn(pfn) && !kvm_is_reserved_pfn(pfn)) > >+ if ((!is_error_noslot_pfn(pfn) && !kvm_is_reserved_pfn(pfn)) || The is_error_noslot_pfn() check shouldn't be overriden by zone_device. > >+ (pfn_valid(pfn) && is_zone_device_page(pfn_to_page(pfn)))) But rather than special case kvm_release_pfn_clean(), I'd rather KVM explicitly handle ZONE_DEVICE pages, there are other flows where KVM really should be aware of ZONE_DEVICE pages, e.g. for sanity checks and whatnot. There are surprisingly few callers of kvm_is_reserved_pfn(), so it's actually not too big of a change. > > put_page(pfn_to_page(pfn)); > > } > > EXPORT_SYMBOL_GPL(kvm_release_pfn_clean); > > I had the same thought, but I do wonder about the kvm_get_pfn() users, > e.g.,: > > hva_to_pfn_remapped(): > r = follow_pfn(vma, addr, &pfn); > ... > kvm_get_pfn(pfn); > ... > > We would not take a reference for ZONE_DEVICE, but later drop one reference > via kvm_release_pfn_clean(). IOW, kvm_get_pfn() gets *really* dangerous to > use. I can't tell if this can happen right now. > > We do have 3 users of kvm_get_pfn() that we have to audit before this > change. Also, we should add a comment to kvm_get_pfn() that it should never > be used with possible ZONE_DEVICE pages. > > Also, we should add a comment to kvm_release_pfn_clean(), describing why we > treat ZONE_DEVICE in a special way here. > > > We can then progress like this > > 1. Get this fix upstream, it's somewhat unrelated to this series. > 2. This patch here remains as is in this series (+/- documentation update) > 3. Long term, rework KVM to not have to not treat ZONE_DEVICE like reserved > pages. E.g., get rid of kvm_get_pfn(). Then, this special zone check can go. Dropping kvm_get_pfn() is less than ideal, and at this point unnecessary. I'm 99% sure the existing call sites for kvm_get_pfn() can never be reached with ZONE_DEVICE pages. I think we can do: 1. Get a fix upstream to have KVM stop treating ZONE_DEVICE pages as reserved PFNs, i.e. exempt them in kvm_is_reserved_pfn() and change the callers of kvm_is_reserved_pfn() to handle ZONE_DEVICE pages. 2. Drop this patch from the series, and instead remove the special treatment of ZONE_DEVICE pages from kvm_is_reserved_pfn(). Give me a few minutes to prep a patch. > > -- > > Thanks, > > David / dhildenb > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 717E0C5DF63 for ; Wed, 6 Nov 2019 16:09:32 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4AE812075C for ; Wed, 6 Nov 2019 16:09:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AE812075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSNrz-0000bX-CQ; Wed, 06 Nov 2019 16:09:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSNry-0000bS-Iz for xen-devel@lists.xenproject.org; Wed, 06 Nov 2019 16:09:18 +0000 X-Inumbo-ID: c81bf292-00af-11ea-a1ae-12813bfff9fa Received: from mga14.intel.com (unknown [192.55.52.115]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c81bf292-00af-11ea-a1ae-12813bfff9fa; Wed, 06 Nov 2019 16:09:17 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 08:09:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,275,1569308400"; d="scan'208";a="200752952" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga008.fm.intel.com with ESMTP; 06 Nov 2019 08:09:13 -0800 Date: Wed, 6 Nov 2019 08:09:13 -0800 From: Sean Christopherson To: David Hildenbrand Message-ID: <20191106160913.GD16249@linux.intel.com> References: <613f3606-748b-0e56-a3ad-1efaffa1a67b@redhat.com> <20191105160000.GC8128@linux.intel.com> <20191105231316.GE23297@linux.intel.com> <20191106000315.GI23297@linux.intel.com> <694202e7-d8e6-6ac8-6e47-3553b298bbcc@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <694202e7-d8e6-6ac8-6e47-3553b298bbcc@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Xen-devel] [PATCH v1 03/10] KVM: Prepare kvm_is_reserved_pfn() for PG_reserved changes X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Michal Hocko , Radim =?utf-8?B?S3LEjW3DocWZ?= , KVM list , Pavel Tatashin , KarimAllah Ahmed , Benjamin Herrenschmidt , Dave Hansen , Alexander Duyck , Michal Hocko , Paul Mackerras , Linux MM , Paul Mackerras , Michael Ellerman , "H. Peter Anvin" , Wanpeng Li , Alexander Duyck , "K. Y. Srinivasan" , Boris Ostrovsky , Kees Cook , devel@driverdev.osuosl.org, Stefano Stabellini , Stephen Hemminger , "Aneesh Kumar K.V" , Joerg Roedel , X86 ML , YueHaibing , "Matthew Wilcox \(Oracle\)" , Mike Rapoport , Peter Zijlstra , Ingo Molnar , Vlastimil Babka , Anthony Yznaga , Oscar Salvador , "Isaac J. Manjarres" , Matt Sickler , Juergen Gross , Anshuman Khandual , Haiyang Zhang , Sasha Levin , kvm-ppc@vger.kernel.org, Qian Cai , Alex Williamson , Mike Rapoport , Borislav Petkov , Nicholas Piggin , Andy Lutomirski , xen-devel , Dan Williams , Vitaly Kuznetsov , Allison Randal , Jim Mattson , Christophe Leroy , Mel Gorman , Adam Borowski , Cornelia Huck , Pavel Tatashin , Linux Kernel Mailing List , Thomas Gleixner , Johannes Weiner , Paolo Bonzini , Andrew Morton , linuxppc-dev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gV2VkLCBOb3YgMDYsIDIwMTkgYXQgMDc6NTY6MzRBTSArMDEwMCwgRGF2aWQgSGlsZGVuYnJh bmQgd3JvdGU6Cj4gT24gMDYuMTEuMTkgMDE6MDgsIERhbiBXaWxsaWFtcyB3cm90ZToKPiA+T24g VHVlLCBOb3YgNSwgMjAxOSBhdCA0OjAzIFBNIFNlYW4gQ2hyaXN0b3BoZXJzb24KPiA+PkJ1dCBE YXZpZCdzIHByb3Bvc2VkIGZpeCBmb3IgdGhlIGFib3ZlIHJlZmNvdW50IGJ1ZyBpcyB0byBvbWl0 IHRoZSBwYXRjaAo+ID4+c28gdGhhdCBLVk0gbm8gbG9uZ2VyIHRyZWF0cyBaT05FX0RFVklDRSBw YWdlcyBhcyByZXNlcnZlZC4gIFRoYXQgc2VlbXMKPiA+Pmxpa2UgdGhlIHJpZ2h0IHRoaW5nIHRv IGRvLCBpbmNsdWRpbmcgZm9yIHRocF9hZGp1c3QoKSwgZS5nLiBpdCB3b3VsZAo+ID4+bmF0dXJh bGx5IGxldCBLVk0gdXNlIDJtYiBwYWdlcyBmb3IgdGhlIGd1ZXN0IHdoZW4gYSBaT05FX0RFVklD RSBwYWdlIGlzCj4gPj5tYXBwZWQgd2l0aCBhIGh1Z2UgcGFnZSAoMm1iIG9yIGFib3ZlKSBpbiB0 aGUgaG9zdC4gIFRoZSBvbmx5IGhpY2N1cCBpcwo+ID4+ZmlndXJpbmcgb3V0IGhvdyB0byBjb3Jy ZWN0bHkgdHJhbnNmZXIgdGhlIHJlZmVyZW5jZS4KPiA+Cj4gPlRoYXQgbWlnaHQgbm90IGJlIHRo ZSBvbmx5IGhpY2N1cC4gVGhlcmUncyBjdXJyZW50bHkgbm8gc3VjaCB0aGluZyBhcwo+ID5odWdl IHBhZ2VzIGZvciBaT05FX0RFVklDRSwgdGhlcmUgYXJlIGh1Z2UgKm1hcHBpbmdzKiAocG1kIGFu ZCBwdWQpLAo+ID5idXQgdGhlIHJlc3VsdCBvZiBwZm5fdG9fcGFnZSgpIG9uIHN1Y2ggYSBtYXBw aW5nIGRvZXMgbm90IHlpZWxkIGEKPiA+aHVnZSAnc3RydWN0IHBhZ2UnLiBJdCBzZWVtcyB0aGVy ZSBhcmUgb3RoZXIgcGF0aHMgaW4gS1ZNIHRoYXQgYXNzdW1lCj4gPnRoYXQgbW9yZSB0eXBpY2Fs IHBhZ2UgbWFjaGluZXJ5IGlzIGFjdGl2ZSBsaWtlIFNldFBhZ2VEaXJ0eSgpIGJhc2VkCj4gPm9u IGt2bV9pc19yZXNlcnZlZF9wZm4oKS4gV2hpbGUgSSB0b2xkIERhdmlkIHRoYXQgSSBkaWQgbm90 IHdhbnQgdG8KPiA+c2VlIG1vcmUgdXNhZ2Ugb2YgaXNfem9uZV9kZXZpY2VfcGFnZSgpLCB0aGlz IHBhdGNoIGJlbG93ICh1bnRlc3RlZCkKPiA+c2VlbXMgYSBjbGVhbmVyIHBhdGggd2l0aCBsZXNz IHN1cnByaXNlczoKPiA+Cj4gPmRpZmYgLS1naXQgYS92aXJ0L2t2bS9rdm1fbWFpbi5jIGIvdmly dC9rdm0va3ZtX21haW4uYwo+ID5pbmRleCA0ZGYwYWE2YjhlNWMuLmZiZWExN2MxODEwYyAxMDA2 NDQKPiA+LS0tIGEvdmlydC9rdm0va3ZtX21haW4uYwo+ID4rKysgYi92aXJ0L2t2bS9rdm1fbWFp bi5jCj4gPkBAIC0xODMxLDcgKzE4MzEsOCBAQCBFWFBPUlRfU1lNQk9MX0dQTChrdm1fcmVsZWFz ZV9wYWdlX2NsZWFuKTsKPiA+Cj4gPiAgdm9pZCBrdm1fcmVsZWFzZV9wZm5fY2xlYW4oa3ZtX3Bm bl90IHBmbikKPiA+ICB7Cj4gPi0gICAgICAgaWYgKCFpc19lcnJvcl9ub3Nsb3RfcGZuKHBmbikg JiYgIWt2bV9pc19yZXNlcnZlZF9wZm4ocGZuKSkKPiA+KyAgICAgICBpZiAoKCFpc19lcnJvcl9u b3Nsb3RfcGZuKHBmbikgJiYgIWt2bV9pc19yZXNlcnZlZF9wZm4ocGZuKSkgfHwKClRoZSBpc19l cnJvcl9ub3Nsb3RfcGZuKCkgY2hlY2sgc2hvdWxkbid0IGJlIG92ZXJyaWRlbiBieSB6b25lX2Rl dmljZS4KCj4gPisgICAgICAgICAgIChwZm5fdmFsaWQocGZuKSAmJiBpc196b25lX2RldmljZV9w YWdlKHBmbl90b19wYWdlKHBmbikpKSkKCkJ1dCByYXRoZXIgdGhhbiBzcGVjaWFsIGNhc2Uga3Zt X3JlbGVhc2VfcGZuX2NsZWFuKCksIEknZCByYXRoZXIgS1ZNCmV4cGxpY2l0bHkgaGFuZGxlIFpP TkVfREVWSUNFIHBhZ2VzLCB0aGVyZSBhcmUgb3RoZXIgZmxvd3Mgd2hlcmUgS1ZNCnJlYWxseSBz aG91bGQgYmUgYXdhcmUgb2YgWk9ORV9ERVZJQ0UgcGFnZXMsIGUuZy4gZm9yIHNhbml0eSBjaGVj a3MgYW5kCndoYXRub3QuICBUaGVyZSBhcmUgc3VycHJpc2luZ2x5IGZldyBjYWxsZXJzIG9mIGt2 bV9pc19yZXNlcnZlZF9wZm4oKSwgc28KaXQncyBhY3R1YWxseSBub3QgdG9vIGJpZyBvZiBhIGNo YW5nZS4gCgo+ID4gICAgICAgICAgICAgICAgIHB1dF9wYWdlKHBmbl90b19wYWdlKHBmbikpOwo+ ID4gIH0KPiA+ICBFWFBPUlRfU1lNQk9MX0dQTChrdm1fcmVsZWFzZV9wZm5fY2xlYW4pOwo+IAo+ IEkgaGFkIHRoZSBzYW1lIHRob3VnaHQsIGJ1dCBJIGRvIHdvbmRlciBhYm91dCB0aGUga3ZtX2dl dF9wZm4oKSB1c2VycywKPiBlLmcuLDoKPiAKPiBodmFfdG9fcGZuX3JlbWFwcGVkKCk6Cj4gCXIg PSBmb2xsb3dfcGZuKHZtYSwgYWRkciwgJnBmbik7Cj4gCS4uLgo+IAlrdm1fZ2V0X3BmbihwZm4p Owo+IAkuLi4KPiAKPiBXZSB3b3VsZCBub3QgdGFrZSBhIHJlZmVyZW5jZSBmb3IgWk9ORV9ERVZJ Q0UsIGJ1dCBsYXRlciBkcm9wIG9uZSByZWZlcmVuY2UKPiB2aWEga3ZtX3JlbGVhc2VfcGZuX2Ns ZWFuKCkuIElPVywga3ZtX2dldF9wZm4oKSBnZXRzICpyZWFsbHkqIGRhbmdlcm91cyB0bwo+IHVz ZS4gSSBjYW4ndCB0ZWxsIGlmIHRoaXMgY2FuIGhhcHBlbiByaWdodCBub3cuCj4gCj4gV2UgZG8g aGF2ZSAzIHVzZXJzIG9mIGt2bV9nZXRfcGZuKCkgdGhhdCB3ZSBoYXZlIHRvIGF1ZGl0IGJlZm9y ZSB0aGlzCj4gY2hhbmdlLiBBbHNvLCB3ZSBzaG91bGQgYWRkIGEgY29tbWVudCB0byBrdm1fZ2V0 X3BmbigpIHRoYXQgaXQgc2hvdWxkIG5ldmVyCj4gYmUgdXNlZCB3aXRoIHBvc3NpYmxlIFpPTkVf REVWSUNFIHBhZ2VzLgo+IAo+IEFsc28sIHdlIHNob3VsZCBhZGQgYSBjb21tZW50IHRvIGt2bV9y ZWxlYXNlX3Bmbl9jbGVhbigpLCBkZXNjcmliaW5nIHdoeSB3ZQo+IHRyZWF0IFpPTkVfREVWSUNF IGluIGEgc3BlY2lhbCB3YXkgaGVyZS4KPiAKPiAKPiBXZSBjYW4gdGhlbiBwcm9ncmVzcyBsaWtl IHRoaXMKPiAKPiAxLiBHZXQgdGhpcyBmaXggdXBzdHJlYW0sIGl0J3Mgc29tZXdoYXQgdW5yZWxh dGVkIHRvIHRoaXMgc2VyaWVzLgo+IDIuIFRoaXMgcGF0Y2ggaGVyZSByZW1haW5zIGFzIGlzIGlu IHRoaXMgc2VyaWVzICgrLy0gZG9jdW1lbnRhdGlvbiB1cGRhdGUpCj4gMy4gTG9uZyB0ZXJtLCBy ZXdvcmsgS1ZNIHRvIG5vdCBoYXZlIHRvIG5vdCB0cmVhdCBaT05FX0RFVklDRSBsaWtlIHJlc2Vy dmVkCj4gcGFnZXMuIEUuZy4sIGdldCByaWQgb2Yga3ZtX2dldF9wZm4oKS4gVGhlbiwgdGhpcyBz cGVjaWFsIHpvbmUgY2hlY2sgY2FuIGdvLgoKRHJvcHBpbmcga3ZtX2dldF9wZm4oKSBpcyBsZXNz IHRoYW4gaWRlYWwsIGFuZCBhdCB0aGlzIHBvaW50IHVubmVjZXNzYXJ5LgpJJ20gOTklIHN1cmUg dGhlIGV4aXN0aW5nIGNhbGwgc2l0ZXMgZm9yIGt2bV9nZXRfcGZuKCkgY2FuIG5ldmVyIGJlCnJl YWNoZWQgd2l0aCBaT05FX0RFVklDRSBwYWdlcy4gIEkgdGhpbmsgd2UgY2FuIGRvOgoKICAxLiBH ZXQgYSBmaXggdXBzdHJlYW0gdG8gaGF2ZSBLVk0gc3RvcCB0cmVhdGluZyBaT05FX0RFVklDRSBw YWdlcyBhcwogICAgIHJlc2VydmVkIFBGTnMsIGkuZS4gZXhlbXB0IHRoZW0gaW4ga3ZtX2lzX3Jl c2VydmVkX3BmbigpIGFuZCBjaGFuZ2UKICAgICB0aGUgY2FsbGVycyBvZiBrdm1faXNfcmVzZXJ2 ZWRfcGZuKCkgdG8gaGFuZGxlIFpPTkVfREVWSUNFIHBhZ2VzLgogIDIuIERyb3AgdGhpcyBwYXRj aCBmcm9tIHRoZSBzZXJpZXMsIGFuZCBpbnN0ZWFkIHJlbW92ZSB0aGUgc3BlY2lhbAogICAgIHRy ZWF0bWVudCBvZiBaT05FX0RFVklDRSBwYWdlcyBmcm9tIGt2bV9pc19yZXNlcnZlZF9wZm4oKS4K CkdpdmUgbWUgYSBmZXcgbWludXRlcyB0byBwcmVwIGEgcGF0Y2guCgo+IAo+IC0tIAo+IAo+IFRo YW5rcywKPiAKPiBEYXZpZCAvIGRoaWxkZW5iCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBs aXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4v bGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEFC8C5DF63 for ; Wed, 6 Nov 2019 16:09:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6990D2178F for ; Wed, 6 Nov 2019 16:09:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6990D2178F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0BB546B0003; Wed, 6 Nov 2019 11:09:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 045226B0006; Wed, 6 Nov 2019 11:09:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4EB66B0008; Wed, 6 Nov 2019 11:09:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id CD3146B0003 for ; Wed, 6 Nov 2019 11:09:18 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 88B672488 for ; Wed, 6 Nov 2019 16:09:18 +0000 (UTC) X-FDA: 76126337196.12.clock55_51218c1982c25 X-HE-Tag: clock55_51218c1982c25 X-Filterd-Recvd-Size: 8248 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Nov 2019 16:09:17 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 08:09:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,275,1569308400"; d="scan'208";a="200752952" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga008.fm.intel.com with ESMTP; 06 Nov 2019 08:09:13 -0800 Date: Wed, 6 Nov 2019 08:09:13 -0800 From: Sean Christopherson To: David Hildenbrand Cc: Dan Williams , Linux Kernel Mailing List , Linux MM , Michal Hocko , Andrew Morton , kvm-ppc@vger.kernel.org, linuxppc-dev , KVM list , linux-hyperv@vger.kernel.org, devel@driverdev.osuosl.org, xen-devel , X86 ML , Alexander Duyck , Alexander Duyck , Alex Williamson , Allison Randal , Andy Lutomirski , "Aneesh Kumar K.V" , Anshuman Khandual , Anthony Yznaga , Benjamin Herrenschmidt , Borislav Petkov , Boris Ostrovsky , Christophe Leroy , Cornelia Huck , Dave Hansen , Haiyang Zhang , "H. Peter Anvin" , Ingo Molnar , "Isaac J. Manjarres" , Jim Mattson , Joerg Roedel , Johannes Weiner , Juergen Gross , KarimAllah Ahmed , Kees Cook , "K. Y. Srinivasan" , "Matthew Wilcox (Oracle)" , Matt Sickler , Mel Gorman , Michael Ellerman , Michal Hocko , Mike Rapoport , Mike Rapoport , Nicholas Piggin , Oscar Salvador , Paolo Bonzini , Paul Mackerras , Paul Mackerras , Pavel Tatashin , Pavel Tatashin , Peter Zijlstra , Qian Cai , Radim =?utf-8?B?S3LEjW3DocWZ?= , Sasha Levin , Stefano Stabellini , Stephen Hemminger , Thomas Gleixner , Vitaly Kuznetsov , Vlastimil Babka , Wanpeng Li , YueHaibing , Adam Borowski Subject: Re: [PATCH v1 03/10] KVM: Prepare kvm_is_reserved_pfn() for PG_reserved changes Message-ID: <20191106160913.GD16249@linux.intel.com> References: <613f3606-748b-0e56-a3ad-1efaffa1a67b@redhat.com> <20191105160000.GC8128@linux.intel.com> <20191105231316.GE23297@linux.intel.com> <20191106000315.GI23297@linux.intel.com> <694202e7-d8e6-6ac8-6e47-3553b298bbcc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <694202e7-d8e6-6ac8-6e47-3553b298bbcc@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 06, 2019 at 07:56:34AM +0100, David Hildenbrand wrote: > On 06.11.19 01:08, Dan Williams wrote: > >On Tue, Nov 5, 2019 at 4:03 PM Sean Christopherson > >>But David's proposed fix for the above refcount bug is to omit the patch > >>so that KVM no longer treats ZONE_DEVICE pages as reserved. That seems > >>like the right thing to do, including for thp_adjust(), e.g. it would > >>naturally let KVM use 2mb pages for the guest when a ZONE_DEVICE page is > >>mapped with a huge page (2mb or above) in the host. The only hiccup is > >>figuring out how to correctly transfer the reference. > > > >That might not be the only hiccup. There's currently no such thing as > >huge pages for ZONE_DEVICE, there are huge *mappings* (pmd and pud), > >but the result of pfn_to_page() on such a mapping does not yield a > >huge 'struct page'. It seems there are other paths in KVM that assume > >that more typical page machinery is active like SetPageDirty() based > >on kvm_is_reserved_pfn(). While I told David that I did not want to > >see more usage of is_zone_device_page(), this patch below (untested) > >seems a cleaner path with less surprises: > > > >diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > >index 4df0aa6b8e5c..fbea17c1810c 100644 > >--- a/virt/kvm/kvm_main.c > >+++ b/virt/kvm/kvm_main.c > >@@ -1831,7 +1831,8 @@ EXPORT_SYMBOL_GPL(kvm_release_page_clean); > > > > void kvm_release_pfn_clean(kvm_pfn_t pfn) > > { > >- if (!is_error_noslot_pfn(pfn) && !kvm_is_reserved_pfn(pfn)) > >+ if ((!is_error_noslot_pfn(pfn) && !kvm_is_reserved_pfn(pfn)) || The is_error_noslot_pfn() check shouldn't be overriden by zone_device. > >+ (pfn_valid(pfn) && is_zone_device_page(pfn_to_page(pfn)))) But rather than special case kvm_release_pfn_clean(), I'd rather KVM explicitly handle ZONE_DEVICE pages, there are other flows where KVM really should be aware of ZONE_DEVICE pages, e.g. for sanity checks and whatnot. There are surprisingly few callers of kvm_is_reserved_pfn(), so it's actually not too big of a change. > > put_page(pfn_to_page(pfn)); > > } > > EXPORT_SYMBOL_GPL(kvm_release_pfn_clean); > > I had the same thought, but I do wonder about the kvm_get_pfn() users, > e.g.,: > > hva_to_pfn_remapped(): > r = follow_pfn(vma, addr, &pfn); > ... > kvm_get_pfn(pfn); > ... > > We would not take a reference for ZONE_DEVICE, but later drop one reference > via kvm_release_pfn_clean(). IOW, kvm_get_pfn() gets *really* dangerous to > use. I can't tell if this can happen right now. > > We do have 3 users of kvm_get_pfn() that we have to audit before this > change. Also, we should add a comment to kvm_get_pfn() that it should never > be used with possible ZONE_DEVICE pages. > > Also, we should add a comment to kvm_release_pfn_clean(), describing why we > treat ZONE_DEVICE in a special way here. > > > We can then progress like this > > 1. Get this fix upstream, it's somewhat unrelated to this series. > 2. This patch here remains as is in this series (+/- documentation update) > 3. Long term, rework KVM to not have to not treat ZONE_DEVICE like reserved > pages. E.g., get rid of kvm_get_pfn(). Then, this special zone check can go. Dropping kvm_get_pfn() is less than ideal, and at this point unnecessary. I'm 99% sure the existing call sites for kvm_get_pfn() can never be reached with ZONE_DEVICE pages. I think we can do: 1. Get a fix upstream to have KVM stop treating ZONE_DEVICE pages as reserved PFNs, i.e. exempt them in kvm_is_reserved_pfn() and change the callers of kvm_is_reserved_pfn() to handle ZONE_DEVICE pages. 2. Drop this patch from the series, and instead remove the special treatment of ZONE_DEVICE pages from kvm_is_reserved_pfn(). Give me a few minutes to prep a patch. > > -- > > Thanks, > > David / dhildenb >