From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE269C5DF64 for ; Wed, 6 Nov 2019 17:53:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67B8A217F4 for ; Wed, 6 Nov 2019 17:53:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="H0i959ZT"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="UxGOxDob" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732248AbfKFRxG (ORCPT ); Wed, 6 Nov 2019 12:53:06 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:33636 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbfKFRxG (ORCPT ); Wed, 6 Nov 2019 12:53:06 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 9444760A50; Wed, 6 Nov 2019 17:53:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573062784; bh=FBAsM4UfKbF/1hIsSiGDVdA7NGJpS4niuM43oKzw4ro=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=H0i959ZT7rH3cLBqeSKBNY46+MGS5vFlWMiLHtDbuXT2q2dxl/NvR9G1S4aXsKs0T Tb1hhMW9OnAjN7S16ZS0GB/qttw/5N+ElZQ/E/RisRpnJTxFIk/eQME2EvUDNmh/bi BgHzUadts1k7nkzbyo6ZOG4p8iJDct6loIvuZq18= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6869C6087D; Wed, 6 Nov 2019 17:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573062783; bh=FBAsM4UfKbF/1hIsSiGDVdA7NGJpS4niuM43oKzw4ro=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=UxGOxDobUkVusZ6wyY2xLGZrU0IDCcbaBAdCQqzmKH23lnk/a/s2N+pvxpnxKHEc/ 0Z9ZhJjoZaYb47Sx2zAci364IRCxZXb5a+34qGnroxjlXciZfOBhytnqutOsBu/AxM 5ThkCUOJZYqwH/nbTwlgxDUHjoMAI35tGbLSsNwM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6869C6087D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3 1/2] ipw2x00: Remove redundant variable "rc" From: Kalle Valo In-Reply-To: <1572684922-61805-2-git-send-email-zhongjiang@huawei.com> References: <1572684922-61805-2-git-send-email-zhongjiang@huawei.com> To: zhong jiang Cc: , , , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191106175304.9444760A50@smtp.codeaurora.org> Date: Wed, 6 Nov 2019 17:53:04 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org zhong jiang wrote: > local variable "rc" is not used. It is safe to remove and > There is only one caller of libipw_qos_convert_ac_to_parameters(). > hence make it void > > Signed-off-by: zhong jiang 2 patches applied to wireless-drivers-next.git, thanks. e310813279b7 ipw2x00: Remove redundant variable "rc" ea7ad5f12ca2 iwlegacy: Remove redundant variable "ret" -- https://patchwork.kernel.org/patch/11224069/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches