From: Kalle Valo <kvalo@codeaurora.org>
To: <pkshih@realtek.com>
Cc: <Larry.Finger@lwfinger.net>, <linux-wireless@vger.kernel.org>,
<wahrenst@gmx.net>
Subject: Re: [PATCH] rtlwifi: fix memory leak in rtl92c_set_fw_rsvdpagepkt()
Date: Wed, 6 Nov 2019 17:57:50 +0000 (UTC) [thread overview]
Message-ID: <20191106175750.9CF0F609EF@smtp.codeaurora.org> (raw)
In-Reply-To: <20191105021838.4302-1-pkshih@realtek.com>
<pkshih@realtek.com> wrote:
> From: Ping-Ke Shih <pkshih@realtek.com>
>
> This leak was found by testing the EDIMAX EW-7612 on Raspberry Pi 3B+ with
> Linux 5.4-rc5 (multi_v7_defconfig + rtlwifi + kmemleak) and noticed a
> single memory leak during probe:
>
> unreferenced object 0xec13ee40 (size 176):
> comm "kworker/u8:1", pid 36, jiffies 4294939321 (age 5580.790s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<fc1bbb3e>] __netdev_alloc_skb+0x9c/0x164
> [<863dfa6e>] rtl92c_set_fw_rsvdpagepkt+0x254/0x340 [rtl8192c_common]
> [<9572be0d>] rtl92cu_set_hw_reg+0xf48/0xfa4 [rtl8192cu]
> [<116df4d8>] rtl_op_bss_info_changed+0x234/0x96c [rtlwifi]
> [<8933575f>] ieee80211_bss_info_change_notify+0xb8/0x264 [mac80211]
> [<d4061e86>] ieee80211_assoc_success+0x934/0x1798 [mac80211]
> [<e55adb56>] ieee80211_rx_mgmt_assoc_resp+0x174/0x314 [mac80211]
> [<5974629e>] ieee80211_sta_rx_queued_mgmt+0x3f4/0x7f0 [mac80211]
> [<d91091c6>] ieee80211_iface_work+0x208/0x318 [mac80211]
> [<ac5fcae4>] process_one_work+0x22c/0x564
> [<f5e6d3b6>] worker_thread+0x44/0x5d8
> [<82c7b073>] kthread+0x150/0x154
> [<b43e1b7d>] ret_from_fork+0x14/0x2c
> [<794dff30>] 0x0
>
> It is because 8192cu doesn't implement usb_cmd_send_packet(), and this
> patch just frees the skb within the function to resolve memleak problem
> by now. Since 8192cu doesn't turn on fwctrl_lps that needs to download
> command packet for firmware via the function, applying this patch doesn't
> affect driver behavior.
>
> Reported-by: Stefan Wahren <wahrenst@gmx.net>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
5174f1e41074 rtlwifi: fix memory leak in rtl92c_set_fw_rsvdpagepkt()
--
https://patchwork.kernel.org/patch/11226861/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-11-06 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 2:18 [PATCH] rtlwifi: fix memory leak in rtl92c_set_fw_rsvdpagepkt() pkshih
2019-11-06 17:57 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106175750.9CF0F609EF@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.