From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE90C5DF63 for ; Wed, 6 Nov 2019 19:28:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95D432178F for ; Wed, 6 Nov 2019 19:28:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GNIQ1oUS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95D432178F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSQyK-00063a-PV for qemu-devel@archiver.kernel.org; Wed, 06 Nov 2019 14:28:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37642) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSQxJ-00059K-WA for qemu-devel@nongnu.org; Wed, 06 Nov 2019 14:27:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSQxI-0000c8-Ty for qemu-devel@nongnu.org; Wed, 06 Nov 2019 14:27:01 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:22321 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSQxI-0000ag-QZ for qemu-devel@nongnu.org; Wed, 06 Nov 2019 14:27:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573068420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QOJhvFV+r+anl1+P2CDEK4qBz8jrrqN6LLUfoFpvE5Q=; b=GNIQ1oUS5hoYvr+qbk/tFZlOVX0IsVNEm7FXvnScy0pZQKdge0AlBOCcB1PnaHImJfyAlG fCgcHSDgDdxLxd+rEDJ2j+7E8rnSJyjx4TpyiGSa/v9tAEweiHB5X/W/D4I7VTcocytlG+ 1mLZ/RCR5VLyLvdOD/J++p2DB3uVxP0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-181-XVBbQ-FtNYeCzp9ZWlyyqQ-1; Wed, 06 Nov 2019 14:26:57 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F0EE4800C72; Wed, 6 Nov 2019 19:26:55 +0000 (UTC) Received: from localhost (ovpn-116-57.gru2.redhat.com [10.97.116.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7B8AD5D9D6; Wed, 6 Nov 2019 19:26:42 +0000 (UTC) Date: Wed, 6 Nov 2019 16:26:41 -0300 From: Eduardo Habkost To: Max Reitz Subject: Re: [PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk machine type settings Message-ID: <20191106192641.GP3812@habkost.net> References: <20191105161105.19016-1-dplotnikov@virtuozzo.com> <20191105161105.19016-5-dplotnikov@virtuozzo.com> <20191106092412.GH189998@stefanha-x1.localdomain> <909f6a98-a750-db34-de23-6c9d89f9f19e@redhat.com> MIME-Version: 1.0 In-Reply-To: <909f6a98-a750-db34-de23-6c9d89f9f19e@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: XVBbQ-FtNYeCzp9ZWlyyqQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, qemu-block@nongnu.org, mst@redhat.com, qemu-devel@nongnu.org, Denis Plotnikov , Stefan Hajnoczi , Cleber Rosa , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , den@virtuozzo.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Nov 06, 2019 at 11:04:16AM +0100, Max Reitz wrote: > On 06.11.19 10:24, Stefan Hajnoczi wrote: > > On Tue, Nov 05, 2019 at 07:11:05PM +0300, Denis Plotnikov wrote: > >> It tests proper queue size settings for all available machine types. > >> > >> Signed-off-by: Denis Plotnikov > >> --- > >> tests/qemu-iotests/267 | 154 ++++++++++++++++++++++++++++++++++++= + > >> tests/qemu-iotests/267.out | 1 + > >> tests/qemu-iotests/group | 1 + > >> 3 files changed, 156 insertions(+) > >> create mode 100755 tests/qemu-iotests/267 > >> create mode 100644 tests/qemu-iotests/267.out > >=20 > > The qemu-iotests maintainers might prefer for this to be at the > > top-level in tests/ since it's not really an iotest, but the code itsel= f > > looks fine to me: > >=20 > > Reviewed-by: Stefan Hajnoczi >=20 > Good question. I don=E2=80=99t really mind, but it would be weird if sta= rted > adding all kinds of =E2=80=9Cexternal=E2=80=9D qemu tests (i.e. that use = QMP) in the > iotests directory. >=20 > What is the alternative? Just putting it in a different directory > doesn=E2=80=99t sound that appealing to me either, because it would still= depend > on the iotests infrastructure, right? (i.e., iotests.py and check) We do have tests/acceptance for simple test cases written in Python. What's the reason for this test case to depend on the iotests infrastructure? --=20 Eduardo