From: Adrian Bunk <bunk@stusta.de>
To: Alistair Francis <alistair.francis@wdc.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] tune-riscv: Add support for hard and soft float
Date: Thu, 7 Nov 2019 00:12:50 +0200 [thread overview]
Message-ID: <20191106221250.GD14721@localhost> (raw)
In-Reply-To: <20191106181819.12517-1-alistair.francis@wdc.com>
On Wed, Nov 06, 2019 at 10:18:18AM -0800, Alistair Francis wrote:
>...
> +TUNE_CCARGS_riscv64 .= "${@bb.utils.contains('TUNE_FEATURES', 'riscv64-f', ' -mabi=lp64d', ' -mabi=lp64', d)}"
> +TUNE_CCARGS_riscv32 .= "${@bb.utils.contains('TUNE_FEATURES', 'riscv32-f', ' -mabi=ilp32f', ' -mabi=ilp32', d)}"
>...
That looks wrong, what would you put in TUNE_FEATURES
for -mabi=lp64f when -mabi=lp64d is called riscv64-f?
Also note that this is only the floating point calling convention,
whether the compiler emits floating point instructions is defined
by -march.
It would be good if this would start with a plan how to handle
all possible combination of RISC-V ISA extensions, ideally better
than the arm mess.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2019-11-06 22:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 18:18 [PATCH 1/2] tune-riscv: Add support for hard and soft float Alistair Francis
2019-11-06 18:18 ` [PATCH 2/2] arch-riscv: Default to hard float for riscv64 Alistair Francis
2019-11-06 20:54 ` [PATCH 1/2] tune-riscv: Add support for hard and soft float Khem Raj
2019-11-06 21:34 ` Alistair Francis
2019-11-06 21:49 ` Khem Raj
2019-11-06 21:52 ` Alistair Francis
2019-11-06 22:18 ` Khem Raj
2019-11-06 22:41 ` Alistair Francis
2019-11-06 22:12 ` Adrian Bunk [this message]
2019-11-06 22:43 ` Alistair Francis
2019-11-07 0:55 ` Khem Raj
2019-11-07 9:30 ` Adrian Bunk
2019-11-07 5:37 ` Nathan Rossi
2019-11-08 0:39 ` Alistair Francis
2019-11-08 20:24 ` Adrian Bunk
2019-11-08 23:07 ` Richard Purdie
2019-11-08 23:14 ` Alistair Francis
2019-11-12 0:21 ` Alistair Francis
2019-11-09 20:30 ` Adrian Bunk
2019-11-09 22:05 ` Richard Purdie
2019-11-10 16:08 ` Adrian Bunk
2019-11-13 8:48 ` Andre McCurdy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106221250.GD14721@localhost \
--to=bunk@stusta.de \
--cc=alistair.francis@wdc.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.