From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: qiming.yang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] net/ice/base: fix wrong ptype bitmap for GRE
Date: Thu, 7 Nov 2019 11:15:48 +0800 [thread overview]
Message-ID: <20191107031548.GD68021@intel.com> (raw)
In-Reply-To: <20191106060703.15963-1-qi.z.zhang@intel.com>
On 11/06, Qi Zhang wrote:
>The ptype bitmap calculation for GRE packet is modified by misktake due to
>commit fc845a9d78ce
>("net/ice/base: fix ptype mapping pollution from GTP flow")
>which is target for GTP packet. The patch rollback that part of code.
>
>Fixes: fc845a9d78ce ("net/ice/base: fix ptype mapping pollution from GTP flow")
>
>Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>---
>v3:
>- fix commit log format.
>v2:
>- fix coding style issue
>
> drivers/net/ice/base/ice_flow.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
>index d6e0556e7..eaa7a3b96 100644
>--- a/drivers/net/ice/base/ice_flow.c
>+++ b/drivers/net/ice/base/ice_flow.c
>@@ -573,9 +573,11 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params)
> ice_and_bitmap(params->ptypes, params->ptypes, src,
> ICE_FLOW_PTYPE_MAX);
> } else if (hdrs & ICE_FLOW_SEG_HDR_GRE) {
>- src = (const ice_bitmap_t *)ice_ptypes_gre_of;
>- ice_and_bitmap(params->ptypes, params->ptypes,
>- src, ICE_FLOW_PTYPE_MAX);
>+ if (!i) {
>+ src = (const ice_bitmap_t *)ice_ptypes_gre_of;
>+ ice_and_bitmap(params->ptypes, params->ptypes,
>+ src, ICE_FLOW_PTYPE_MAX);
>+ }
> } else if (hdrs & ICE_FLOW_SEG_HDR_GTPC) {
> src = (const ice_bitmap_t *)ice_ptypes_gtpc;
> ice_and_bitmap(params->ptypes, params->ptypes,
>--
>2.13.6
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel with some typo fixes. Thanks.
next prev parent reply other threads:[~2019-11-07 3:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 6:07 [dpdk-dev] [PATCH v3] net/ice/base: fix wrong ptype bitmap for GRE Qi Zhang
2019-11-06 15:58 ` Stillwell Jr, Paul M
2019-11-07 3:15 ` Ye Xiaolong [this message]
2019-11-07 14:38 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107031548.GD68021@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.