From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tiwei Bie Subject: Re: [PATCH v5] vhost: introduce mdev based hardware backend Date: Thu, 7 Nov 2019 13:25:54 +0800 Message-ID: <20191107052554.GA27721@___> References: <20191105115332.11026-1-tiwei.bie@intel.com> <20191106075733-mutt-send-email-mst@kernel.org> <20191106143907.GA10776@___> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jason Wang Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, zhihong.wang@intel.com, maxime.coquelin@redhat.com, lingshan.zhu@intel.com List-Id: virtualization@lists.linuxfoundation.org T24gVGh1LCBOb3YgMDcsIDIwMTkgYXQgMTI6MTY6MDFQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiBPbiAyMDE5LzExLzYg5LiL5Y2IMTA6MzksIFRpd2VpIEJpZSB3cm90ZToKPiA+IE9uIFdl ZCwgTm92IDA2LCAyMDE5IGF0IDA3OjU5OjAyQU0gLTA1MDAsIE1pY2hhZWwgUy4gVHNpcmtpbiB3 cm90ZToKPiA+ID4gT24gVHVlLCBOb3YgMDUsIDIwMTkgYXQgMDc6NTM6MzJQTSArMDgwMCwgVGl3 ZWkgQmllIHdyb3RlOgo+ID4gPiA+IFRoaXMgcGF0Y2ggaW50cm9kdWNlcyBhIG1kZXYgYmFzZWQg aGFyZHdhcmUgdmhvc3QgYmFja2VuZC4KPiA+ID4gPiBUaGlzIGJhY2tlbmQgaXMgYnVpbHQgb24g dG9wIG9mIHRoZSBzYW1lIGFic3RyYWN0aW9uIHVzZWQKPiA+ID4gPiBpbiB2aXJ0aW8tbWRldiBh bmQgcHJvdmlkZXMgYSBnZW5lcmljIHZob3N0IGludGVyZmFjZSBmb3IKPiA+ID4gPiB1c2Vyc3Bh Y2UgdG8gYWNjZWxlcmF0ZSB0aGUgdmlydGlvIGRldmljZXMgaW4gZ3Vlc3QuCj4gPiA+ID4gCj4g PiA+ID4gVGhpcyBiYWNrZW5kIGlzIGltcGxlbWVudGVkIGFzIGEgbWRldiBkZXZpY2UgZHJpdmVy IG9uIHRvcAo+ID4gPiA+IG9mIHRoZSBzYW1lIG1kZXYgZGV2aWNlIG9wcyB1c2VkIGluIHZpcnRp by1tZGV2IGJ1dCB1c2luZwo+ID4gPiA+IGEgZGlmZmVyZW50IG1kZXYgY2xhc3MgaWQsIGFuZCBp dCB3aWxsIHJlZ2lzdGVyIHRoZSBkZXZpY2UKPiA+ID4gPiBhcyBhIFZGSU8gZGV2aWNlIGZvciB1 c2Vyc3BhY2UgdG8gdXNlLiBVc2Vyc3BhY2UgY2FuIHNldHVwCj4gPiA+ID4gdGhlIElPTU1VIHdp dGggdGhlIGV4aXN0aW5nIFZGSU8gY29udGFpbmVyL2dyb3VwIEFQSXMgYW5kCj4gPiA+ID4gdGhl biBnZXQgdGhlIGRldmljZSBmZCB3aXRoIHRoZSBkZXZpY2UgbmFtZS4gQWZ0ZXIgZ2V0dGluZwo+ ID4gPiA+IHRoZSBkZXZpY2UgZmQsIHVzZXJzcGFjZSBjYW4gdXNlIHZob3N0IGlvY3RscyBvbiB0 b3Agb2YgaXQKPiA+ID4gPiB0byBzZXR1cCB0aGUgYmFja2VuZC4KPiA+ID4gPiAKPiA+ID4gPiBT aWduZWQtb2ZmLWJ5OiBUaXdlaSBCaWUgPHRpd2VpLmJpZUBpbnRlbC5jb20+Cj4gPiA+IFNvIGF0 IHRoaXMgcG9pbnQsIGxvb2tzIGxpa2UgdGhlIG9ubHkgdGhpbmcgbWlzc2luZyBpcyBJRkMsIGFu ZCB0aGVuIGFsbAo+ID4gPiB0aGVzZSBwYXRjaGVzIGNhbiBnbyBpbi4KPiA+ID4gQnV0IGFzIElG QyBpcyBzdGlsbCBiZWluZyB3b3JrZWQgb24gYW55d2F5LCBpdCBtYWtlcyBzZW5zZSB0bwo+ID4g PiBhZGRyZXNzIHRoZSBtaW5vciBjb21tZW50cyBtYW53aGlsZSBzbyB3ZSBkb24ndCBuZWVkCj4g PiA+IHBhdGNoZXMgb24gdG9wLgo+ID4gPiBSaWdodD8KPiA+IFllYWgsIG9mIGNvdXJzZS4KPiA+ IAo+ID4gVGhhbmtzLAo+ID4gVGl3ZWkKPiAKPiAKPiBQbGVhc2Ugc2VuZCBWNiBhbmQgSSB3aWxs IGFjayB0aGVyZS4KCkdvdCBpdCwgSSB3aWxsIHNlbmQgaXQgc29vbi4KClRoYW5rcyEKVGl3ZWkK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6 YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24u b3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3Zp cnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDEBCC5DF60 for ; Thu, 7 Nov 2019 05:25:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A898121882 for ; Thu, 7 Nov 2019 05:25:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726520AbfKGFZL (ORCPT ); Thu, 7 Nov 2019 00:25:11 -0500 Received: from mga11.intel.com ([192.55.52.93]:30271 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfKGFZK (ORCPT ); Thu, 7 Nov 2019 00:25:10 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 21:25:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="233139016" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by fmsmga002.fm.intel.com with ESMTP; 06 Nov 2019 21:25:08 -0800 Date: Thu, 7 Nov 2019 13:25:54 +0800 From: Tiwei Bie To: Jason Wang Cc: "Michael S. Tsirkin" , alex.williamson@redhat.com, maxime.coquelin@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, dan.daly@intel.com, cunming.liang@intel.com, zhihong.wang@intel.com, lingshan.zhu@intel.com Subject: Re: [PATCH v5] vhost: introduce mdev based hardware backend Message-ID: <20191107052554.GA27721@___> References: <20191105115332.11026-1-tiwei.bie@intel.com> <20191106075733-mutt-send-email-mst@kernel.org> <20191106143907.GA10776@___> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Nov 07, 2019 at 12:16:01PM +0800, Jason Wang wrote: > On 2019/11/6 下午10:39, Tiwei Bie wrote: > > On Wed, Nov 06, 2019 at 07:59:02AM -0500, Michael S. Tsirkin wrote: > > > On Tue, Nov 05, 2019 at 07:53:32PM +0800, Tiwei Bie wrote: > > > > This patch introduces a mdev based hardware vhost backend. > > > > This backend is built on top of the same abstraction used > > > > in virtio-mdev and provides a generic vhost interface for > > > > userspace to accelerate the virtio devices in guest. > > > > > > > > This backend is implemented as a mdev device driver on top > > > > of the same mdev device ops used in virtio-mdev but using > > > > a different mdev class id, and it will register the device > > > > as a VFIO device for userspace to use. Userspace can setup > > > > the IOMMU with the existing VFIO container/group APIs and > > > > then get the device fd with the device name. After getting > > > > the device fd, userspace can use vhost ioctls on top of it > > > > to setup the backend. > > > > > > > > Signed-off-by: Tiwei Bie > > > So at this point, looks like the only thing missing is IFC, and then all > > > these patches can go in. > > > But as IFC is still being worked on anyway, it makes sense to > > > address the minor comments manwhile so we don't need > > > patches on top. > > > Right? > > Yeah, of course. > > > > Thanks, > > Tiwei > > > Please send V6 and I will ack there. Got it, I will send it soon. Thanks! Tiwei