From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Jan Kara <jack@suse.cz>,
linux-block@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH 2/5] block: merge invalidate_partitions into rescan_partitions
Date: Thu, 7 Nov 2019 10:55:54 +0100 [thread overview]
Message-ID: <20191107095554.GA11283@lst.de> (raw)
In-Reply-To: <f95d65cb-f864-5cfe-1161-4f940a59f38e@suse.de>
On Thu, Nov 07, 2019 at 10:47:39AM +0100, Hannes Reinecke wrote:
> > + check_disk_size_change(disk, bdev, !invalidate);
> > bdev->bd_invalidated = 0;
> >
> > - if (!get_capacity(disk))
> > + if (!get_capacity(disk)) {
> > + /*
> > + * Tell userspace that the media / partition table may have
> > + * changed.
> > + */
> > + kobject_uevent(&disk_to_dev(disk)->kobj, KOBJ_CHANGE);
> > return 0;
> > + }
> >
> I wonder; wouldn't we miss a true size change here?
Why would we? We first unconditionally drop all partitions. Then if
the device ha a non-zero capacity we probe for partitions. What could
we miss?
next prev parent reply other threads:[~2019-11-07 9:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 15:14 disk revalidation cleanups and fixlets Christoph Hellwig
2019-11-06 15:14 ` [PATCH 1/5] block: refactor rescan_partitions Christoph Hellwig
2019-11-07 9:39 ` Hannes Reinecke
2019-11-14 13:13 ` Jan Kara
2019-11-06 15:14 ` [PATCH 2/5] block: merge invalidate_partitions into rescan_partitions Christoph Hellwig
2019-11-06 17:24 ` Keith Busch
2019-11-07 9:47 ` Hannes Reinecke
2019-11-07 9:55 ` Christoph Hellwig [this message]
2019-11-14 13:25 ` Jan Kara
2019-11-06 15:14 ` [PATCH 3/5] block: move rescan_partitions to fs/block_dev.c Christoph Hellwig
2019-11-07 9:48 ` Hannes Reinecke
2019-11-14 13:28 ` Jan Kara
2019-11-06 15:14 ` [PATCH 4/5] block: fix bdev_disk_changed for non-partitioned devices Christoph Hellwig
2019-11-14 14:07 ` Jan Kara
2019-11-14 14:31 ` Christoph Hellwig
2019-11-06 15:14 ` [PATCH 5/5] block: remove (__)blkdev_reread_part as an exported API Christoph Hellwig
2019-11-07 13:27 ` Stefan Haberland
2019-11-14 14:24 ` Jan Kara
2019-11-14 14:08 ` disk revalidation cleanups and fixlets Jens Axboe
2019-11-14 14:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107095554.GA11283@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.