From: Johan Hovold <johan@kernel.org>
To: "Pavel Löbl" <pavel@loebl.cz>
Cc: linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] usb: serial: mos7840: Add USB ID to support Moxa UPort 2210
Date: Thu, 7 Nov 2019 14:18:35 +0100 [thread overview]
Message-ID: <20191107131835.GG11035@localhost> (raw)
In-Reply-To: <20191101070150.4216-1-pavel@loebl.cz>
On Fri, Nov 01, 2019 at 08:01:50AM +0100, Pavel Löbl wrote:
> Adds usb ID for MOXA UPort 2210. This device contains mos7820 but
> it passes GPIO0 check implemented by driver and it's detected as
> mos7840. Hence product id check is added to force mos7820 mode.
>
> Signed-off-by: Pavel Löbl <pavel@loebl.cz>
Thanks for the patch.
I've applied this for 5.6 now after adding a vendor id check and
renaming the id defines.
https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=e696d00e65e81d46e911f24b12e441037bf11b38
The device-type detection is indeed fragile, so I've also prepared a
follow-up patch to clean up the device-type handling in order to avoid
adding further id-conditionals throughout the driver.
Johan
next prev parent reply other threads:[~2019-11-07 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 7:01 [PATCH] usb: serial: mos7840: Add USB ID to support Moxa UPort 2210 Pavel Löbl
2019-11-07 13:18 ` Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-30 19:52 Pavel Löbl
2019-10-31 6:48 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107131835.GG11035@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@loebl.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.