From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range
Date: Thu, 7 Nov 2019 19:24:29 -0800 [thread overview]
Message-ID: <20191107192429.2f2609c3@hermes.lan> (raw)
In-Reply-To: <CAJFAV8yUFsYhATKwbf+TGwW9C8n-BoF1O_BN=7sXmsESp0oijA@mail.gmail.com>
On Thu, 7 Nov 2019 21:52:47 +0100
David Marchand <david.marchand@redhat.com> wrote:
> Stephen,
>
> Do we want to fix testpmd?
>
> $ git grep 192.*18 origin/master -- app/test-pmd/
> origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U <<
> 24) | (18 << 16) | (0 << 8) | 1;
> origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr = (192U <<
> 24) | (18 << 16) | (0 << 8) | 2;
>
> Commit bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")
>
Yes, that should be fixed.
Ideally it should use a string instead of hardcoding shifts.
prev parent reply other threads:[~2019-11-08 3:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 16:09 [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range Stephen Hemminger
2019-11-05 16:12 ` Ferruh Yigit
2019-11-05 16:32 ` Stephen Hemminger
2019-11-06 5:36 ` Hemant Agrawal
2019-11-07 20:52 ` David Marchand
2019-11-08 3:24 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107192429.2f2609c3@hermes.lan \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.