Re: Should QEMU's configure script check for bzip2 ?

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Nov 07, 2019 at 08:43:27PM +0100, Thomas Huth wrote:
> 
>  Hi,
> 
> I just tried to compile QEMU on a freshly installed system. "configure"
> finished without problems, but during "make" I hit this error:
> 
>   BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2
> /bin/sh: bzip2: command not found
> make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127
> make: *** Deleting file 'pc-bios/edk2-i386-secure-code.fd'
> make: *** Waiting for unfinished jobs....
> 
> Sure, it's easy to fix, but maybe "configure" should already check for the
> availablity of "bzip2", so that we then either skip the installation of the
> edk2 images if "bzip2" is not available, or bail out during "configure"
> already?

The general rule is that if we run a binary we should check for it upfront
so users immediately see any missing pre-requisites, rather than wasting
30 minutes waiting for QEMU to build & then fail.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|