From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wambui Karuga Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output Date: Fri, 8 Nov 2019 15:46:30 +0300 Message-ID: <20191108124630.GA10207@wambui> References: <20191107092945.15513-1-wambui.karugax@gmail.com> <4c74db2614cefe23f888d0643c2d7c356086745a.camel@perches.com> <20191107133851.GF63329@art_vandelay> Reply-To: 20191107133851.GF63329@art_vandelay Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191107133851.GF63329@art_vandelay> Sender: linux-kernel-owner@vger.kernel.org To: Sean Paul Cc: hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org On Thu, Nov 07, 2019 at 08:38:51AM -0500, Sean Paul wrote: > On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > > DRM helper macro. > > > > The commit message should show the reason _why_ you are doing > > this instead of just stating that you are doing this. > > > > It's not that dev_err is uncommon in drivers/gpu/drm. > > > > It is uncommon (this is the sole instance) in rockchip, however. So it makes > sense to convert the dev_* prints in rockchip to DRM_DEV for consistency. > > Wambui, could you also please convert the dev_warn instance as well? > Hey, Sean. Trying to convert this dev_warn instance, but the corresponding DRM_WARN macro does not take the dev parameter which seems to be useful in the original output. Should I still convert it to DRM_WARN without the hdmi->dev parameter? Thanks, wambui > I'll apply this to drm-misc-next and expand on the commit message a bit. > > Thanks, > > Sean > > > $ git grep -w dev_err drivers/gpu/drm | wc -l > > 1950 > > $ git grep -w DRM_DEV_ERROR drivers/gpu/drm | wc -l > > 756 > > > > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > > [] > > > @@ -916,7 +916,7 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev) > > > } > > > > > > if (!dsi->cdata) { > > > - dev_err(dev, "no dsi-config for %s node\n", np->name); > > > + DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name); > > > return -EINVAL; > > > } > > > > > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69557C43331 for ; Mon, 11 Nov 2019 02:30:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4482F2067B for ; Mon, 11 Nov 2019 02:30:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4482F2067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 74D016E831; Mon, 11 Nov 2019 02:29:47 +0000 (UTC) Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1955E6F976 for ; Fri, 8 Nov 2019 12:46:44 +0000 (UTC) Received: by mail-pf1-x442.google.com with SMTP id p26so4491762pfq.8 for ; Fri, 08 Nov 2019 04:46:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=5rxvla9MqG20qS8PvXLmnssk4K8x/Hmcm3O9O7mRXxw=; b=bHvztflnKiWXDoSD3Ry7L8dEDx2XjadhuB27WKeghYocvAefemZQ/FRscqJYOALia7 WSW/DG1RQSVUuFlOjjHHVdcDSHWyevsvZE1tAZ5cwHqPeUCUGximEvC0PdGYKDQ/cfSE s1aALfK5N3Pv/+mLJUYnFt08YoiZAwGt31UyAzzAaUs4APS6mbf2FXpEO0QMZcWXh9rq Eb73wUZeIMn/DGDK7xxjlZTAAZ7J58o15Eh+cjnjlmhwODz7LhhkWtwdqlSK2HuAZ6fx i7SwEMhoP14ZSOFGfkRy5r2vJSNb0KDDsvtKD9HhqWERmV7e7aK6ikpQLY8PmCE6RdDf xHYQ== X-Gm-Message-State: APjAAAUcL+7WZKYkVsxRaXDX8boE5iPwKSpsX+05N6Qiu2SjdfPf+oNf b7t5qlRrFT8GjU8ql73lQW0= X-Google-Smtp-Source: APXvYqyQ+Qhfryqn9y1yTDk88XHS4CTDkPsbWWZl/mPudP1Bo8G6TeUELgpef4D8uHsAaYCDaB2Pyw== X-Received: by 2002:a17:90a:c004:: with SMTP id p4mr8684007pjt.104.1573217203600; Fri, 08 Nov 2019 04:46:43 -0800 (PST) Received: from wambui ([197.254.95.38]) by smtp.gmail.com with ESMTPSA id n23sm5601302pff.137.2019.11.08.04.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 04:46:42 -0800 (PST) Date: Fri, 8 Nov 2019 15:46:30 +0300 From: Wambui Karuga To: Sean Paul Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output Message-ID: <20191108124630.GA10207@wambui> References: <20191107092945.15513-1-wambui.karugax@gmail.com> <4c74db2614cefe23f888d0643c2d7c356086745a.camel@perches.com> <20191107133851.GF63329@art_vandelay> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191107133851.GF63329@art_vandelay> User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Approved-At: Mon, 11 Nov 2019 02:29:25 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5rxvla9MqG20qS8PvXLmnssk4K8x/Hmcm3O9O7mRXxw=; b=uPGazBXt00dkMb4XcC5rtgD+hXWx7CX3wPcgEwLyc7/uLOfYxE6FYllxMnuz+mWElt TFD5nUaNmEAmii33SlcKmcwRB/VpqoHROLQX9ZyCrtx9I4iBwX8+lYIDPNfhEfijDRba bgcv/EsdA1DP+E5Hrr68Xo4mcflJRzSKf1MMQV10Dg+1kcWGz90yKhlmkk11yAfexpqx 0dL1pT6VkNqhUK5pZzP1sxhyhWIrBVnYdFEDS5ZRUp5L6g4sixLzlXeJSblLGsL8+M+K g9JsPudijfoCeT2BTdTQukwx+LJytsnw6bdwQ/QAf/tWC8Qgm7SY9Efvhhs+ViecTSzM YUFA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: 20191107133851.GF63329@art_vandelay Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191108124630._oGeinmwDMAGYqBlAN7doJ12ZZXC7jbzq7BQgPYJJUo@z> T24gVGh1LCBOb3YgMDcsIDIwMTkgYXQgMDg6Mzg6NTFBTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IE9uIFRodSwgTm92IDA3LCAyMDE5IGF0IDAxOjU0OjIyQU0gLTA4MDAsIEpvZSBQZXJjaGVz IHdyb3RlOgo+ID4gT24gVGh1LCAyMDE5LTExLTA3IGF0IDEyOjI5ICswMzAwLCBXYW1idWkgS2Fy dWdhIHdyb3RlOgo+ID4gPiBSZXBsYWNlIHRoZSB1c2Ugb2YgdGhlIGRldl9lcnIgbWFjcm8gd2l0 aCB0aGUgRFJNX0RFVl9FUlJPUgo+ID4gPiBEUk0gaGVscGVyIG1hY3JvLgo+ID4gCj4gPiBUaGUg Y29tbWl0IG1lc3NhZ2Ugc2hvdWxkIHNob3cgdGhlIHJlYXNvbiBfd2h5XyB5b3UgYXJlIGRvaW5n Cj4gPiB0aGlzIGluc3RlYWQgb2YganVzdCBzdGF0aW5nIHRoYXQgeW91IGFyZSBkb2luZyB0aGlz Lgo+ID4gCj4gPiBJdCdzIG5vdCB0aGF0IGRldl9lcnIgaXMgdW5jb21tb24gaW4gZHJpdmVycy9n cHUvZHJtLgo+ID4gCj4gCj4gSXQgaXMgdW5jb21tb24gKHRoaXMgaXMgdGhlIHNvbGUgaW5zdGFu Y2UpIGluIHJvY2tjaGlwLCBob3dldmVyLiBTbyBpdCBtYWtlcwo+IHNlbnNlIHRvIGNvbnZlcnQg dGhlIGRldl8qIHByaW50cyBpbiByb2NrY2hpcCB0byBEUk1fREVWIGZvciBjb25zaXN0ZW5jeS4K PiAKPiBXYW1idWksIGNvdWxkIHlvdSBhbHNvIHBsZWFzZSBjb252ZXJ0IHRoZSBkZXZfd2FybiBp bnN0YW5jZSBhcyB3ZWxsPwo+IApIZXksIFNlYW4uClRyeWluZyB0byBjb252ZXJ0IHRoaXMgZGV2 X3dhcm4gaW5zdGFuY2UsIGJ1dCB0aGUgY29ycmVzcG9uZGluZyBEUk1fV0FSTgptYWNybyBkb2Vz IG5vdCB0YWtlIHRoZSBkZXYgcGFyYW1ldGVyIHdoaWNoIHNlZW1zIHRvIGJlIHVzZWZ1bCBpbiB0 aGUKb3JpZ2luYWwgb3V0cHV0LgpTaG91bGQgSSBzdGlsbCBjb252ZXJ0IGl0IHRvIERSTV9XQVJO IHdpdGhvdXQgdGhlIGhkbWktPmRldiBwYXJhbWV0ZXI/CgpUaGFua3MsCndhbWJ1aQo+IEknbGwg YXBwbHkgdGhpcyB0byBkcm0tbWlzYy1uZXh0IGFuZCBleHBhbmQgb24gdGhlIGNvbW1pdCBtZXNz YWdlIGEgYml0Lgo+IAo+IFRoYW5rcywKPiAKPiBTZWFuCj4gCj4gPiAkIGdpdCBncmVwIC13IGRl dl9lcnIgZHJpdmVycy9ncHUvZHJtIHwgd2MgLWwKPiA+IDE5NTAKPiA+ICQgZ2l0IGdyZXAgLXcg RFJNX0RFVl9FUlJPUiBkcml2ZXJzL2dwdS9kcm0gfCB3YyAtbAo+ID4gNzU2Cj4gPiAKPiA+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS1yb2NrY2hp cC5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLXJvY2tjaGlwLmMKPiA+ IFtdCj4gPiA+IEBAIC05MTYsNyArOTE2LDcgQEAgc3RhdGljIGludCBkd19taXBpX2RzaV9yb2Nr Y2hpcF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4gPiAgCX0KPiA+ID4g IAo+ID4gPiAgCWlmICghZHNpLT5jZGF0YSkgewo+ID4gPiAtCQlkZXZfZXJyKGRldiwgIm5vIGRz aS1jb25maWcgZm9yICVzIG5vZGVcbiIsIG5wLT5uYW1lKTsKPiA+ID4gKwkJRFJNX0RFVl9FUlJP UihkZXYsICJubyBkc2ktY29uZmlnIGZvciAlcyBub2RlXG4iLCBucC0+bmFtZSk7Cj4gPiA+ICAJ CXJldHVybiAtRUlOVkFMOwo+ID4gPiAgCX0KPiA+IAo+ID4gCj4gPiAKPiA+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0Cj4gPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+IAo+IC0tIAo+ IFNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==