From: Joel Fernandes <joel@joelfernandes.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Nicolas Geoffray <ngeoffray@google.com>,
kernel-team@android.com,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 1/2] memfd: Fix COW issue on MAP_PRIVATE and F_SEAL_FUTURE_WRITE mappings
Date: Fri, 8 Nov 2019 10:35:43 -0500 [thread overview]
Message-ID: <20191108153543.GC99567@google.com> (raw)
In-Reply-To: <20191108063308.GB18778@infradead.org>
On Thu, Nov 07, 2019 at 10:33:08PM -0800, Christoph Hellwig wrote:
> > - * Since the F_SEAL_FUTURE_WRITE seals allow for a MAP_SHARED
> > - * read-only mapping, take care to not allow mprotect to revert
> > - * protections.
> > + * Since an F_SEAL_FUTURE_WRITE sealed memfd can be mapped as
> > + * MAP_SHARED and read-only, take care to not allow mprotect to
> > + * revert protections on such mappings. Do this only for shared
> > + * mappings. For private mappings, don't need to mask VM_MAYWRITE
>
> This adds an > 80 char line.
Oh, true. Sorry. Andrew I hate to ask you but since you took the patch
already, could you just the comment for the character limit in the one
you applied?
thanks,
- Joel
prev parent reply other threads:[~2019-11-08 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 19:53 [PATCH 1/2] memfd: Fix COW issue on MAP_PRIVATE and F_SEAL_FUTURE_WRITE mappings Joel Fernandes (Google)
2019-11-07 19:53 ` [PATCH 2/2] memfd: Add test for COW " Joel Fernandes (Google)
2019-11-08 1:00 ` [PATCH 1/2] memfd: Fix COW issue " Andrew Morton
2019-11-08 2:06 ` Joel Fernandes
2019-11-08 3:25 ` Andrew Morton
2019-11-08 6:37 ` Greg KH
2019-11-08 15:34 ` Joel Fernandes
2019-11-08 6:33 ` Christoph Hellwig
2019-11-08 15:35 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108153543.GC99567@google.com \
--to=joel@joelfernandes.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngeoffray@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.