From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libfribidi: add upstream security fix
Date: Fri, 8 Nov 2019 17:00:29 +0100 [thread overview]
Message-ID: <20191108160030.12803-1-peter@korsgaard.com> (raw)
Fixes the following security issue:
- CVE-2019-18397: GNU FriBidi stack buffer overflow >= 1.0.0
For more details, see the advisory:
https://www.openwall.com/lists/oss-security/2019/11/08/5
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
..._level-to-FRIBIDI_BIDI_MAX_EXPLICIT_.patch | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 package/libfribidi/0001-Truncate-isolate_level-to-FRIBIDI_BIDI_MAX_EXPLICIT_.patch
diff --git a/package/libfribidi/0001-Truncate-isolate_level-to-FRIBIDI_BIDI_MAX_EXPLICIT_.patch b/package/libfribidi/0001-Truncate-isolate_level-to-FRIBIDI_BIDI_MAX_EXPLICIT_.patch
new file mode 100644
index 0000000000..b78f9b2111
--- /dev/null
+++ b/package/libfribidi/0001-Truncate-isolate_level-to-FRIBIDI_BIDI_MAX_EXPLICIT_.patch
@@ -0,0 +1,30 @@
+From 034c6e9a1d296286305f4cfd1e0072b879f52568 Mon Sep 17 00:00:00 2001
+From: Dov Grobgeld <dov.grobgeld@gmail.com>
+Date: Thu, 24 Oct 2019 09:37:29 +0300
+Subject: [PATCH] Truncate isolate_level to FRIBIDI_BIDI_MAX_EXPLICIT_LEVEL
+
+CVE-2019-18397
+
+Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
+---
+ lib/fribidi-bidi.c | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/lib/fribidi-bidi.c b/lib/fribidi-bidi.c
+index 6c84392..d384878 100644
+--- a/lib/fribidi-bidi.c
++++ b/lib/fribidi-bidi.c
+@@ -747,7 +747,9 @@ fribidi_get_par_embedding_levels_ex (
+ }
+
+ RL_LEVEL (pp) = level;
+- RL_ISOLATE_LEVEL (pp) = isolate_level++;
++ RL_ISOLATE_LEVEL (pp) = isolate_level;
++ if (isolate_level < FRIBIDI_BIDI_MAX_EXPLICIT_LEVEL-1)
++ isolate_level++;
+ base_level_per_iso_level[isolate_level] = new_level;
+
+ if (!FRIBIDI_IS_NEUTRAL (override))
+--
+2.20.1
+
--
2.20.1
next reply other threads:[~2019-11-08 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 16:00 Peter Korsgaard [this message]
2019-11-08 20:56 ` [Buildroot] [PATCH] package/libfribidi: add upstream security fix Thomas Petazzoni
2019-11-09 17:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108160030.12803-1-peter@korsgaard.com \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.