From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output Date: Fri, 8 Nov 2019 11:06:02 -0500 Message-ID: <20191108160602.GG63329@art_vandelay> References: <20191107092945.15513-1-wambui.karugax@gmail.com> <20191107133851.GF63329@art_vandelay> <20191108124630.GA10207@wambui> <4996186.DxzAFJqeGu@diego> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <4996186.DxzAFJqeGu@diego> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Wambui Karuga List-Id: linux-rockchip.vger.kernel.org T24gRnJpLCBOb3YgMDgsIDIwMTkgYXQgMDM6MDY6NDRQTSArMDEwMCwgSGVpa28gU3TDvGJuZXIg d3JvdGU6Cj4gSGksCj4gCj4gW2l0IHNlZW1zIHlvdXIgUmVwbHktVG8gbWFpbCBoZWFkZXIgaXMg c2V0IHN0cmFuZ2VseSBhcwo+IFJlcGx5LVRvOiAyMDE5MTEwNzEzMzg1MS5HRjYzMzI5QGFydF92 YW5kZWxheQo+IHdoaWNoIGNvbmZ1c2VzIG15IE1UQV0KPiAKPiBBbSBGcmVpdGFnLCA4LiBOb3Zl bWJlciAyMDE5LCAxMzo0NjozMCBDRVQgc2NocmllYiBXYW1idWkgS2FydWdhOgo+ID4gT24gVGh1 LCBOb3YgMDcsIDIwMTkgYXQgMDg6Mzg6NTFBTSAtMDUwMCwgU2VhbiBQYXVsIHdyb3RlOgo+ID4g PiBPbiBUaHUsIE5vdiAwNywgMjAxOSBhdCAwMTo1NDoyMkFNIC0wODAwLCBKb2UgUGVyY2hlcyB3 cm90ZToKPiA+ID4gPiBPbiBUaHUsIDIwMTktMTEtMDcgYXQgMTI6MjkgKzAzMDAsIFdhbWJ1aSBL YXJ1Z2Egd3JvdGU6Cj4gPiA+ID4gPiBSZXBsYWNlIHRoZSB1c2Ugb2YgdGhlIGRldl9lcnIgbWFj cm8gd2l0aCB0aGUgRFJNX0RFVl9FUlJPUgo+ID4gPiA+ID4gRFJNIGhlbHBlciBtYWNyby4KPiA+ ID4gPiAKPiA+ID4gPiBUaGUgY29tbWl0IG1lc3NhZ2Ugc2hvdWxkIHNob3cgdGhlIHJlYXNvbiBf d2h5XyB5b3UgYXJlIGRvaW5nCj4gPiA+ID4gdGhpcyBpbnN0ZWFkIG9mIGp1c3Qgc3RhdGluZyB0 aGF0IHlvdSBhcmUgZG9pbmcgdGhpcy4KPiA+ID4gPiAKPiA+ID4gPiBJdCdzIG5vdCB0aGF0IGRl dl9lcnIgaXMgdW5jb21tb24gaW4gZHJpdmVycy9ncHUvZHJtLgo+ID4gPiA+IAo+ID4gPiAKPiA+ ID4gSXQgaXMgdW5jb21tb24gKHRoaXMgaXMgdGhlIHNvbGUgaW5zdGFuY2UpIGluIHJvY2tjaGlw LCBob3dldmVyLiBTbyBpdCBtYWtlcwo+ID4gPiBzZW5zZSB0byBjb252ZXJ0IHRoZSBkZXZfKiBw cmludHMgaW4gcm9ja2NoaXAgdG8gRFJNX0RFViBmb3IgY29uc2lzdGVuY3kuCj4gPiA+IAo+ID4g PiBXYW1idWksIGNvdWxkIHlvdSBhbHNvIHBsZWFzZSBjb252ZXJ0IHRoZSBkZXZfd2FybiBpbnN0 YW5jZSBhcyB3ZWxsPwo+ID4gPiAKPiA+IEhleSwgU2Vhbi4KPiA+IFRyeWluZyB0byBjb252ZXJ0 IHRoaXMgZGV2X3dhcm4gaW5zdGFuY2UsIGJ1dCB0aGUgY29ycmVzcG9uZGluZyBEUk1fV0FSTgo+ ID4gbWFjcm8gZG9lcyBub3QgdGFrZSB0aGUgZGV2IHBhcmFtZXRlciB3aGljaCBzZWVtcyB0byBi ZSB1c2VmdWwgaW4gdGhlCj4gPiBvcmlnaW5hbCBvdXRwdXQuCj4gPiBTaG91bGQgSSBzdGlsbCBj b252ZXJ0IGl0IHRvIERSTV9XQVJOIHdpdGhvdXQgdGhlIGhkbWktPmRldiBwYXJhbWV0ZXI/Cj4g Cj4gVGhlcmUgZXhpc3RzIERSTV9ERVZfRVJST1IsIERSTV9ERVZfSU5GTyBhbmQgRFJNX0RFVl9E RUJVRyB0bwo+IGhhbmRsZSBhY3R1YWwgZGV2aWNlcy4gSW50ZXJlc3RpbmdseSB0aGVyZSBpcyBu byBEUk1fREVWX1dBUk4gdGhvdWdoLgo+IAo+IFNvIGRlcGVuZGluZyBvbiB3aGF0IFNlYW4gc3Vn Z2VzdCBhbm90aGVyIG9wdGlvbiB3b3VsZCBiZSB0byBhZGQgdGhlCj4gbWlzc2luZyBEUk1fREVW X1dBUk4gYW5kIHRoZW4gdXNlIGl0IHRvIHJlcGxhY2UgdGhlIGRldl93YXJuLgoKWWVwLCB0aGlz IHNvdW5kcyBnb29kIHRvIG1lIG1lLgoKU2VhbgoKPiAKPiAKPiBIZWlrbwo+IAo+IAo+IAo+ID4g Cj4gPiBUaGFua3MsCj4gPiB3YW1idWkKPiA+ID4gSSdsbCBhcHBseSB0aGlzIHRvIGRybS1taXNj LW5leHQgYW5kIGV4cGFuZCBvbiB0aGUgY29tbWl0IG1lc3NhZ2UgYSBiaXQuCj4gPiA+IAo+ID4g PiBUaGFua3MsCj4gPiA+IAo+ID4gPiBTZWFuCj4gPiA+IAo+ID4gPiA+ICQgZ2l0IGdyZXAgLXcg ZGV2X2VyciBkcml2ZXJzL2dwdS9kcm0gfCB3YyAtbAo+ID4gPiA+IDE5NTAKPiA+ID4gPiAkIGdp dCBncmVwIC13IERSTV9ERVZfRVJST1IgZHJpdmVycy9ncHUvZHJtIHwgd2MgLWwKPiA+ID4gPiA3 NTYKPiA+ID4gPiAKPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvZHctbWlwaS1kc2ktcm9ja2NoaXAuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1t aXBpLWRzaS1yb2NrY2hpcC5jCj4gPiA+ID4gW10KPiA+ID4gPiA+IEBAIC05MTYsNyArOTE2LDcg QEAgc3RhdGljIGludCBkd19taXBpX2RzaV9yb2NrY2hpcF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQo+ID4gPiA+ID4gIAl9Cj4gPiA+ID4gPiAgCj4gPiA+ID4gPiAgCWlmICgh ZHNpLT5jZGF0YSkgewo+ID4gPiA+ID4gLQkJZGV2X2VycihkZXYsICJubyBkc2ktY29uZmlnIGZv ciAlcyBub2RlXG4iLCBucC0+bmFtZSk7Cj4gPiA+ID4gPiArCQlEUk1fREVWX0VSUk9SKGRldiwg Im5vIGRzaS1jb25maWcgZm9yICVzIG5vZGVcbiIsIG5wLT5uYW1lKTsKPiA+ID4gPiA+ICAJCXJl dHVybiAtRUlOVkFMOwo+ID4gPiA+ID4gIAl9Cj4gPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gCj4g PiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ ID4gPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gPiA+ID4gZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+ID4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCj4gPiA+IAo+ID4gCj4gCj4gCj4gCj4gCgotLSAKU2VhbiBQYXVs LCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52958FA372C for ; Fri, 8 Nov 2019 16:06:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17F7A20679 for ; Fri, 8 Nov 2019 16:06:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O1YzyLc4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="P9+KNuvn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17F7A20679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tZVRKrJmur5LIevAEdKaERDoTyYWCIaugKqZ0BbvAeQ=; b=O1YzyLc4a3mqmf xI7dCoXjTUtHBYiSf5p3g8EnZyPxV096edEpgoYMUpLEbzRGuFJ28BMljygG/mnwX3vo9tc7lQhMF +gs3KIusGE8iU4519t3wvgXOMNKEQVSX+Lf1Tg41CfKJQVXLCA62FSxea9G1NezHdp6c3fVU7CbyZ GKoWDLYiJtcE2rEFR4BBgyAZnnW1haOU9pH9j18OCAKSRVcviqXFcqb2wOQOSFfsVDh/IX1MJ/fNd MLtg4CFFj54q+WXBhH5GTkxMDYRLQk9XeqhKAXZsBMuJCU/ICs1WpUAKvqXjjDqtsWwF1kgOAjMqG LCJqXiEJnv1LAGSPQl2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT6m3-0005re-AR; Fri, 08 Nov 2019 16:06:11 +0000 Received: from mail-yb1-xb43.google.com ([2607:f8b0:4864:20::b43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT6ly-0005pr-GI for linux-arm-kernel@lists.infradead.org; Fri, 08 Nov 2019 16:06:08 +0000 Received: by mail-yb1-xb43.google.com with SMTP id g38so2977562ybe.11 for ; Fri, 08 Nov 2019 08:06:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=pp2jWlCqJKLEk+ibjFXlnfbIxOH3q9oKQMy0Ofpc8qE=; b=P9+KNuvnFxtHeZW47U9PU1hLw36tD6FBGxejakql8CpvkHWnHxaE2Hsb7Ult2eNypQ GfJOBVChlOCUTlmcZG1H+puAgs5DttZdWxZliRFToxhKWccMxT/b0VI05a347WPVP9uY k7uIoL08R6YWDSolqaXK0cW9gcfV0NEyYlPI/6raUnB5Wu3yOQDEuVXKPK6QQxDjte/u NVLBdMqcIJgzkTG+cvIjn3mPQZoK1A6pS4Fu3joklD3YiDU64B/sUcyDfbqSe+hzpfk+ gTOUloLnBFdK5+BdO1A3eNjqBPcRGLwipGEtRn6GhK6iCkiDvxjT1gEVcYKAzdmzi6Q1 yoCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=pp2jWlCqJKLEk+ibjFXlnfbIxOH3q9oKQMy0Ofpc8qE=; b=LZwlXOCzjmYftHQhGK4PxFyl1ld4OTiTlGgT16fyYaNceSg7YmvRoRNnVfdwErq9F1 rz04MhGgHMIJKLncpFLJM70hKGj4jABFUKxnfFE192pcjCS6VL9R91KmPmsJGmagGmFK ADmelyr/w1a08u9rT+5ogh8gEkp4ThxdtqtToCEw0orHwGDRFJT/VFlXLPmarwtv4el/ iD30ys8P2nR0yb4UXIp5snuhgeiewOnkAT3/RV2vsHGfOmlbups4+ewmAIOvDArEwV9F YRkfD1QLubAjv1fJ68oTsYeYNadBagwm/Hz1oqnl9L/DG/JltKhCgamAIzsqIwf9qKyh 2uMA== X-Gm-Message-State: APjAAAU3rM2zTrxEE3CE+cApklfnes0KnB59HecdXmsYpDgGnmwHPmeb mZqOR/XeduKkynhOq7aObQrXHw== X-Google-Smtp-Source: APXvYqwHJn8rPwXJPMSPwZbAmzYjmDgS/hvf7KYotndLpNLBWxDPVgII5ANOE6uR/uxdy54DyxixSw== X-Received: by 2002:a25:c64b:: with SMTP id k72mr9417242ybf.4.1573229163819; Fri, 08 Nov 2019 08:06:03 -0800 (PST) Received: from localhost ([2620:0:1013:11:89c6:2139:5435:371d]) by smtp.gmail.com with ESMTPSA id 138sm2987950ywr.46.2019.11.08.08.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 08:06:03 -0800 (PST) Date: Fri, 8 Nov 2019 11:06:02 -0500 From: Sean Paul To: Heiko =?iso-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output Message-ID: <20191108160602.GG63329@art_vandelay> References: <20191107092945.15513-1-wambui.karugax@gmail.com> <20191107133851.GF63329@art_vandelay> <20191108124630.GA10207@wambui> <4996186.DxzAFJqeGu@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4996186.DxzAFJqeGu@diego> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191108_080606_592568_5E27DB68 X-CRM114-Status: GOOD ( 24.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, hjc@rock-chips.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, daniel@ffwll.ch, Sean Paul , linux-arm-kernel@lists.infradead.org, Wambui Karuga Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 08, 2019 at 03:06:44PM +0100, Heiko St=FCbner wrote: > Hi, > = > [it seems your Reply-To mail header is set strangely as > Reply-To: 20191107133851.GF63329@art_vandelay > which confuses my MTA] > = > Am Freitag, 8. November 2019, 13:46:30 CET schrieb Wambui Karuga: > > On Thu, Nov 07, 2019 at 08:38:51AM -0500, Sean Paul wrote: > > > On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > > > > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > > > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > > > > DRM helper macro. > > > > = > > > > The commit message should show the reason _why_ you are doing > > > > this instead of just stating that you are doing this. > > > > = > > > > It's not that dev_err is uncommon in drivers/gpu/drm. > > > > = > > > = > > > It is uncommon (this is the sole instance) in rockchip, however. So i= t makes > > > sense to convert the dev_* prints in rockchip to DRM_DEV for consiste= ncy. > > > = > > > Wambui, could you also please convert the dev_warn instance as well? > > > = > > Hey, Sean. > > Trying to convert this dev_warn instance, but the corresponding DRM_WARN > > macro does not take the dev parameter which seems to be useful in the > > original output. > > Should I still convert it to DRM_WARN without the hdmi->dev parameter? > = > There exists DRM_DEV_ERROR, DRM_DEV_INFO and DRM_DEV_DEBUG to > handle actual devices. Interestingly there is no DRM_DEV_WARN though. > = > So depending on what Sean suggest another option would be to add the > missing DRM_DEV_WARN and then use it to replace the dev_warn. Yep, this sounds good to me me. Sean > = > = > Heiko > = > = > = > > = > > Thanks, > > wambui > > > I'll apply this to drm-misc-next and expand on the commit message a b= it. > > > = > > > Thanks, > > > = > > > Sean > > > = > > > > $ git grep -w dev_err drivers/gpu/drm | wc -l > > > > 1950 > > > > $ git grep -w DRM_DEV_ERROR drivers/gpu/drm | wc -l > > > > 756 > > > > = > > > > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/dr= ivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > > > > [] > > > > > @@ -916,7 +916,7 @@ static int dw_mipi_dsi_rockchip_probe(struct = platform_device *pdev) > > > > > } > > > > > = > > > > > if (!dsi->cdata) { > > > > > - dev_err(dev, "no dsi-config for %s node\n", np->name); > > > > > + DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name); > > > > > return -EINVAL; > > > > > } > > > > = > > > > = > > > > = > > > > _______________________________________________ > > > > dri-devel mailing list > > > > dri-devel@lists.freedesktop.org > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > = > > = > = > = > = > = -- = Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC9FCC5DF60 for ; Fri, 8 Nov 2019 16:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74FD720679 for ; Fri, 8 Nov 2019 16:06:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="P9+KNuvn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727585AbfKHQGF (ORCPT ); Fri, 8 Nov 2019 11:06:05 -0500 Received: from mail-yb1-f196.google.com ([209.85.219.196]:38487 "EHLO mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbfKHQGF (ORCPT ); Fri, 8 Nov 2019 11:06:05 -0500 Received: by mail-yb1-f196.google.com with SMTP id b11so2335437ybj.5 for ; Fri, 08 Nov 2019 08:06:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=pp2jWlCqJKLEk+ibjFXlnfbIxOH3q9oKQMy0Ofpc8qE=; b=P9+KNuvnFxtHeZW47U9PU1hLw36tD6FBGxejakql8CpvkHWnHxaE2Hsb7Ult2eNypQ GfJOBVChlOCUTlmcZG1H+puAgs5DttZdWxZliRFToxhKWccMxT/b0VI05a347WPVP9uY k7uIoL08R6YWDSolqaXK0cW9gcfV0NEyYlPI/6raUnB5Wu3yOQDEuVXKPK6QQxDjte/u NVLBdMqcIJgzkTG+cvIjn3mPQZoK1A6pS4Fu3joklD3YiDU64B/sUcyDfbqSe+hzpfk+ gTOUloLnBFdK5+BdO1A3eNjqBPcRGLwipGEtRn6GhK6iCkiDvxjT1gEVcYKAzdmzi6Q1 yoCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=pp2jWlCqJKLEk+ibjFXlnfbIxOH3q9oKQMy0Ofpc8qE=; b=gAyK+ViZH6u+jA+iaPgpXRPkrC65inR5e5+gL2oHoJ/N6dyHW7IoSoJgweYaoN/2s2 QZqUhHd3p3qJtDygzFRT+Ct1EJNUKo0OVsHNg62x51bJTcO1Dqifpoe6HUF3XUoKbKTi 1c9KmfpX4YT6q78S47Ni/CW5EMP6Qm7oIq2wYFvnf5eLXg7OEYC3QEWIxQUSJ3RmpPKP n68zeNY8YVsmKChSyfAmRiOdXgYy3xxr4gNYCANvoeCZvcUjH6eJVC0ILYJ0PFzUIRBy QzXwkNdWyqkP8zRq+SmmCT377LYl5fALRXSengOPPOqmdeqBWz4UO0kE8N8Vd4mnyjdb FjFg== X-Gm-Message-State: APjAAAVr1lVZ+6Uks7RDGtRDNb/qDugx2WaNaJ6JRpnK39KeMz7Q7VHe 2T4q9/DBxrnnqaGjzyPqzYGJXw== X-Google-Smtp-Source: APXvYqwHJn8rPwXJPMSPwZbAmzYjmDgS/hvf7KYotndLpNLBWxDPVgII5ANOE6uR/uxdy54DyxixSw== X-Received: by 2002:a25:c64b:: with SMTP id k72mr9417242ybf.4.1573229163819; Fri, 08 Nov 2019 08:06:03 -0800 (PST) Received: from localhost ([2620:0:1013:11:89c6:2139:5435:371d]) by smtp.gmail.com with ESMTPSA id 138sm2987950ywr.46.2019.11.08.08.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 08:06:03 -0800 (PST) Date: Fri, 8 Nov 2019 11:06:02 -0500 From: Sean Paul To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Wambui Karuga , Sean Paul , hjc@rock-chips.com, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output Message-ID: <20191108160602.GG63329@art_vandelay> References: <20191107092945.15513-1-wambui.karugax@gmail.com> <20191107133851.GF63329@art_vandelay> <20191108124630.GA10207@wambui> <4996186.DxzAFJqeGu@diego> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4996186.DxzAFJqeGu@diego> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 08, 2019 at 03:06:44PM +0100, Heiko Stübner wrote: > Hi, > > [it seems your Reply-To mail header is set strangely as > Reply-To: 20191107133851.GF63329@art_vandelay > which confuses my MTA] > > Am Freitag, 8. November 2019, 13:46:30 CET schrieb Wambui Karuga: > > On Thu, Nov 07, 2019 at 08:38:51AM -0500, Sean Paul wrote: > > > On Thu, Nov 07, 2019 at 01:54:22AM -0800, Joe Perches wrote: > > > > On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > > > > > Replace the use of the dev_err macro with the DRM_DEV_ERROR > > > > > DRM helper macro. > > > > > > > > The commit message should show the reason _why_ you are doing > > > > this instead of just stating that you are doing this. > > > > > > > > It's not that dev_err is uncommon in drivers/gpu/drm. > > > > > > > > > > It is uncommon (this is the sole instance) in rockchip, however. So it makes > > > sense to convert the dev_* prints in rockchip to DRM_DEV for consistency. > > > > > > Wambui, could you also please convert the dev_warn instance as well? > > > > > Hey, Sean. > > Trying to convert this dev_warn instance, but the corresponding DRM_WARN > > macro does not take the dev parameter which seems to be useful in the > > original output. > > Should I still convert it to DRM_WARN without the hdmi->dev parameter? > > There exists DRM_DEV_ERROR, DRM_DEV_INFO and DRM_DEV_DEBUG to > handle actual devices. Interestingly there is no DRM_DEV_WARN though. > > So depending on what Sean suggest another option would be to add the > missing DRM_DEV_WARN and then use it to replace the dev_warn. Yep, this sounds good to me me. Sean > > > Heiko > > > > > > > Thanks, > > wambui > > > I'll apply this to drm-misc-next and expand on the commit message a bit. > > > > > > Thanks, > > > > > > Sean > > > > > > > $ git grep -w dev_err drivers/gpu/drm | wc -l > > > > 1950 > > > > $ git grep -w DRM_DEV_ERROR drivers/gpu/drm | wc -l > > > > 756 > > > > > > > > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c > > > > [] > > > > > @@ -916,7 +916,7 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev) > > > > > } > > > > > > > > > > if (!dsi->cdata) { > > > > > - dev_err(dev, "no dsi-config for %s node\n", np->name); > > > > > + DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name); > > > > > return -EINVAL; > > > > > } > > > > > > > > > > > > > > > > _______________________________________________ > > > > dri-devel mailing list > > > > dri-devel@lists.freedesktop.org > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > > > > > -- Sean Paul, Software Engineer, Google / Chromium OS