From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E97AAC43331 for ; Sat, 9 Nov 2019 12:02:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F36C21924 for ; Sat, 9 Nov 2019 12:02:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gerhold.net header.i=@gerhold.net header.b="CYwDY/It" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbfKIMCM (ORCPT ); Sat, 9 Nov 2019 07:02:12 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.52]:28101 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbfKIMCM (ORCPT ); Sat, 9 Nov 2019 07:02:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1573300928; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=OXuWTUa9HyzI1fpeQhlGNaQc3nmqlPVWS79Yvpaw+rg=; b=CYwDY/ItmdF3eb00ecsNSUjE8uweOtFMzymjBPyyxLRM7mhhxzzZLvWQuxRlqJHk7R YnrvO2+YObFVVCEcgrHS76IcYrObb8vT2aLMb3WNZz7ahnTTlZnXaD5IKADjb/rXVvRT +CXXGTYtI+jMHiZM13aoohdaNvrwcrRqAvMb22NVaH+cSJ5IzGWMUf2N75VuiQAm6LoG nFahe7lQ34C/NYvtDiphUZHenGF5v6OU3A8EL9lI4T4EPWmB6cHeb1MX9AdjhY4RZBkV eP4gYO+07dgY4kFQbPrLS23lzYNVgySbY0QxGmymjKyhOgY/tcP1RNorfr2RVVyc0ZmO jfEQ== X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u266EZF6ORJL0fVgscA=" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 44.29.0 AUTH) with ESMTPSA id e07688vA9C22uwK (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Sat, 9 Nov 2019 13:02:02 +0100 (CET) Date: Sat, 9 Nov 2019 13:01:56 +0100 From: Stephan Gerhold To: Jeffrey Hugo Cc: Jasper Korten , David Airlie , Sean Paul , lkml , "open list:DRM PANEL DRIVERS" , Rob Clark , Daniel Vetter , MSM , freedreno , Hai Li Subject: Re: [Freedreno] [PATCH] drm/msm/dsi: Delay drm_panel_enable() until dsi_mgr_bridge_enable() Message-ID: <20191109120156.GA981@gerhold.net> References: <20191108212840.13586-1-stephan@gerhold.net> <20191108234654.GA997@gerhold.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Nov 08, 2019 at 08:47:08PM -0700, Jeffrey Hugo wrote: > On Fri, Nov 8, 2019 at 4:47 PM Stephan Gerhold wrote: > > > > On Fri, Nov 08, 2019 at 03:12:28PM -0700, Jeffrey Hugo wrote: > > > On Fri, Nov 8, 2019 at 2:29 PM Stephan Gerhold wrote: > > > > > > > > At the moment, the MSM DSI driver calls drm_panel_enable() rather early > > > > from the DSI bridge pre_enable() function. At this point, the encoder > > > > (e.g. MDP5) is not enabled, so we have not started transmitting > > > > video data. > > > > > > > > However, the drm_panel_funcs documentation states that enable() > > > > should be called on the panel *after* video data is being transmitted: > > > > > > > > The .prepare() function is typically called before the display controller > > > > starts to transmit video data. [...] After the display controller has > > > > started transmitting video data, it's safe to call the .enable() function. > > > > This will typically enable the backlight to make the image on screen visible. > > > > > > > > Calling drm_panel_enable() too early causes problems for some panels: > > > > The TFT LCD panel used in the Samsung Galaxy Tab A 9.7 (2015) (APQ8016) > > > > uses the MIPI_DCS_SET_DISPLAY_BRIGHTNESS command to control > > > > backlight/brightness of the screen. The enable sequence is therefore: > > > > > > > > drm_panel_enable() > > > > drm_panel_funcs.enable(): > > > > backlight_enable() > > > > backlight_ops.update_status(): > > > > mipi_dsi_dcs_set_display_brightness(dsi, bl->props.brightness); > > > > > > > > The panel seems to silently ignore the MIPI_DCS_SET_DISPLAY_BRIGHTNESS > > > > command if it is sent too early. This prevents setting the initial brightness, > > > > causing the display to be enabled with minimum brightness instead. > > > > Adding various delays in the panel initialization code does not result > > > > in any difference. > > > > > > > > On the other hand, moving drm_panel_enable() to dsi_mgr_bridge_enable() > > > > fixes the problem, indicating that the panel requires the video stream > > > > to be active before the brightness command is accepted. > > > > > > > > Therefore: Move drm_panel_enable() to dsi_mgr_bridge_enable() to > > > > delay calling it until video data is being transmitted. > > > > > > > > Move drm_panel_disable() to dsi_mgr_bridge_disable() for similar reasons. > > > > (This is not strictly required for the panel affected above...) > > > > > > > > Tested-by: Jasper Korten > > > > Signed-off-by: Stephan Gerhold > > > > --- > > > > Since this is a core change I thought it would be better to send this > > > > early. I believe Jasper still wants to finish some other changes before > > > > submitting the initial device tree for the Samsung Galaxy Tab A 9.7 (2015). ;) > > > > > > > > I also tested it on msm8916-samsung-a5u-eur, its display is working fine > > > > with or without this patch. > > > > > > Nack, please. I was curious so I threw this on the Lenovo Miix 630 > > > laptop. I don't get a display back with this patch. I'll try to > > > figure out why, but currently I can't get into the machine. > > > > Thanks for testing the patch! Let's try to figure that out... > > > > I'm a bit confused, but this might be because I'm not very familiar with > > the MSM8998 laptops. It does not seem to have display in mainline yet, > > so do you have a link to all the patches you are using at the moment? > > The mdp5 support is there. Some of the dependencies have dragged out. > I'd have to make sense of my development tree as to what is relevant. A dump of all the patches (whether still relevant or not) would be helpful too. Actually I was mostly looking for the device tree part to see which components are involved. > > > > Judging from the patches I was able to find, the Lenovo Miix 630 is > > using a DSI to eDP bridge. > > Isn't the panel managed by the bridge driver in that case? > > It uses the TI SN65 bridge. > It is covered by the ti-sn65dsi86 driver I assume? > > > > struct msm_dsi contains: > > /* > > * panel/external_bridge connected to dsi bridge output, only one of the > > * two can be valid at a time > > */ > > struct drm_panel *panel; > > struct drm_bridge *external_bridge; > > > > So if you have "external_bridge" set in your case, "panel" should be NULL. > > I have only moved code that uses msm_dsi->panel, so my patch really > > shouldn't make any difference for you. > > > > Am I confusing something here? > > I don't think panel is null in my case. I need to trace a few things > through to be sure. > ti-sn65dsi86.c contains: static void ti_sn_bridge_enable(struct drm_bridge *bridge) { /* ... */ drm_panel_enable(pdata->panel); } static void ti_sn_bridge_pre_enable(struct drm_bridge *bridge) { /* ... */ drm_panel_prepare(pdata->panel); } So it does indeed manage the panel for you. If msm_dsi->panel is not NULL for you it would mean that your panel is managed by two drivers at the same time. (Also note how it calls drm_panel_enable() in enable() instead of pre_enable(). This is exactly the change my patch does for the case when the panel is managed by the MSM driver...) > Taking a quick look at the datasheet for the bridge, I suspect that > operations are occurring in the enable() phase of the bridge, that > need to occur before video data is transmitted. Based on your > analysis in the commit message, I suspect these operations need to be > moved to pre_enable(). > I'm still confused how my patch makes any difference for you. The enable sequence should be exactly the same as before. > I'm hoping to gather more data this weekend, which will hopefully > identify what we need to do to move this forward without causing > regressions. Looking forward to it, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Gerhold Subject: Re: [PATCH] drm/msm/dsi: Delay drm_panel_enable() until dsi_mgr_bridge_enable() Date: Sat, 9 Nov 2019 13:01:56 +0100 Message-ID: <20191109120156.GA981@gerhold.net> References: <20191108212840.13586-1-stephan@gerhold.net> <20191108234654.GA997@gerhold.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Jeffrey Hugo Cc: Jasper Korten , Hai Li , David Airlie , MSM , lkml , "open list:DRM PANEL DRIVERS" , Rob Clark , Daniel Vetter , freedreno , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBOb3YgMDgsIDIwMTkgYXQgMDg6NDc6MDhQTSAtMDcwMCwgSmVmZnJleSBIdWdvIHdy b3RlOgo+IE9uIEZyaSwgTm92IDgsIDIwMTkgYXQgNDo0NyBQTSBTdGVwaGFuIEdlcmhvbGQgPHN0 ZXBoYW5AZ2VyaG9sZC5uZXQ+IHdyb3RlOgo+ID4KPiA+IE9uIEZyaSwgTm92IDA4LCAyMDE5IGF0 IDAzOjEyOjI4UE0gLTA3MDAsIEplZmZyZXkgSHVnbyB3cm90ZToKPiA+ID4gT24gRnJpLCBOb3Yg OCwgMjAxOSBhdCAyOjI5IFBNIFN0ZXBoYW4gR2VyaG9sZCA8c3RlcGhhbkBnZXJob2xkLm5ldD4g d3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiBBdCB0aGUgbW9tZW50LCB0aGUgTVNNIERTSSBkcml2ZXIg Y2FsbHMgZHJtX3BhbmVsX2VuYWJsZSgpIHJhdGhlciBlYXJseQo+ID4gPiA+IGZyb20gdGhlIERT SSBicmlkZ2UgcHJlX2VuYWJsZSgpIGZ1bmN0aW9uLiBBdCB0aGlzIHBvaW50LCB0aGUgZW5jb2Rl cgo+ID4gPiA+IChlLmcuIE1EUDUpIGlzIG5vdCBlbmFibGVkLCBzbyB3ZSBoYXZlIG5vdCBzdGFy dGVkIHRyYW5zbWl0dGluZwo+ID4gPiA+IHZpZGVvIGRhdGEuCj4gPiA+ID4KPiA+ID4gPiBIb3dl dmVyLCB0aGUgZHJtX3BhbmVsX2Z1bmNzIGRvY3VtZW50YXRpb24gc3RhdGVzIHRoYXQgZW5hYmxl KCkKPiA+ID4gPiBzaG91bGQgYmUgY2FsbGVkIG9uIHRoZSBwYW5lbCAqYWZ0ZXIqIHZpZGVvIGRh dGEgaXMgYmVpbmcgdHJhbnNtaXR0ZWQ6Cj4gPiA+ID4KPiA+ID4gPiAgIFRoZSAucHJlcGFyZSgp IGZ1bmN0aW9uIGlzIHR5cGljYWxseSBjYWxsZWQgYmVmb3JlIHRoZSBkaXNwbGF5IGNvbnRyb2xs ZXIKPiA+ID4gPiAgIHN0YXJ0cyB0byB0cmFuc21pdCB2aWRlbyBkYXRhLiBbLi4uXSBBZnRlciB0 aGUgZGlzcGxheSBjb250cm9sbGVyIGhhcwo+ID4gPiA+ICAgc3RhcnRlZCB0cmFuc21pdHRpbmcg dmlkZW8gZGF0YSwgaXQncyBzYWZlIHRvIGNhbGwgdGhlIC5lbmFibGUoKSBmdW5jdGlvbi4KPiA+ ID4gPiAgIFRoaXMgd2lsbCB0eXBpY2FsbHkgZW5hYmxlIHRoZSBiYWNrbGlnaHQgdG8gbWFrZSB0 aGUgaW1hZ2Ugb24gc2NyZWVuIHZpc2libGUuCj4gPiA+ID4KPiA+ID4gPiBDYWxsaW5nIGRybV9w YW5lbF9lbmFibGUoKSB0b28gZWFybHkgY2F1c2VzIHByb2JsZW1zIGZvciBzb21lIHBhbmVsczoK PiA+ID4gPiBUaGUgVEZUIExDRCBwYW5lbCB1c2VkIGluIHRoZSBTYW1zdW5nIEdhbGF4eSBUYWIg QSA5LjcgKDIwMTUpIChBUFE4MDE2KQo+ID4gPiA+IHVzZXMgdGhlIE1JUElfRENTX1NFVF9ESVNQ TEFZX0JSSUdIVE5FU1MgY29tbWFuZCB0byBjb250cm9sCj4gPiA+ID4gYmFja2xpZ2h0L2JyaWdo dG5lc3Mgb2YgdGhlIHNjcmVlbi4gVGhlIGVuYWJsZSBzZXF1ZW5jZSBpcyB0aGVyZWZvcmU6Cj4g PiA+ID4KPiA+ID4gPiAgIGRybV9wYW5lbF9lbmFibGUoKQo+ID4gPiA+ICAgICBkcm1fcGFuZWxf ZnVuY3MuZW5hYmxlKCk6Cj4gPiA+ID4gICAgICAgYmFja2xpZ2h0X2VuYWJsZSgpCj4gPiA+ID4g ICAgICAgICBiYWNrbGlnaHRfb3BzLnVwZGF0ZV9zdGF0dXMoKToKPiA+ID4gPiAgICAgICAgICAg bWlwaV9kc2lfZGNzX3NldF9kaXNwbGF5X2JyaWdodG5lc3MoZHNpLCBibC0+cHJvcHMuYnJpZ2h0 bmVzcyk7Cj4gPiA+ID4KPiA+ID4gPiBUaGUgcGFuZWwgc2VlbXMgdG8gc2lsZW50bHkgaWdub3Jl IHRoZSBNSVBJX0RDU19TRVRfRElTUExBWV9CUklHSFRORVNTCj4gPiA+ID4gY29tbWFuZCBpZiBp dCBpcyBzZW50IHRvbyBlYXJseS4gVGhpcyBwcmV2ZW50cyBzZXR0aW5nIHRoZSBpbml0aWFsIGJy aWdodG5lc3MsCj4gPiA+ID4gY2F1c2luZyB0aGUgZGlzcGxheSB0byBiZSBlbmFibGVkIHdpdGgg bWluaW11bSBicmlnaHRuZXNzIGluc3RlYWQuCj4gPiA+ID4gQWRkaW5nIHZhcmlvdXMgZGVsYXlz IGluIHRoZSBwYW5lbCBpbml0aWFsaXphdGlvbiBjb2RlIGRvZXMgbm90IHJlc3VsdAo+ID4gPiA+ IGluIGFueSBkaWZmZXJlbmNlLgo+ID4gPiA+Cj4gPiA+ID4gT24gdGhlIG90aGVyIGhhbmQsIG1v dmluZyBkcm1fcGFuZWxfZW5hYmxlKCkgdG8gZHNpX21ncl9icmlkZ2VfZW5hYmxlKCkKPiA+ID4g PiBmaXhlcyB0aGUgcHJvYmxlbSwgaW5kaWNhdGluZyB0aGF0IHRoZSBwYW5lbCByZXF1aXJlcyB0 aGUgdmlkZW8gc3RyZWFtCj4gPiA+ID4gdG8gYmUgYWN0aXZlIGJlZm9yZSB0aGUgYnJpZ2h0bmVz cyBjb21tYW5kIGlzIGFjY2VwdGVkLgo+ID4gPiA+Cj4gPiA+ID4gVGhlcmVmb3JlOiBNb3ZlIGRy bV9wYW5lbF9lbmFibGUoKSB0byBkc2lfbWdyX2JyaWRnZV9lbmFibGUoKSB0bwo+ID4gPiA+IGRl bGF5IGNhbGxpbmcgaXQgdW50aWwgdmlkZW8gZGF0YSBpcyBiZWluZyB0cmFuc21pdHRlZC4KPiA+ ID4gPgo+ID4gPiA+IE1vdmUgZHJtX3BhbmVsX2Rpc2FibGUoKSB0byBkc2lfbWdyX2JyaWRnZV9k aXNhYmxlKCkgZm9yIHNpbWlsYXIgcmVhc29ucy4KPiA+ID4gPiAoVGhpcyBpcyBub3Qgc3RyaWN0 bHkgcmVxdWlyZWQgZm9yIHRoZSBwYW5lbCBhZmZlY3RlZCBhYm92ZS4uLikKPiA+ID4gPgo+ID4g PiA+IFRlc3RlZC1ieTogSmFzcGVyIEtvcnRlbiA8amphMjAwMEBnbWFpbC5jb20+Cj4gPiA+ID4g U2lnbmVkLW9mZi1ieTogU3RlcGhhbiBHZXJob2xkIDxzdGVwaGFuQGdlcmhvbGQubmV0Pgo+ID4g PiA+IC0tLQo+ID4gPiA+IFNpbmNlIHRoaXMgaXMgYSBjb3JlIGNoYW5nZSBJIHRob3VnaHQgaXQg d291bGQgYmUgYmV0dGVyIHRvIHNlbmQgdGhpcwo+ID4gPiA+IGVhcmx5LiBJIGJlbGlldmUgSmFz cGVyIHN0aWxsIHdhbnRzIHRvIGZpbmlzaCBzb21lIG90aGVyIGNoYW5nZXMgYmVmb3JlCj4gPiA+ ID4gc3VibWl0dGluZyB0aGUgaW5pdGlhbCBkZXZpY2UgdHJlZSBmb3IgdGhlIFNhbXN1bmcgR2Fs YXh5IFRhYiBBIDkuNyAoMjAxNSkuIDspCj4gPiA+ID4KPiA+ID4gPiBJIGFsc28gdGVzdGVkIGl0 IG9uIG1zbTg5MTYtc2Ftc3VuZy1hNXUtZXVyLCBpdHMgZGlzcGxheSBpcyB3b3JraW5nIGZpbmUK PiA+ID4gPiB3aXRoIG9yIHdpdGhvdXQgdGhpcyBwYXRjaC4KPiA+ID4KPiA+ID4gTmFjaywgcGxl YXNlLiAgSSB3YXMgY3VyaW91cyBzbyBJIHRocmV3IHRoaXMgb24gdGhlIExlbm92byBNaWl4IDYz MAo+ID4gPiBsYXB0b3AuICBJIGRvbid0IGdldCBhIGRpc3BsYXkgYmFjayB3aXRoIHRoaXMgcGF0 Y2guICBJJ2xsIHRyeSB0bwo+ID4gPiBmaWd1cmUgb3V0IHdoeSwgYnV0IGN1cnJlbnRseSBJIGNh bid0IGdldCBpbnRvIHRoZSBtYWNoaW5lLgo+ID4KPiA+IFRoYW5rcyBmb3IgdGVzdGluZyB0aGUg cGF0Y2ghIExldCdzIHRyeSB0byBmaWd1cmUgdGhhdCBvdXQuLi4KPiA+Cj4gPiBJJ20gYSBiaXQg Y29uZnVzZWQsIGJ1dCB0aGlzIG1pZ2h0IGJlIGJlY2F1c2UgSSdtIG5vdCB2ZXJ5IGZhbWlsaWFy IHdpdGgKPiA+IHRoZSBNU004OTk4IGxhcHRvcHMuIEl0IGRvZXMgbm90IHNlZW0gdG8gaGF2ZSBk aXNwbGF5IGluIG1haW5saW5lIHlldCwKPiA+IHNvIGRvIHlvdSBoYXZlIGEgbGluayB0byBhbGwg dGhlIHBhdGNoZXMgeW91IGFyZSB1c2luZyBhdCB0aGUgbW9tZW50Pwo+IAo+IFRoZSBtZHA1IHN1 cHBvcnQgaXMgdGhlcmUuICBTb21lIG9mIHRoZSBkZXBlbmRlbmNpZXMgaGF2ZSBkcmFnZ2VkIG91 dC4KPiBJJ2QgaGF2ZSB0byBtYWtlIHNlbnNlIG9mIG15IGRldmVsb3BtZW50IHRyZWUgYXMgdG8g d2hhdCBpcyByZWxldmFudC4KCkEgZHVtcCBvZiBhbGwgdGhlIHBhdGNoZXMgKHdoZXRoZXIgc3Rp bGwgcmVsZXZhbnQgb3Igbm90KSB3b3VsZCBiZQpoZWxwZnVsIHRvby4gQWN0dWFsbHkgSSB3YXMg bW9zdGx5IGxvb2tpbmcgZm9yIHRoZSBkZXZpY2UgdHJlZSBwYXJ0IHRvCnNlZSB3aGljaCBjb21w b25lbnRzIGFyZSBpbnZvbHZlZC4KCj4gPgo+ID4gSnVkZ2luZyBmcm9tIHRoZSBwYXRjaGVzIEkg d2FzIGFibGUgdG8gZmluZCwgdGhlIExlbm92byBNaWl4IDYzMCBpcwo+ID4gdXNpbmcgYSBEU0kg dG8gZURQIGJyaWRnZS4KPiA+IElzbid0IHRoZSBwYW5lbCBtYW5hZ2VkIGJ5IHRoZSBicmlkZ2Ug ZHJpdmVyIGluIHRoYXQgY2FzZT8KPiAKPiBJdCB1c2VzIHRoZSBUSSBTTjY1IGJyaWRnZS4KPiAK Ckl0IGlzIGNvdmVyZWQgYnkgdGhlIHRpLXNuNjVkc2k4NiBkcml2ZXIgSSBhc3N1bWU/Cgo+ID4K PiA+IHN0cnVjdCBtc21fZHNpIGNvbnRhaW5zOgo+ID4gICAgICAgICAvKgo+ID4gICAgICAgICAg KiBwYW5lbC9leHRlcm5hbF9icmlkZ2UgY29ubmVjdGVkIHRvIGRzaSBicmlkZ2Ugb3V0cHV0LCBv bmx5IG9uZSBvZiB0aGUKPiA+ICAgICAgICAgICogdHdvIGNhbiBiZSB2YWxpZCBhdCBhIHRpbWUK PiA+ICAgICAgICAgICovCj4gPiAgICAgICAgIHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsOwo+ID4g ICAgICAgICBzdHJ1Y3QgZHJtX2JyaWRnZSAqZXh0ZXJuYWxfYnJpZGdlOwo+ID4KPiA+IFNvIGlm IHlvdSBoYXZlICJleHRlcm5hbF9icmlkZ2UiIHNldCBpbiB5b3VyIGNhc2UsICJwYW5lbCIgc2hv dWxkIGJlIE5VTEwuCj4gPiBJIGhhdmUgb25seSBtb3ZlZCBjb2RlIHRoYXQgdXNlcyBtc21fZHNp LT5wYW5lbCwgc28gbXkgcGF0Y2ggcmVhbGx5Cj4gPiBzaG91bGRuJ3QgbWFrZSBhbnkgZGlmZmVy ZW5jZSBmb3IgeW91Lgo+ID4KPiA+IEFtIEkgY29uZnVzaW5nIHNvbWV0aGluZyBoZXJlPwo+IAo+ IEkgZG9uJ3QgdGhpbmsgcGFuZWwgaXMgbnVsbCBpbiBteSBjYXNlLiAgSSBuZWVkIHRvIHRyYWNl IGEgZmV3IHRoaW5ncwo+IHRocm91Z2ggdG8gYmUgc3VyZS4KPiAKCnRpLXNuNjVkc2k4Ni5jIGNv bnRhaW5zOgoKc3RhdGljIHZvaWQgdGlfc25fYnJpZGdlX2VuYWJsZShzdHJ1Y3QgZHJtX2JyaWRn ZSAqYnJpZGdlKQp7CgkvKiAuLi4gKi8KCWRybV9wYW5lbF9lbmFibGUocGRhdGEtPnBhbmVsKTsK fQoKc3RhdGljIHZvaWQgdGlfc25fYnJpZGdlX3ByZV9lbmFibGUoc3RydWN0IGRybV9icmlkZ2Ug KmJyaWRnZSkKewoJLyogLi4uICovCglkcm1fcGFuZWxfcHJlcGFyZShwZGF0YS0+cGFuZWwpOwp9 CgpTbyBpdCBkb2VzIGluZGVlZCBtYW5hZ2UgdGhlIHBhbmVsIGZvciB5b3UuIElmIG1zbV9kc2kt PnBhbmVsIGlzIG5vdApOVUxMIGZvciB5b3UgaXQgd291bGQgbWVhbiB0aGF0IHlvdXIgcGFuZWwg aXMgbWFuYWdlZCBieSB0d28gZHJpdmVycwphdCB0aGUgc2FtZSB0aW1lLgoKKEFsc28gbm90ZSBo b3cgaXQgY2FsbHMgZHJtX3BhbmVsX2VuYWJsZSgpIGluIGVuYWJsZSgpIGluc3RlYWQgb2YKcHJl X2VuYWJsZSgpLiBUaGlzIGlzIGV4YWN0bHkgdGhlIGNoYW5nZSBteSBwYXRjaCBkb2VzIGZvciB0 aGUgY2FzZQp3aGVuIHRoZSBwYW5lbCBpcyBtYW5hZ2VkIGJ5IHRoZSBNU00gZHJpdmVyLi4uKQoK PiBUYWtpbmcgYSBxdWljayBsb29rIGF0IHRoZSBkYXRhc2hlZXQgZm9yIHRoZSBicmlkZ2UsIEkg c3VzcGVjdCB0aGF0Cj4gb3BlcmF0aW9ucyBhcmUgb2NjdXJyaW5nIGluIHRoZSBlbmFibGUoKSBw aGFzZSBvZiB0aGUgYnJpZGdlLCB0aGF0Cj4gbmVlZCB0byBvY2N1ciBiZWZvcmUgdmlkZW8gZGF0 YSBpcyB0cmFuc21pdHRlZC4gIEJhc2VkIG9uIHlvdXIKPiBhbmFseXNpcyBpbiB0aGUgY29tbWl0 IG1lc3NhZ2UsIEkgc3VzcGVjdCB0aGVzZSBvcGVyYXRpb25zIG5lZWQgdG8gYmUKPiBtb3ZlZCB0 byBwcmVfZW5hYmxlKCkuCj4gCgpJJ20gc3RpbGwgY29uZnVzZWQgaG93IG15IHBhdGNoIG1ha2Vz IGFueSBkaWZmZXJlbmNlIGZvciB5b3UuClRoZSBlbmFibGUgc2VxdWVuY2Ugc2hvdWxkIGJlIGV4 YWN0bHkgdGhlIHNhbWUgYXMgYmVmb3JlLgoKPiBJJ20gaG9waW5nIHRvIGdhdGhlciBtb3JlIGRh dGEgdGhpcyB3ZWVrZW5kLCB3aGljaCB3aWxsIGhvcGVmdWxseQo+IGlkZW50aWZ5IHdoYXQgd2Ug bmVlZCB0byBkbyB0byBtb3ZlIHRoaXMgZm9yd2FyZCB3aXRob3V0IGNhdXNpbmcKPiByZWdyZXNz aW9ucy4KCkxvb2tpbmcgZm9yd2FyZCB0byBpdCwgdGhhbmtzIQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVk cmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA069C43331 for ; Sat, 9 Nov 2019 12:02:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E51921882 for ; Sat, 9 Nov 2019 12:02:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E51921882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gerhold.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B2EDA6E222; Sat, 9 Nov 2019 12:02:09 +0000 (UTC) Received: from mo6-p01-ob.smtp.rzone.de (mo6-p01-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5301::9]) by gabe.freedesktop.org (Postfix) with ESMTPS id C843989ECD; Sat, 9 Nov 2019 12:02:07 +0000 (UTC) X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u266EZF6ORJL0fVgscA=" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 44.29.0 AUTH) with ESMTPSA id e07688vA9C22uwK (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Sat, 9 Nov 2019 13:02:02 +0100 (CET) Date: Sat, 9 Nov 2019 13:01:56 +0100 From: Stephan Gerhold To: Jeffrey Hugo Subject: Re: [Freedreno] [PATCH] drm/msm/dsi: Delay drm_panel_enable() until dsi_mgr_bridge_enable() Message-ID: <20191109120156.GA981@gerhold.net> References: <20191108212840.13586-1-stephan@gerhold.net> <20191108234654.GA997@gerhold.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1573300926; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=OXuWTUa9HyzI1fpeQhlGNaQc3nmqlPVWS79Yvpaw+rg=; b=s61vbeZbAFGcMYTbodQFLCjoebtq/+NtLJu8iuwfAJfu1V/Ij+YEojSuROAPtzak5R 465xAdme2zJ9/NctP22emd9mLsv85RRbcDaZ0APBRllJXS+RxV1r/Fc3joB29s+Rc4wW 8iby0Bq2qPFdIqB9Gup+0cqTRTC79pPwAeAMebMIy2ryqAcy3XOhV3gWWihtaNoWFBWH sZOTMTZiYUh0+847GyYHPIrfKHKBTQXqahqsiEqHQfBMjSa/4oyXEeLhcjRzHpybOecM McknpcK3/KTlrebJ2BCqsJATX2/TVXjwddY7qYaXvnxM5KAZiCMhJOU4IxBJsN1I0JRu ZLYg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jasper Korten , Hai Li , David Airlie , MSM , lkml , "open list:DRM PANEL DRIVERS" , freedreno , Sean Paul Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191109120156.Q4MgkfcD5Y2yG2P0xUm_488dWSo5G1bUKyWfnTAoYy0@z> T24gRnJpLCBOb3YgMDgsIDIwMTkgYXQgMDg6NDc6MDhQTSAtMDcwMCwgSmVmZnJleSBIdWdvIHdy b3RlOgo+IE9uIEZyaSwgTm92IDgsIDIwMTkgYXQgNDo0NyBQTSBTdGVwaGFuIEdlcmhvbGQgPHN0 ZXBoYW5AZ2VyaG9sZC5uZXQ+IHdyb3RlOgo+ID4KPiA+IE9uIEZyaSwgTm92IDA4LCAyMDE5IGF0 IDAzOjEyOjI4UE0gLTA3MDAsIEplZmZyZXkgSHVnbyB3cm90ZToKPiA+ID4gT24gRnJpLCBOb3Yg OCwgMjAxOSBhdCAyOjI5IFBNIFN0ZXBoYW4gR2VyaG9sZCA8c3RlcGhhbkBnZXJob2xkLm5ldD4g d3JvdGU6Cj4gPiA+ID4KPiA+ID4gPiBBdCB0aGUgbW9tZW50LCB0aGUgTVNNIERTSSBkcml2ZXIg Y2FsbHMgZHJtX3BhbmVsX2VuYWJsZSgpIHJhdGhlciBlYXJseQo+ID4gPiA+IGZyb20gdGhlIERT SSBicmlkZ2UgcHJlX2VuYWJsZSgpIGZ1bmN0aW9uLiBBdCB0aGlzIHBvaW50LCB0aGUgZW5jb2Rl cgo+ID4gPiA+IChlLmcuIE1EUDUpIGlzIG5vdCBlbmFibGVkLCBzbyB3ZSBoYXZlIG5vdCBzdGFy dGVkIHRyYW5zbWl0dGluZwo+ID4gPiA+IHZpZGVvIGRhdGEuCj4gPiA+ID4KPiA+ID4gPiBIb3dl dmVyLCB0aGUgZHJtX3BhbmVsX2Z1bmNzIGRvY3VtZW50YXRpb24gc3RhdGVzIHRoYXQgZW5hYmxl KCkKPiA+ID4gPiBzaG91bGQgYmUgY2FsbGVkIG9uIHRoZSBwYW5lbCAqYWZ0ZXIqIHZpZGVvIGRh dGEgaXMgYmVpbmcgdHJhbnNtaXR0ZWQ6Cj4gPiA+ID4KPiA+ID4gPiAgIFRoZSAucHJlcGFyZSgp IGZ1bmN0aW9uIGlzIHR5cGljYWxseSBjYWxsZWQgYmVmb3JlIHRoZSBkaXNwbGF5IGNvbnRyb2xs ZXIKPiA+ID4gPiAgIHN0YXJ0cyB0byB0cmFuc21pdCB2aWRlbyBkYXRhLiBbLi4uXSBBZnRlciB0 aGUgZGlzcGxheSBjb250cm9sbGVyIGhhcwo+ID4gPiA+ICAgc3RhcnRlZCB0cmFuc21pdHRpbmcg dmlkZW8gZGF0YSwgaXQncyBzYWZlIHRvIGNhbGwgdGhlIC5lbmFibGUoKSBmdW5jdGlvbi4KPiA+ ID4gPiAgIFRoaXMgd2lsbCB0eXBpY2FsbHkgZW5hYmxlIHRoZSBiYWNrbGlnaHQgdG8gbWFrZSB0 aGUgaW1hZ2Ugb24gc2NyZWVuIHZpc2libGUuCj4gPiA+ID4KPiA+ID4gPiBDYWxsaW5nIGRybV9w YW5lbF9lbmFibGUoKSB0b28gZWFybHkgY2F1c2VzIHByb2JsZW1zIGZvciBzb21lIHBhbmVsczoK PiA+ID4gPiBUaGUgVEZUIExDRCBwYW5lbCB1c2VkIGluIHRoZSBTYW1zdW5nIEdhbGF4eSBUYWIg QSA5LjcgKDIwMTUpIChBUFE4MDE2KQo+ID4gPiA+IHVzZXMgdGhlIE1JUElfRENTX1NFVF9ESVNQ TEFZX0JSSUdIVE5FU1MgY29tbWFuZCB0byBjb250cm9sCj4gPiA+ID4gYmFja2xpZ2h0L2JyaWdo dG5lc3Mgb2YgdGhlIHNjcmVlbi4gVGhlIGVuYWJsZSBzZXF1ZW5jZSBpcyB0aGVyZWZvcmU6Cj4g PiA+ID4KPiA+ID4gPiAgIGRybV9wYW5lbF9lbmFibGUoKQo+ID4gPiA+ICAgICBkcm1fcGFuZWxf ZnVuY3MuZW5hYmxlKCk6Cj4gPiA+ID4gICAgICAgYmFja2xpZ2h0X2VuYWJsZSgpCj4gPiA+ID4g ICAgICAgICBiYWNrbGlnaHRfb3BzLnVwZGF0ZV9zdGF0dXMoKToKPiA+ID4gPiAgICAgICAgICAg bWlwaV9kc2lfZGNzX3NldF9kaXNwbGF5X2JyaWdodG5lc3MoZHNpLCBibC0+cHJvcHMuYnJpZ2h0 bmVzcyk7Cj4gPiA+ID4KPiA+ID4gPiBUaGUgcGFuZWwgc2VlbXMgdG8gc2lsZW50bHkgaWdub3Jl IHRoZSBNSVBJX0RDU19TRVRfRElTUExBWV9CUklHSFRORVNTCj4gPiA+ID4gY29tbWFuZCBpZiBp dCBpcyBzZW50IHRvbyBlYXJseS4gVGhpcyBwcmV2ZW50cyBzZXR0aW5nIHRoZSBpbml0aWFsIGJy aWdodG5lc3MsCj4gPiA+ID4gY2F1c2luZyB0aGUgZGlzcGxheSB0byBiZSBlbmFibGVkIHdpdGgg bWluaW11bSBicmlnaHRuZXNzIGluc3RlYWQuCj4gPiA+ID4gQWRkaW5nIHZhcmlvdXMgZGVsYXlz IGluIHRoZSBwYW5lbCBpbml0aWFsaXphdGlvbiBjb2RlIGRvZXMgbm90IHJlc3VsdAo+ID4gPiA+ IGluIGFueSBkaWZmZXJlbmNlLgo+ID4gPiA+Cj4gPiA+ID4gT24gdGhlIG90aGVyIGhhbmQsIG1v dmluZyBkcm1fcGFuZWxfZW5hYmxlKCkgdG8gZHNpX21ncl9icmlkZ2VfZW5hYmxlKCkKPiA+ID4g PiBmaXhlcyB0aGUgcHJvYmxlbSwgaW5kaWNhdGluZyB0aGF0IHRoZSBwYW5lbCByZXF1aXJlcyB0 aGUgdmlkZW8gc3RyZWFtCj4gPiA+ID4gdG8gYmUgYWN0aXZlIGJlZm9yZSB0aGUgYnJpZ2h0bmVz cyBjb21tYW5kIGlzIGFjY2VwdGVkLgo+ID4gPiA+Cj4gPiA+ID4gVGhlcmVmb3JlOiBNb3ZlIGRy bV9wYW5lbF9lbmFibGUoKSB0byBkc2lfbWdyX2JyaWRnZV9lbmFibGUoKSB0bwo+ID4gPiA+IGRl bGF5IGNhbGxpbmcgaXQgdW50aWwgdmlkZW8gZGF0YSBpcyBiZWluZyB0cmFuc21pdHRlZC4KPiA+ ID4gPgo+ID4gPiA+IE1vdmUgZHJtX3BhbmVsX2Rpc2FibGUoKSB0byBkc2lfbWdyX2JyaWRnZV9k aXNhYmxlKCkgZm9yIHNpbWlsYXIgcmVhc29ucy4KPiA+ID4gPiAoVGhpcyBpcyBub3Qgc3RyaWN0 bHkgcmVxdWlyZWQgZm9yIHRoZSBwYW5lbCBhZmZlY3RlZCBhYm92ZS4uLikKPiA+ID4gPgo+ID4g PiA+IFRlc3RlZC1ieTogSmFzcGVyIEtvcnRlbiA8amphMjAwMEBnbWFpbC5jb20+Cj4gPiA+ID4g U2lnbmVkLW9mZi1ieTogU3RlcGhhbiBHZXJob2xkIDxzdGVwaGFuQGdlcmhvbGQubmV0Pgo+ID4g PiA+IC0tLQo+ID4gPiA+IFNpbmNlIHRoaXMgaXMgYSBjb3JlIGNoYW5nZSBJIHRob3VnaHQgaXQg d291bGQgYmUgYmV0dGVyIHRvIHNlbmQgdGhpcwo+ID4gPiA+IGVhcmx5LiBJIGJlbGlldmUgSmFz cGVyIHN0aWxsIHdhbnRzIHRvIGZpbmlzaCBzb21lIG90aGVyIGNoYW5nZXMgYmVmb3JlCj4gPiA+ ID4gc3VibWl0dGluZyB0aGUgaW5pdGlhbCBkZXZpY2UgdHJlZSBmb3IgdGhlIFNhbXN1bmcgR2Fs YXh5IFRhYiBBIDkuNyAoMjAxNSkuIDspCj4gPiA+ID4KPiA+ID4gPiBJIGFsc28gdGVzdGVkIGl0 IG9uIG1zbTg5MTYtc2Ftc3VuZy1hNXUtZXVyLCBpdHMgZGlzcGxheSBpcyB3b3JraW5nIGZpbmUK PiA+ID4gPiB3aXRoIG9yIHdpdGhvdXQgdGhpcyBwYXRjaC4KPiA+ID4KPiA+ID4gTmFjaywgcGxl YXNlLiAgSSB3YXMgY3VyaW91cyBzbyBJIHRocmV3IHRoaXMgb24gdGhlIExlbm92byBNaWl4IDYz MAo+ID4gPiBsYXB0b3AuICBJIGRvbid0IGdldCBhIGRpc3BsYXkgYmFjayB3aXRoIHRoaXMgcGF0 Y2guICBJJ2xsIHRyeSB0bwo+ID4gPiBmaWd1cmUgb3V0IHdoeSwgYnV0IGN1cnJlbnRseSBJIGNh bid0IGdldCBpbnRvIHRoZSBtYWNoaW5lLgo+ID4KPiA+IFRoYW5rcyBmb3IgdGVzdGluZyB0aGUg cGF0Y2ghIExldCdzIHRyeSB0byBmaWd1cmUgdGhhdCBvdXQuLi4KPiA+Cj4gPiBJJ20gYSBiaXQg Y29uZnVzZWQsIGJ1dCB0aGlzIG1pZ2h0IGJlIGJlY2F1c2UgSSdtIG5vdCB2ZXJ5IGZhbWlsaWFy IHdpdGgKPiA+IHRoZSBNU004OTk4IGxhcHRvcHMuIEl0IGRvZXMgbm90IHNlZW0gdG8gaGF2ZSBk aXNwbGF5IGluIG1haW5saW5lIHlldCwKPiA+IHNvIGRvIHlvdSBoYXZlIGEgbGluayB0byBhbGwg dGhlIHBhdGNoZXMgeW91IGFyZSB1c2luZyBhdCB0aGUgbW9tZW50Pwo+IAo+IFRoZSBtZHA1IHN1 cHBvcnQgaXMgdGhlcmUuICBTb21lIG9mIHRoZSBkZXBlbmRlbmNpZXMgaGF2ZSBkcmFnZ2VkIG91 dC4KPiBJJ2QgaGF2ZSB0byBtYWtlIHNlbnNlIG9mIG15IGRldmVsb3BtZW50IHRyZWUgYXMgdG8g d2hhdCBpcyByZWxldmFudC4KCkEgZHVtcCBvZiBhbGwgdGhlIHBhdGNoZXMgKHdoZXRoZXIgc3Rp bGwgcmVsZXZhbnQgb3Igbm90KSB3b3VsZCBiZQpoZWxwZnVsIHRvby4gQWN0dWFsbHkgSSB3YXMg bW9zdGx5IGxvb2tpbmcgZm9yIHRoZSBkZXZpY2UgdHJlZSBwYXJ0IHRvCnNlZSB3aGljaCBjb21w b25lbnRzIGFyZSBpbnZvbHZlZC4KCj4gPgo+ID4gSnVkZ2luZyBmcm9tIHRoZSBwYXRjaGVzIEkg d2FzIGFibGUgdG8gZmluZCwgdGhlIExlbm92byBNaWl4IDYzMCBpcwo+ID4gdXNpbmcgYSBEU0kg dG8gZURQIGJyaWRnZS4KPiA+IElzbid0IHRoZSBwYW5lbCBtYW5hZ2VkIGJ5IHRoZSBicmlkZ2Ug ZHJpdmVyIGluIHRoYXQgY2FzZT8KPiAKPiBJdCB1c2VzIHRoZSBUSSBTTjY1IGJyaWRnZS4KPiAK Ckl0IGlzIGNvdmVyZWQgYnkgdGhlIHRpLXNuNjVkc2k4NiBkcml2ZXIgSSBhc3N1bWU/Cgo+ID4K PiA+IHN0cnVjdCBtc21fZHNpIGNvbnRhaW5zOgo+ID4gICAgICAgICAvKgo+ID4gICAgICAgICAg KiBwYW5lbC9leHRlcm5hbF9icmlkZ2UgY29ubmVjdGVkIHRvIGRzaSBicmlkZ2Ugb3V0cHV0LCBv bmx5IG9uZSBvZiB0aGUKPiA+ICAgICAgICAgICogdHdvIGNhbiBiZSB2YWxpZCBhdCBhIHRpbWUK PiA+ICAgICAgICAgICovCj4gPiAgICAgICAgIHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsOwo+ID4g ICAgICAgICBzdHJ1Y3QgZHJtX2JyaWRnZSAqZXh0ZXJuYWxfYnJpZGdlOwo+ID4KPiA+IFNvIGlm IHlvdSBoYXZlICJleHRlcm5hbF9icmlkZ2UiIHNldCBpbiB5b3VyIGNhc2UsICJwYW5lbCIgc2hv dWxkIGJlIE5VTEwuCj4gPiBJIGhhdmUgb25seSBtb3ZlZCBjb2RlIHRoYXQgdXNlcyBtc21fZHNp LT5wYW5lbCwgc28gbXkgcGF0Y2ggcmVhbGx5Cj4gPiBzaG91bGRuJ3QgbWFrZSBhbnkgZGlmZmVy ZW5jZSBmb3IgeW91Lgo+ID4KPiA+IEFtIEkgY29uZnVzaW5nIHNvbWV0aGluZyBoZXJlPwo+IAo+ IEkgZG9uJ3QgdGhpbmsgcGFuZWwgaXMgbnVsbCBpbiBteSBjYXNlLiAgSSBuZWVkIHRvIHRyYWNl IGEgZmV3IHRoaW5ncwo+IHRocm91Z2ggdG8gYmUgc3VyZS4KPiAKCnRpLXNuNjVkc2k4Ni5jIGNv bnRhaW5zOgoKc3RhdGljIHZvaWQgdGlfc25fYnJpZGdlX2VuYWJsZShzdHJ1Y3QgZHJtX2JyaWRn ZSAqYnJpZGdlKQp7CgkvKiAuLi4gKi8KCWRybV9wYW5lbF9lbmFibGUocGRhdGEtPnBhbmVsKTsK fQoKc3RhdGljIHZvaWQgdGlfc25fYnJpZGdlX3ByZV9lbmFibGUoc3RydWN0IGRybV9icmlkZ2Ug KmJyaWRnZSkKewoJLyogLi4uICovCglkcm1fcGFuZWxfcHJlcGFyZShwZGF0YS0+cGFuZWwpOwp9 CgpTbyBpdCBkb2VzIGluZGVlZCBtYW5hZ2UgdGhlIHBhbmVsIGZvciB5b3UuIElmIG1zbV9kc2kt PnBhbmVsIGlzIG5vdApOVUxMIGZvciB5b3UgaXQgd291bGQgbWVhbiB0aGF0IHlvdXIgcGFuZWwg aXMgbWFuYWdlZCBieSB0d28gZHJpdmVycwphdCB0aGUgc2FtZSB0aW1lLgoKKEFsc28gbm90ZSBo b3cgaXQgY2FsbHMgZHJtX3BhbmVsX2VuYWJsZSgpIGluIGVuYWJsZSgpIGluc3RlYWQgb2YKcHJl X2VuYWJsZSgpLiBUaGlzIGlzIGV4YWN0bHkgdGhlIGNoYW5nZSBteSBwYXRjaCBkb2VzIGZvciB0 aGUgY2FzZQp3aGVuIHRoZSBwYW5lbCBpcyBtYW5hZ2VkIGJ5IHRoZSBNU00gZHJpdmVyLi4uKQoK PiBUYWtpbmcgYSBxdWljayBsb29rIGF0IHRoZSBkYXRhc2hlZXQgZm9yIHRoZSBicmlkZ2UsIEkg c3VzcGVjdCB0aGF0Cj4gb3BlcmF0aW9ucyBhcmUgb2NjdXJyaW5nIGluIHRoZSBlbmFibGUoKSBw aGFzZSBvZiB0aGUgYnJpZGdlLCB0aGF0Cj4gbmVlZCB0byBvY2N1ciBiZWZvcmUgdmlkZW8gZGF0 YSBpcyB0cmFuc21pdHRlZC4gIEJhc2VkIG9uIHlvdXIKPiBhbmFseXNpcyBpbiB0aGUgY29tbWl0 IG1lc3NhZ2UsIEkgc3VzcGVjdCB0aGVzZSBvcGVyYXRpb25zIG5lZWQgdG8gYmUKPiBtb3ZlZCB0 byBwcmVfZW5hYmxlKCkuCj4gCgpJJ20gc3RpbGwgY29uZnVzZWQgaG93IG15IHBhdGNoIG1ha2Vz IGFueSBkaWZmZXJlbmNlIGZvciB5b3UuClRoZSBlbmFibGUgc2VxdWVuY2Ugc2hvdWxkIGJlIGV4 YWN0bHkgdGhlIHNhbWUgYXMgYmVmb3JlLgoKPiBJJ20gaG9waW5nIHRvIGdhdGhlciBtb3JlIGRh dGEgdGhpcyB3ZWVrZW5kLCB3aGljaCB3aWxsIGhvcGVmdWxseQo+IGlkZW50aWZ5IHdoYXQgd2Ug bmVlZCB0byBkbyB0byBtb3ZlIHRoaXMgZm9yd2FyZCB3aXRob3V0IGNhdXNpbmcKPiByZWdyZXNz aW9ucy4KCkxvb2tpbmcgZm9yd2FyZCB0byBpdCwgdGhhbmtzIQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=