Re: [PATCH] iio: adc: aspeed: use devm_platform_ioremap_resource

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 4 Nov 2019 15:12:58 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Sun, 2019-10-13 at 12:37 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Reduces boilerplate.
> > 
> > Identified by: Coccinelle / coccicheck
> > 
> > CHECK   drivers/iio/adc/aspeed_adc.c
> > drivers/iio/adc/aspeed_adc.c:189:1-11: WARNING: Use
> > devm_platform_ioremap_resource for data -> base
> >   
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied. Thanks,

Jonathan

> 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Rick Altherr <raltherr@google.com>
> > ---
> >  drivers/iio/adc/aspeed_adc.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
> > index d3fc39df535d..1e5375235cfe 100644
> > --- a/drivers/iio/adc/aspeed_adc.c
> > +++ b/drivers/iio/adc/aspeed_adc.c
> > @@ -173,7 +173,6 @@ static int aspeed_adc_probe(struct platform_device
> > *pdev)
> >  	struct iio_dev *indio_dev;
> >  	struct aspeed_adc_data *data;
> >  	const struct aspeed_adc_model_data *model_data;
> > -	struct resource *res;
> >  	const char *clk_parent_name;
> >  	int ret;
> >  	u32 adc_engine_control_reg_val;
> > @@ -185,8 +184,7 @@ static int aspeed_adc_probe(struct platform_device
> > *pdev)
> >  	data = iio_priv(indio_dev);
> >  	data->dev = &pdev->dev;
> >  
> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	data->base = devm_ioremap_resource(&pdev->dev, res);
> > +	data->base = devm_platform_ioremap_resource(pdev, 0);
> >  	if (IS_ERR(data->base))
> >  		return PTR_ERR(data->base);
> >