All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"zhiyong.tao@mediatek.com" <zhiyong.tao@mediatek.com>,
	"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] iio: adc: mt6577_auxdac: use devm_platform_ioremap_resource
Date: Sat, 9 Nov 2019 12:15:07 +0000	[thread overview]
Message-ID: <20191109121507.5a25e6ed@archlinux> (raw)
In-Reply-To: <15c54a7c16eda55700e5e073db5650eece76d9f1.camel@analog.com>

On Mon, 4 Nov 2019 15:14:32 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Sun, 2019-10-13 at 13:15 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Reduces boilerplate.  Identified by coccinelle
> > 
> > CHECK   drivers/iio/adc/mt6577_auxadc.c
> > drivers/iio/adc/mt6577_auxadc.c:257:1-18: WARNING: Use
> > devm_platform_ioremap_resource for adc_dev -> reg_base
> >   
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied.

Thanks,

Jonathan

> 
> 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Zhiyong Tao <zhiyong.tao@mediatek.com>
> > ---
> >  drivers/iio/adc/mt6577_auxadc.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/mt6577_auxadc.c
> > b/drivers/iio/adc/mt6577_auxadc.c
> > index 7bbb64ca3b32..a4776d924f3a 100644
> > --- a/drivers/iio/adc/mt6577_auxadc.c
> > +++ b/drivers/iio/adc/mt6577_auxadc.c
> > @@ -237,7 +237,6 @@ static int mt6577_auxadc_probe(struct platform_device
> > *pdev)
> >  {
> >  	struct mt6577_auxadc_device *adc_dev;
> >  	unsigned long adc_clk_rate;
> > -	struct resource *res;
> >  	struct iio_dev *indio_dev;
> >  	int ret;
> >  
> > @@ -253,8 +252,7 @@ static int mt6577_auxadc_probe(struct platform_device
> > *pdev)
> >  	indio_dev->channels = mt6577_auxadc_iio_channels;
> >  	indio_dev->num_channels = ARRAY_SIZE(mt6577_auxadc_iio_channels);
> >  
> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res);
> > +	adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0);
> >  	if (IS_ERR(adc_dev->reg_base)) {
> >  		dev_err(&pdev->dev, "failed to get auxadc base address\n");
> >  		return PTR_ERR(adc_dev->reg_base);  


      reply	other threads:[~2019-11-09 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-13 12:15 [PATCH] iio: adc: mt6577_auxdac: use devm_platform_ioremap_resource jic23
2019-11-04 15:14 ` Ardelean, Alexandru
2019-11-09 12:15   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191109121507.5a25e6ed@archlinux \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alexandru.Ardelean@analog.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=zhiyong.tao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.