All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
	"naidu.tellapati@imgtec.com" <naidu.tellapati@imgtec.com>
Subject: Re: [PATCH] iio: adc: cc10001: use devm_platform_ioremap_resource
Date: Sat, 9 Nov 2019 12:18:47 +0000	[thread overview]
Message-ID: <20191109121847.505e53db@archlinux> (raw)
In-Reply-To: <882478ce1c7e6f6b857231b19b9e15c05f7c943c.camel@analog.com>

On Mon, 4 Nov 2019 15:15:50 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Sun, 2019-10-13 at 13:25 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Reduces local boilerplate.
> > Found by coccinelle:
> > 
> > drivers/iio/adc/cc10001_adc.c:344:1-18: WARNING: Use
> > devm_platform_ioremap_resource for adc_dev -> reg_base
> >   
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied.

Thanks,

Jonathan

> 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Naidu Tellapati <naidu.tellapati@imgtec.com>
> > ---
> >  drivers/iio/adc/cc10001_adc.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/cc10001_adc.c
> > b/drivers/iio/adc/cc10001_adc.c
> > index f93f1d93b80d..fe9257624f16 100644
> > --- a/drivers/iio/adc/cc10001_adc.c
> > +++ b/drivers/iio/adc/cc10001_adc.c
> > @@ -310,7 +310,6 @@ static int cc10001_adc_probe(struct platform_device
> > *pdev)
> >  	struct device_node *node = pdev->dev.of_node;
> >  	struct cc10001_adc_device *adc_dev;
> >  	unsigned long adc_clk_rate;
> > -	struct resource *res;
> >  	struct iio_dev *indio_dev;
> >  	unsigned long channel_map;
> >  	int ret;
> > @@ -340,8 +339,7 @@ static int cc10001_adc_probe(struct platform_device
> > *pdev)
> >  	indio_dev->info = &cc10001_adc_info;
> >  	indio_dev->modes = INDIO_DIRECT_MODE;
> >  
> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res);
> > +	adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0);
> >  	if (IS_ERR(adc_dev->reg_base)) {
> >  		ret = PTR_ERR(adc_dev->reg_base);
> >  		goto err_disable_reg;  


      reply	other threads:[~2019-11-09 12:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-13 12:25 [PATCH] iio: adc: cc10001: use devm_platform_ioremap_resource jic23
2019-11-04 15:15 ` Ardelean, Alexandru
2019-11-09 12:18   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191109121847.505e53db@archlinux \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alexandru.Ardelean@analog.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=naidu.tellapati@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.