From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
"contact@artur-rojek.eu" <contact@artur-rojek.eu>
Subject: Re: [PATCH] iio: adc: ingenic: Use devm_platform_ioremap_resource
Date: Sat, 9 Nov 2019 12:20:23 +0000 [thread overview]
Message-ID: <20191109122023.26b1a6ed@archlinux> (raw)
In-Reply-To: <30c84014f09f22ed2cdfe2d5785eb60adff8b2a7.camel@analog.com>
On Mon, 4 Nov 2019 15:16:14 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 16:27 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Replaces local boilerplate. Identified by coccinelle.
> > CHECK drivers/iio/adc/ingenic-adc.c
> > drivers/iio/adc/ingenic-adc.c:449:1-10: WARNING: Use
> > devm_platform_ioremap_resource for adc -> base
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,
Thanks,
Jonathan
>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Artur Rojek <contact@artur-rojek.eu>
> > ---
> > drivers/iio/adc/ingenic-adc.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-
> > adc.c
> > index 7a53c2f8d438..39c0a609fc94 100644
> > --- a/drivers/iio/adc/ingenic-adc.c
> > +++ b/drivers/iio/adc/ingenic-adc.c
> > @@ -428,7 +428,6 @@ static int ingenic_adc_probe(struct platform_device
> > *pdev)
> > struct device *dev = &pdev->dev;
> > struct iio_dev *iio_dev;
> > struct ingenic_adc *adc;
> > - struct resource *mem_base;
> > const struct ingenic_adc_soc_data *soc_data;
> > int ret;
> >
> > @@ -445,8 +444,7 @@ static int ingenic_adc_probe(struct platform_device
> > *pdev)
> > mutex_init(&adc->aux_lock);
> > adc->soc_data = soc_data;
> >
> > - mem_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - adc->base = devm_ioremap_resource(dev, mem_base);
> > + adc->base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(adc->base))
> > return PTR_ERR(adc->base);
> >
prev parent reply other threads:[~2019-11-09 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 15:27 [PATCH] iio: adc: ingenic: Use devm_platform_ioremap_resource jic23
2019-11-04 15:16 ` Ardelean, Alexandru
2019-11-09 12:20 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191109122023.26b1a6ed@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexandru.Ardelean@analog.com \
--cc=contact@artur-rojek.eu \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.