From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"marek.vasut+renesas@gmail.com" <marek.vasut+renesas@gmail.com>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] iio: adc: rcar-gyroadc: use devm_platform_ioremap_resource
Date: Sat, 9 Nov 2019 12:25:26 +0000 [thread overview]
Message-ID: <20191109122526.01a269a7@archlinux> (raw)
In-Reply-To: <853e5567973d6225307d6b557ecdcca61c86e0b7.camel@analog.com>
On Mon, 4 Nov 2019 15:17:28 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 16:48 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Avoids some local boilerplate.
> > Suggested by coccinelle.
> >
> > CHECK drivers/iio/adc/rcar-gyroadc.c
> > drivers/iio/adc/rcar-gyroadc.c:495:1-11: WARNING: Use
> > devm_platform_ioremap_resource for priv -> regs
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,
Thanks,
Jonathan
>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Marek Vasut <marek.vasut+renesas@gmail.com>
> > ---
> > drivers/iio/adc/rcar-gyroadc.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-
> > gyroadc.c
> > index c37f201294b2..63ce743ee7af 100644
> > --- a/drivers/iio/adc/rcar-gyroadc.c
> > +++ b/drivers/iio/adc/rcar-gyroadc.c
> > @@ -481,7 +481,6 @@ static int rcar_gyroadc_probe(struct platform_device
> > *pdev)
> > struct device *dev = &pdev->dev;
> > struct rcar_gyroadc *priv;
> > struct iio_dev *indio_dev;
> > - struct resource *mem;
> > int ret;
> >
> > indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
> > @@ -491,8 +490,7 @@ static int rcar_gyroadc_probe(struct platform_device
> > *pdev)
> > priv = iio_priv(indio_dev);
> > priv->dev = dev;
> >
> > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - priv->regs = devm_ioremap_resource(dev, mem);
> > + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(priv->regs))
> > return PTR_ERR(priv->regs);
> >
prev parent reply other threads:[~2019-11-09 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 15:48 [PATCH] iio: adc: rcar-gyroadc: use devm_platform_ioremap_resource jic23
2019-11-04 15:17 ` Ardelean, Alexandru
2019-11-09 12:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191109122526.01a269a7@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexandru.Ardelean@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.