Re: [PATCH] iio: adc: spear_adc: Use devm_platform_ioremap_resource

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 4 Nov 2019 15:17:47 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Sun, 2019-10-13 at 16:52 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Avoids local boilerplate doing the same thing.
> > Suggested by coccinelle
> > 
> > CHECK   drivers/iio/adc/spear_adc.c
> > drivers/iio/adc/spear_adc.c:283:1-22: WARNING: Use
> > devm_platform_ioremap_resource for st -> adc_base_spear6xx
> >   
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

Applied,

Thanks for sanity checking all these :)

Jonathan
> 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> >  drivers/iio/adc/spear_adc.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/spear_adc.c b/drivers/iio/adc/spear_adc.c
> > index 592b97c464da..0ad536494e8f 100644
> > --- a/drivers/iio/adc/spear_adc.c
> > +++ b/drivers/iio/adc/spear_adc.c
> > @@ -260,7 +260,6 @@ static int spear_adc_probe(struct platform_device
> > *pdev)
> >  	struct device_node *np = pdev->dev.of_node;
> >  	struct device *dev = &pdev->dev;
> >  	struct spear_adc_state *st;
> > -	struct resource *res;
> >  	struct iio_dev *indio_dev = NULL;
> >  	int ret = -ENODEV;
> >  	int irq;
> > @@ -279,8 +278,7 @@ static int spear_adc_probe(struct platform_device
> > *pdev)
> >  	 * (e.g. SPEAr3xx). Let's provide two register base addresses
> >  	 * to support multi-arch kernels.
> >  	 */
> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	st->adc_base_spear6xx = devm_ioremap_resource(&pdev->dev, res);
> > +	st->adc_base_spear6xx = devm_platform_ioremap_resource(pdev, 0);
> >  	if (IS_ERR(st->adc_base_spear6xx))
> >  		return PTR_ERR(st->adc_base_spear6xx);
> >