All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] configs/stm32mp157c_dk2: disable mkfs metadata_csum and dir_index options
Date: Sat, 9 Nov 2019 15:22:05 +0100	[thread overview]
Message-ID: <20191109152205.0bd1b924@windsurf> (raw)
In-Reply-To: <20191103115017.788940-1-b.bilas@grinn-global.com>

Hello Bartosz,

On Sun,  3 Nov 2019 12:50:16 +0100
Bartosz Bilas <b.bilas@grinn-global.com> wrote:

> To solve issue with non-possibilities to mount rootfs partition we
> should disable a new mkfs features such as metadata_csum and
> dir_index because there is incompatibility with these options.
> 
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
>  configs/stm32mp157c_dk2_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/stm32mp157c_dk2_defconfig b/configs/stm32mp157c_dk2_defconfig
> index a1e61d752d..ba044e5e55 100644
> --- a/configs/stm32mp157c_dk2_defconfig
> +++ b/configs/stm32mp157c_dk2_defconfig
> @@ -16,6 +16,7 @@ BR2_LINUX_KERNEL_INSTALL_TARGET=y
>  BR2_TARGET_ROOTFS_EXT2=y
>  BR2_TARGET_ROOTFS_EXT2_4=y
>  BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> +BR2_TARGET_ROOTFS_EXT2_MKFS_OPTIONS="-O ^64bit,^metadata_csum,^dir_index"

Are you sure it is necessary to disable those three options?

Indeed, U-Boot ext4 write support clearly excludes filesystems that
have the metadata_csum option enabled:

  https://gitlab.denx.de/u-boot/u-boot/blob/master/fs/ext4/ext4_write.c#L880

However, there's nothing about the 64bit and dir_index options. How did
you conclude that they were causing problems? Did you try with just -O
^metadata_csum ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-11-09 14:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-03 11:50 [Buildroot] [PATCH 1/2] configs/stm32mp157c_dk2: disable mkfs metadata_csum and dir_index options Bartosz Bilas
2019-11-03 11:50 ` [Buildroot] [PATCH 2/2] board/stm32mp157c-dk2: remove unnecessary workaround Bartosz Bilas
2019-11-03 18:54   ` Peter Korsgaard
2019-11-04 17:07     ` Bartosz Bilas
2020-01-01 16:21   ` Thomas Petazzoni
2020-01-02 23:22     ` Scott Fan
2020-01-03  7:52       ` Bartosz Biłas
2019-11-03 18:52 ` [Buildroot] [PATCH 1/2] configs/stm32mp157c_dk2: disable mkfs metadata_csum and dir_index options Peter Korsgaard
2019-11-04 17:00   ` Bartosz Bilas
2019-11-09 14:22 ` Thomas Petazzoni [this message]
2019-11-09 15:25   ` Bartosz Bilas
2019-11-17 19:31     ` Arnout Vandecappelle
2019-11-18 17:34       ` Bartosz Bilas
2020-01-01 16:20 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191109152205.0bd1b924@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.