From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E55A1C43331 for ; Sun, 10 Nov 2019 02:41:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC8D9214E0 for ; Sun, 10 Nov 2019 02:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573353669; bh=+mucMr6A/hRINmaccGje7YrhL8FrsBd+/9b1Se5ecYw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Gp8KeACTcUTkCE8ehRv9EYIn9trdARzo00a1PIeGPD0LQIQlHXcIt7qg3Y53g90f1 ScKTldJZ8iGMXMrbo0VckloS66fKwtX6JmfJ3/stSkx7S3VoKUTscjw2natWjmizTa GWjt26FWiVmPqJPnlPjY2epfzp0c77JgyI6RBYQo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727247AbfKJClI (ORCPT ); Sat, 9 Nov 2019 21:41:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:33790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726971AbfKJCki (ORCPT ); Sat, 9 Nov 2019 21:40:38 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5303921D7B; Sun, 10 Nov 2019 02:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573353637; bh=+mucMr6A/hRINmaccGje7YrhL8FrsBd+/9b1Se5ecYw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rr3zOdCN0tdtMG9eFLThLhxqSdKOnNB5thFuQ0DVweUgHK1aJvU+4869NCOkAOtyY 0KfIg6sF1LcGQdEZyZy13TEcWm3DpOMK2bhs6Tmf0Pemn6v1wcs9DrPWAGlUoEMihb q2aTOkIOxzP5UyF6xvKwq4TvVig4v/Xrnjh/yrjs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Corey Minyard , Sasha Levin Subject: [PATCH AUTOSEL 4.19 021/191] ipmi:dmi: Ignore IPMI SMBIOS entries with a zero base address Date: Sat, 9 Nov 2019 21:37:23 -0500 Message-Id: <20191110024013.29782-21-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191110024013.29782-1-sashal@kernel.org> References: <20191110024013.29782-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Corey Minyard [ Upstream commit 1574608f5f4204440d6d9f52b971aba967664764 ] Looking at logs from systems all over the place, it looks like tons of broken systems exist that set the base address to zero. I can only guess that is some sort of non-standard idea to mark the interface as not being present. It can't be zero, anyway, so just complain and ignore it. Signed-off-by: Corey Minyard Signed-off-by: Sasha Levin --- drivers/char/ipmi/ipmi_dmi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c index e2c143861b1e5..28dbd5529188a 100644 --- a/drivers/char/ipmi/ipmi_dmi.c +++ b/drivers/char/ipmi/ipmi_dmi.c @@ -217,6 +217,10 @@ static void __init dmi_decode_ipmi(const struct dmi_header *dm) slave_addr = data[DMI_IPMI_SLAVEADDR]; memcpy(&base_addr, data + DMI_IPMI_ADDR, sizeof(unsigned long)); + if (!base_addr) { + pr_err("Base address is zero, assuming no IPMI interface\n"); + return; + } if (len >= DMI_IPMI_VER2_LENGTH) { if (type == IPMI_DMI_TYPE_SSIF) { offset = 0; -- 2.20.1