From: Wolfram Sang <wsa@the-dreams.de>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Seeking help for getting rid of i2c_clients_command()
Date: Sun, 10 Nov 2019 16:05:53 +0100 [thread overview]
Message-ID: <20191110150553.GA8040@kunai> (raw)
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
Hi Hans,
I know it is 13 years since you wrote that code:
ba8fc39954bf ("V4L/DVB (4270): Add tda9887-specific tuner configuration")
There, you added i2c_clients_command() which looks today like this:
i2c_clients_command(priv->i2c_props.adap, TUNER_SET_CONFIG,
&tda9887_cfg);
Now, I would like to get rid of the i2c_clients_command() API, and this
is the one remaining user. While trying to convert it into a local
function, I started wondering why i2c_clients_command() is used at all.
Why do we need to try all devices on the bus? A few lines later we have:
tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4);
so i2c_props.addr seems to have a valid address? Or are there multiple
tuners on that bus? Can you kindly shed some light on this?
Thank you!
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2019-11-10 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-10 15:05 Wolfram Sang [this message]
2019-11-11 12:26 ` Seeking help for getting rid of i2c_clients_command() Hans Verkuil
2019-11-11 19:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191110150553.GA8040@kunai \
--to=wsa@the-dreams.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.