From: Jonathan Cameron <jic23@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: fabien.lahoudere@collabora.com, enric.balletbo@collabora.com,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v2] iio: cros_ec_baro: set info_mask_shared_by_all_available field
Date: Sun, 10 Nov 2019 15:22:16 +0000 [thread overview]
Message-ID: <20191110152216.28ed370f@archlinux> (raw)
In-Reply-To: <20191106175533.199257-1-gwendal@chromium.org>
On Wed, 6 Nov 2019 09:55:33 -0800
Gwendal Grignou <gwendal@chromium.org> wrote:
> Field was already set for light/proximity and
> accelerometer/gyroscope/magnetometer sensors.
>
> Fixes: ae7b02ad2f32 ("iio: common: cros_ec_sensors: Expose
> cros_ec_sensors frequency range via iio sysfs")
>
> Change-Id: Iffa4c47979994eaaf1abb609c75c080923ecf600
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Seems independent of the large set you have in flight so applied
to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> Changes in v2:
> Forgot to add read_avail entry point.
>
> drivers/iio/pressure/cros_ec_baro.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/pressure/cros_ec_baro.c b/drivers/iio/pressure/cros_ec_baro.c
> index 2354302375de..52f53f3123b1 100644
> --- a/drivers/iio/pressure/cros_ec_baro.c
> +++ b/drivers/iio/pressure/cros_ec_baro.c
> @@ -114,6 +114,7 @@ static int cros_ec_baro_write(struct iio_dev *indio_dev,
> static const struct iio_info cros_ec_baro_info = {
> .read_raw = &cros_ec_baro_read,
> .write_raw = &cros_ec_baro_write,
> + .read_avail = &cros_ec_sensors_core_read_avail,
> };
>
> static int cros_ec_baro_probe(struct platform_device *pdev)
> @@ -149,6 +150,8 @@ static int cros_ec_baro_probe(struct platform_device *pdev)
> BIT(IIO_CHAN_INFO_SCALE) |
> BIT(IIO_CHAN_INFO_SAMP_FREQ) |
> BIT(IIO_CHAN_INFO_FREQUENCY);
> + channel->info_mask_shared_by_all_available =
> + BIT(IIO_CHAN_INFO_SAMP_FREQ);
> channel->scan_type.realbits = CROS_EC_SENSOR_BITS;
> channel->scan_type.storagebits = CROS_EC_SENSOR_BITS;
> channel->scan_type.shift = 0;
prev parent reply other threads:[~2019-11-10 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 17:55 [PATCH v2] iio: cros_ec_baro: set info_mask_shared_by_all_available field Gwendal Grignou
2019-11-10 15:22 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191110152216.28ed370f@archlinux \
--to=jic23@kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=fabien.lahoudere@collabora.com \
--cc=gwendal@chromium.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.