From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/xvisor: unconditionally disable SSP
Date: Sun, 10 Nov 2019 19:45:36 +0100 [thread overview]
Message-ID: <20191110184536.GA3419@scaer> (raw)
In-Reply-To: <20191109164757.29565-1-eric.le.bihan.dev@free.fr>
Arnout, All,
This change looks a lot like what was done for kvm-unit-tests in c0ffd16e4.
What do you think of it?
Regards,
Yann E. MORIN.
On 2019-11-09 17:47 +0100, Eric Le Bihan spake thusly:
> Fixes:
> - http://autobuild.buildroot.net/results/5de37d3da17ca5cb17c0113d942ce8c22c0074e0
> - http://autobuild.buildroot.net/results/41b00d95ec4eb851abceaa7919aa1c533d4f16e8
> - http://autobuild.buildroot.net/results/119e22e8b03991ab9196e428a131f5a8ae2a2b2f
>
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> ---
> ...MAKEFILE-Unconditionally-disable-SSP.patch | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 package/xvisor/0001-MAKEFILE-Unconditionally-disable-SSP.patch
>
> diff --git a/package/xvisor/0001-MAKEFILE-Unconditionally-disable-SSP.patch b/package/xvisor/0001-MAKEFILE-Unconditionally-disable-SSP.patch
> new file mode 100644
> index 0000000000..b69a745462
> --- /dev/null
> +++ b/package/xvisor/0001-MAKEFILE-Unconditionally-disable-SSP.patch
> @@ -0,0 +1,31 @@
> +From f04d1b73a9060e8f09cf1173f89daab73d6c0a18 Mon Sep 17 00:00:00 2001
> +From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> +Date: Sat, 9 Nov 2019 17:13:46 +0100
> +Subject: [PATCH] [MAKEFILE] Unconditionally disable SSP
> +
> +Though -nostdlib is passed in $(cflags), -fno-stack-protector must also be
> +passed to avoid linking errors related to undefined references to
> +'__stack_chk_guard' and '__stack_chk_fail' if toolchain enforces
> +-fstack-protector.
> +
> +Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> +---
> + Makefile | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/Makefile b/Makefile
> +index d6bcf519..de8e1043 100644
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -137,7 +137,7 @@ cppflags+=$(cpu-cppflags)
> + cppflags+=$(board-cppflags)
> + cppflags+=$(libs-cppflags-y)
> + cc=$(CROSS_COMPILE)gcc
> +-cflags=-g -Wall -nostdlib --sysroot=$(drivers_dir)/include -fno-builtin -D__VMM__
> ++cflags=-g -Wall -nostdlib --sysroot=$(drivers_dir)/include -fno-builtin -D__VMM__ -fno-stack-protector
> + cflags+=$(board-cflags)
> + cflags+=$(cpu-cflags)
> + cflags+=$(libs-cflags-y)
> +--
> +2.21.0
> +
> --
> 2.21.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-11-10 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 16:47 [Buildroot] [PATCH] package/xvisor: unconditionally disable SSP Eric Le Bihan
2019-11-10 18:45 ` Yann E. MORIN [this message]
2019-11-17 18:35 ` Arnout Vandecappelle
2019-12-31 8:58 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191110184536.GA3419@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.