From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Mon, 11 Nov 2019 09:30:38 +0000 Subject: Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table Message-Id: <20191111093038.GA3218@dell> List-Id: References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-38-arnd@arndb.de> In-Reply-To: <20191018154201.1276638-38-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Arnd Bergmann Cc: Daniel Thompson , dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Jingoo Han , linux-kernel@vger.kernel.org, Haojian Zhuang , Daniel Mack , linux-fbdev@vger.kernel.org, Robert Jarzmik , linux-arm-kernel@lists.infradead.org On Fri, 18 Oct 2019, Arnd Bergmann wrote: > The driver should not require a machine specific header. Change > it to pass the gpio line through a lookup table, and move the > timing generator definitions into the drivers itself. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Signed-off-by: Arnd Bergmann > > --- > I'm not overly confident that I got the correct device names > for the lookup table, it would be good if someone could > double-check. > --- > arch/arm/mach-pxa/include/mach/tosa.h | 15 -------------- > arch/arm/mach-pxa/tosa.c | 22 +++++++++++++++++++++ > drivers/video/backlight/tosa_bl.c | 10 +++++----- > drivers/video/backlight/tosa_bl.h | 8 ++++++++ > drivers/video/backlight/tosa_lcd.c | 28 ++++++++++++++++++++------- > 5 files changed, 56 insertions(+), 27 deletions(-) > create mode 100644 drivers/video/backlight/tosa_bl.h Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01940C17441 for ; Mon, 11 Nov 2019 09:30:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAC5820818 for ; Mon, 11 Nov 2019 09:30:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qqvowEKw"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R07dOsYY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAC5820818 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WeSQUVjp/izh0vj54xMJmFdjWsS5xPoMWOR8yN8D+wU=; b=qqvowEKwpBKXtd jlgxA2dBIznQrk7bAnEFWppoK6ptAUF8H7F1v6H8CmeH+4zT2kpDhfX3aZnEd7xGgNvXHpAxq1ZsV ItMqvzPB1MUmVzcgdPLbwjlVFHgEdWk3enrFpO3fIq87e2FD71pBRArVY+ZBAwWwLomY2fP12NqoN cYDPALboVeXscNPJSvppsiLV6WgtaQzCsc2k9xsJOBHZUGxQcgO1IH7snZAC7xBXkZH+Zl5zOPTr3 5/2ZILRJw4Fm3Id3dtb+2uAahHPUAqKu74g77S6miViZ/aqb2t5P4QtwUVK3tRzTVyTbepwyJlWGW yHm1uzNjJE6l1rTv0WrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU628-0003b7-V2; Mon, 11 Nov 2019 09:30:52 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU624-0003Zi-Tw for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2019 09:30:50 +0000 Received: by mail-wm1-x341.google.com with SMTP id c22so12457093wmd.1 for ; Mon, 11 Nov 2019 01:30:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=j4UsCyQdcZm2KCJe59FDjzH8nfUWhHJFhxVJ6xfimnY=; b=R07dOsYYwpCpFqth2eEc/oCIsVGaao+wJn8wLg/tmKa7DWZrLBWvdgQx9iz4t5Bou+ NyhMN5nHtROIBDBw/J2CRYIOtN+EXzAti6P8xtElGQWvekQHtrzTT1eBZCFSPGwuzGNu iJOqNEoouqVKG5syT/aSf4ScmQTaC4Dm/aumuHvIxx8ScQuOYUQPsTQ8ogi05kcJA2nF j77KE5TGXxf7iWtwl1Vu/bowSieiJy/4G5x3mTV7Obk6ktIIcic+E42dTW3WxMSJBEB+ 68IyDuWAADrxnS4xxQ7FliuravZHxaMgwkmsk8Ogdrup6ezZyviq0N4hLN6CZ9tChZSi Z2PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=j4UsCyQdcZm2KCJe59FDjzH8nfUWhHJFhxVJ6xfimnY=; b=iH84cd5ogeau6jcFaWK3vJ2/GUCdhAcaWdkbRtFgwIIxbgN4mDeiwxXOY5QF7wavo1 NqR8OKjk6ozu2LRfc4RGWCpFQustBgM55iq55fupHaF77EZqDjYzxXq41hiu80YcdL5R d7hUCtra5aK5xGDDCLpTowgYI9Te/78vLvKMv4w4g8vVi8I5e+2WWDVwdIgH1hROQnW8 pMlylEOhUMrInEDCdmwHehrvi6vyKkNCYH1TUhNB+EFMFrNBg2Gu9Vui+MrUjLxdGNa4 1oRppIe+um7KB+MAn6I4RYNJhH6MpK6uzw1lVoYK0ht8uibgvQx45faQYd4zviWDi1iD s+PQ== X-Gm-Message-State: APjAAAUJysRnkfA3/2/JOusmQCfOXII/ZUxPBEpnqkRRNG/ZliDJhn1I 77o+3CzrM6iwdKCQmC7HEB4R4g== X-Google-Smtp-Source: APXvYqz0dNCJqOn51gF9WLKs0blLiqHdYKWXicmqZcGwIqo2oULL5pMRIbpJqhIRh6h98e57UR7klQ== X-Received: by 2002:a1c:9a81:: with SMTP id c123mr18676120wme.118.1573464646982; Mon, 11 Nov 2019 01:30:46 -0800 (PST) Received: from dell ([95.147.198.88]) by smtp.gmail.com with ESMTPSA id z14sm13555064wrl.60.2019.11.11.01.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 01:30:45 -0800 (PST) Date: Mon, 11 Nov 2019 09:30:38 +0000 From: Lee Jones To: Arnd Bergmann Subject: Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table Message-ID: <20191111093038.GA3218@dell> References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-38-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191018154201.1276638-38-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_013048_972260_FDDA46D0 X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Jingoo Han , Linus Walleij , linux-kernel@vger.kernel.org, Haojian Zhuang , Daniel Mack , linux-fbdev@vger.kernel.org, Robert Jarzmik , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxOCBPY3QgMjAxOSwgQXJuZCBCZXJnbWFubiB3cm90ZToKCj4gVGhlIGRyaXZlciBz aG91bGQgbm90IHJlcXVpcmUgYSBtYWNoaW5lIHNwZWNpZmljIGhlYWRlci4gQ2hhbmdlCj4gaXQg dG8gcGFzcyB0aGUgZ3BpbyBsaW5lIHRocm91Z2ggYSBsb29rdXAgdGFibGUsIGFuZCBtb3ZlIHRo ZQo+IHRpbWluZyBnZW5lcmF0b3IgZGVmaW5pdGlvbnMgaW50byB0aGUgZHJpdmVycyBpdHNlbGYu Cj4gCj4gQ2M6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gQ2M6IERhbmllbCBU aG9tcHNvbiA8ZGFuaWVsLnRob21wc29uQGxpbmFyby5vcmc+Cj4gQ2M6IEppbmdvbyBIYW4gPGpp bmdvb2hhbjFAZ21haWwuY29tPgo+IENjOiBCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6IDxiLnpv bG5pZXJraWVAc2Ftc3VuZy5jb20+Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBDYzogbGludXgtZmJkZXZAdmdlci5rZXJuZWwub3JnCj4gU2lnbmVkLW9mZi1ieTogQXJu ZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KPiAKPiAtLS0KPiBJJ20gbm90IG92ZXJseSBjb25m aWRlbnQgdGhhdCBJIGdvdCB0aGUgY29ycmVjdCBkZXZpY2UgbmFtZXMKPiBmb3IgdGhlIGxvb2t1 cCB0YWJsZSwgaXQgd291bGQgYmUgZ29vZCBpZiBzb21lb25lIGNvdWxkCj4gZG91YmxlLWNoZWNr Lgo+IC0tLQo+ICBhcmNoL2FybS9tYWNoLXB4YS9pbmNsdWRlL21hY2gvdG9zYS5oIHwgMTUgLS0t LS0tLS0tLS0tLS0KPiAgYXJjaC9hcm0vbWFjaC1weGEvdG9zYS5jICAgICAgICAgICAgICB8IDIy ICsrKysrKysrKysrKysrKysrKysrKwo+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC90b3NhX2Js LmMgICAgIHwgMTAgKysrKystLS0tLQo+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC90b3NhX2Js LmggICAgIHwgIDggKysrKysrKysKPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvdG9zYV9sY2Qu YyAgICB8IDI4ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLQo+ICA1IGZpbGVzIGNoYW5nZWQs IDU2IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygtKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQg ZHJpdmVycy92aWRlby9iYWNrbGlnaHQvdG9zYV9ibC5oCgpBcHBsaWVkLCB0aGFua3MuCgotLSAK TGVlIEpvbmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNlcyBUZWNobmljYWwgTGVhZApMaW5h cm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFy bzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table Date: Mon, 11 Nov 2019 09:30:38 +0000 Message-ID: <20191111093038.GA3218@dell> References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-38-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64CA76E872 for ; Mon, 11 Nov 2019 09:30:48 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id q70so12496893wme.1 for ; Mon, 11 Nov 2019 01:30:48 -0800 (PST) Content-Disposition: inline In-Reply-To: <20191018154201.1276638-38-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: Daniel Thompson , dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Jingoo Han , linux-kernel@vger.kernel.org, Haojian Zhuang , Daniel Mack , linux-fbdev@vger.kernel.org, Robert Jarzmik , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAxOCBPY3QgMjAxOSwgQXJuZCBCZXJnbWFubiB3cm90ZToKCj4gVGhlIGRyaXZlciBz aG91bGQgbm90IHJlcXVpcmUgYSBtYWNoaW5lIHNwZWNpZmljIGhlYWRlci4gQ2hhbmdlCj4gaXQg dG8gcGFzcyB0aGUgZ3BpbyBsaW5lIHRocm91Z2ggYSBsb29rdXAgdGFibGUsIGFuZCBtb3ZlIHRo ZQo+IHRpbWluZyBnZW5lcmF0b3IgZGVmaW5pdGlvbnMgaW50byB0aGUgZHJpdmVycyBpdHNlbGYu Cj4gCj4gQ2M6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4gQ2M6IERhbmllbCBU aG9tcHNvbiA8ZGFuaWVsLnRob21wc29uQGxpbmFyby5vcmc+Cj4gQ2M6IEppbmdvbyBIYW4gPGpp bmdvb2hhbjFAZ21haWwuY29tPgo+IENjOiBCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6IDxiLnpv bG5pZXJraWVAc2Ftc3VuZy5jb20+Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBDYzogbGludXgtZmJkZXZAdmdlci5rZXJuZWwub3JnCj4gU2lnbmVkLW9mZi1ieTogQXJu ZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KPiAKPiAtLS0KPiBJJ20gbm90IG92ZXJseSBjb25m aWRlbnQgdGhhdCBJIGdvdCB0aGUgY29ycmVjdCBkZXZpY2UgbmFtZXMKPiBmb3IgdGhlIGxvb2t1 cCB0YWJsZSwgaXQgd291bGQgYmUgZ29vZCBpZiBzb21lb25lIGNvdWxkCj4gZG91YmxlLWNoZWNr Lgo+IC0tLQo+ICBhcmNoL2FybS9tYWNoLXB4YS9pbmNsdWRlL21hY2gvdG9zYS5oIHwgMTUgLS0t LS0tLS0tLS0tLS0KPiAgYXJjaC9hcm0vbWFjaC1weGEvdG9zYS5jICAgICAgICAgICAgICB8IDIy ICsrKysrKysrKysrKysrKysrKysrKwo+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC90b3NhX2Js LmMgICAgIHwgMTAgKysrKystLS0tLQo+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC90b3NhX2Js LmggICAgIHwgIDggKysrKysrKysKPiAgZHJpdmVycy92aWRlby9iYWNrbGlnaHQvdG9zYV9sY2Qu YyAgICB8IDI4ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLQo+ICA1IGZpbGVzIGNoYW5nZWQs IDU2IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygtKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQg ZHJpdmVycy92aWRlby9iYWNrbGlnaHQvdG9zYV9ibC5oCgpBcHBsaWVkLCB0aGFua3MuCgotLSAK TGVlIEpvbmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNlcyBUZWNobmljYWwgTGVhZApMaW5h cm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFy bzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 992FAC43331 for ; Mon, 11 Nov 2019 09:30:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 708A22075C for ; Mon, 11 Nov 2019 09:30:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R07dOsYY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727032AbfKKJav (ORCPT ); Mon, 11 Nov 2019 04:30:51 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:38646 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726804AbfKKJau (ORCPT ); Mon, 11 Nov 2019 04:30:50 -0500 Received: by mail-wm1-f67.google.com with SMTP id z19so12425071wmk.3 for ; Mon, 11 Nov 2019 01:30:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=j4UsCyQdcZm2KCJe59FDjzH8nfUWhHJFhxVJ6xfimnY=; b=R07dOsYYwpCpFqth2eEc/oCIsVGaao+wJn8wLg/tmKa7DWZrLBWvdgQx9iz4t5Bou+ NyhMN5nHtROIBDBw/J2CRYIOtN+EXzAti6P8xtElGQWvekQHtrzTT1eBZCFSPGwuzGNu iJOqNEoouqVKG5syT/aSf4ScmQTaC4Dm/aumuHvIxx8ScQuOYUQPsTQ8ogi05kcJA2nF j77KE5TGXxf7iWtwl1Vu/bowSieiJy/4G5x3mTV7Obk6ktIIcic+E42dTW3WxMSJBEB+ 68IyDuWAADrxnS4xxQ7FliuravZHxaMgwkmsk8Ogdrup6ezZyviq0N4hLN6CZ9tChZSi Z2PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=j4UsCyQdcZm2KCJe59FDjzH8nfUWhHJFhxVJ6xfimnY=; b=R53CsjjTDkyft1PhCX3aGaATu4hiYww11pnIlRqNJBW5sGoZ3JYMT0EMJHs56JkzC6 f0D2WeLN+mUC60fwfiZf7Mk8Fxl1FIrvjzdnwSSGr30HqXoDfV0O/O+xSDIqQ8hlr/lO gXtabm/nLZZFqYehvPCIAuk5XAb4G5lRwnNpigCFUMKj1ygzsBKR6EaYWfP4QZ0IR7fb qTvtsx4Mj73F0ZIhXQcyMQvxuNQO6sqg+NYh+W36JWyZ6swwY/B+gvdJ1MKMhU9DXd3l mt2VJgk8NyvjdMErHXxK6PWRBWE13lVP5YONP7tQotRKoXltYaH1Kgky/Nm1BaVi4kuF 7E3w== X-Gm-Message-State: APjAAAVWdiLNxeK3CCVlV354D3d3Tc97d37zKVeeGpO2INOTu2r9YLtX 4awsscxtCh8WRoT0jvkN4WkoIw== X-Google-Smtp-Source: APXvYqz0dNCJqOn51gF9WLKs0blLiqHdYKWXicmqZcGwIqo2oULL5pMRIbpJqhIRh6h98e57UR7klQ== X-Received: by 2002:a1c:9a81:: with SMTP id c123mr18676120wme.118.1573464646982; Mon, 11 Nov 2019 01:30:46 -0800 (PST) Received: from dell ([95.147.198.88]) by smtp.gmail.com with ESMTPSA id z14sm13555064wrl.60.2019.11.11.01.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 01:30:45 -0800 (PST) Date: Mon, 11 Nov 2019 09:30:38 +0000 From: Lee Jones To: Arnd Bergmann Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table Message-ID: <20191111093038.GA3218@dell> References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-38-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191018154201.1276638-38-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Oct 2019, Arnd Bergmann wrote: > The driver should not require a machine specific header. Change > it to pass the gpio line through a lookup table, and move the > timing generator definitions into the drivers itself. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Signed-off-by: Arnd Bergmann > > --- > I'm not overly confident that I got the correct device names > for the lookup table, it would be good if someone could > double-check. > --- > arch/arm/mach-pxa/include/mach/tosa.h | 15 -------------- > arch/arm/mach-pxa/tosa.c | 22 +++++++++++++++++++++ > drivers/video/backlight/tosa_bl.c | 10 +++++----- > drivers/video/backlight/tosa_bl.h | 8 ++++++++ > drivers/video/backlight/tosa_lcd.c | 28 ++++++++++++++++++++------- > 5 files changed, 56 insertions(+), 27 deletions(-) > create mode 100644 drivers/video/backlight/tosa_bl.h Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog