From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 09/12] drm/modes: parse_cmdline: Add support for specifying panel_orientation Date: Mon, 11 Nov 2019 13:53:58 +0100 Message-ID: <20191111125358.GP4345@gilmour.lan> References: <20191110154101.26486-1-hdegoede@redhat.com> <20191110154101.26486-10-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0177950240==" Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id CBFF889623 for ; Mon, 11 Nov 2019 12:54:01 +0000 (UTC) In-Reply-To: <20191110154101.26486-10-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans de Goede Cc: David Airlie , dri-devel@lists.freedesktop.org, Sean Paul , Daniel Vetter , Mathieu =?iso-8859-1?Q?Alexandre-T=E9treault?= List-Id: dri-devel@lists.freedesktop.org --===============0177950240== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H83aLI5Lttn3Hg7B" Content-Disposition: inline --H83aLI5Lttn3Hg7B Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Hans, Thanks for this series (and thanks for bouncing the mails too). All the previous patches are Acked-by: Maxime Ripard On Sun, Nov 10, 2019 at 04:40:58PM +0100, Hans de Goede wrote: > Sometimes we want to override a connector's panel_orientation from the > kernel commandline. Either for testing and for special cases, e.g. a kiosk > like setup which uses a TV mounted in portrait mode. > > Users can already specify a "rotate" option through a video= kernel cmdline > option. But that only supports 0/180 degrees (see drm_client_modeset TODO) > and only works for in kernel modeset clients, not for userspace kms users. > > The "panel-orientation" connector property OTOH does support 90/270 degrees > as it leaves dealing with the rotation up to userspace and this does work > for userspace kms clients (at least those which support this property). > > BugLink: https://gitlab.freedesktop.org/plymouth/plymouth/merge_requests/83 > Signed-off-by: Hans de Goede > --- > Documentation/fb/modedb.rst | 3 ++ > drivers/gpu/drm/drm_modes.c | 32 +++++++++++++++++++ > .../gpu/drm/selftests/drm_cmdline_selftests.h | 1 + > .../drm/selftests/test-drm_cmdline_parser.c | 22 +++++++++++++ > include/drm/drm_connector.h | 8 +++++ > 5 files changed, 66 insertions(+) > > diff --git a/Documentation/fb/modedb.rst b/Documentation/fb/modedb.rst > index 9c4e3fd39e6d..624d08fd2856 100644 > --- a/Documentation/fb/modedb.rst > +++ b/Documentation/fb/modedb.rst > @@ -65,6 +65,9 @@ Valid options are:: > - reflect_y (boolean): Perform an axial symmetry on the Y axis > - rotate (integer): Rotate the initial framebuffer by x > degrees. Valid values are 0, 90, 180 and 270. > + - panel_orientation, one of "normal", "upside_down", "left_side_up", or > + "right_side_up". For KMS drivers only, this sets the "panel orientation" > + property on the kms connector as hint for kms users. Even though the semantic is a bit different, I think we should remain consistent and have the same argument than for rotate (ie, steps in clockwise rotation in steps of 90 degrees). The rest looks good Maxime --H83aLI5Lttn3Hg7B Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXclZ5gAKCRDj7w1vZxhR xdClAQCIsCtZVrQ3IchuZnO8n1EfLhM6HWCESB/amgzAd2x02AD/RqSv/RPS+tem 8K3GGaDFuJ5u/XT/rkunQAUk2qySvgo= =46OA -----END PGP SIGNATURE----- --H83aLI5Lttn3Hg7B-- --===============0177950240== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0177950240==--