From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/edid: fixup EDID 1.3 and 1.4 judge reduced-blanking timings logic Date: Mon, 11 Nov 2019 15:54:56 +0200 Message-ID: <20191111135456.GL1208@intel.com> References: <1572856969-12115-1-git-send-email-allen.chen@ite.com.tw> <20191107154209.GC1208@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7854A6E1E8 for ; Mon, 11 Nov 2019 13:55:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: allen.chen@ite.com.tw Cc: Jau-Chih.Tseng@ite.com.tw, maxime.ripard@bootlin.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, pihsun@chromium.org, sean@poorly.run List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBOb3YgMTEsIDIwMTkgYXQgMDE6NDM6NTJBTSArMDAwMCwgYWxsZW4uY2hlbkBpdGUu Y29tLnR3IHdyb3RlOgo+IEhpIFZpbGxlIFN5cmrDpGzDpAo+IAo+IFRoYW5rcyBmb3IgeW91ciBz dWdnZXN0aW9uIGFuZCBJIGhhdmUgcmVwbGllZCB0d28gY29tbWVudHMgYmVsb3cuCj4gCj4gRnJv bTogVmlsbGUgU3lyasOkbMOkIFttYWlsdG86dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb21d IAo+IFNlbnQ6IFRodXJzZGF5LCBOb3ZlbWJlciAwNywgMjAxOSAxMTo0MiBQTQo+IFRvOiBBbGxl biBDaGVuICjpmbPmn4/lrocpCj4gQ2M6IEphdS1DaGloIFRzZW5nICjmm77mmK3mmbopOyBNYXhp bWUgUmlwYXJkOyBvcGVuIGxpc3Q7IG9wZW4gbGlzdDpEUk0gRFJJVkVSUzsgRGF2aWQgQWlybGll OyBQaS1Ic3VuIFNoaWg7IFNlYW4gUGF1bAo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGRybS9lZGlk OiBmaXh1cCBFRElEIDEuMyBhbmQgMS40IGp1ZGdlIHJlZHVjZWQtYmxhbmtpbmcgdGltaW5ncyBs b2dpYwo+IAo+IE9uIE1vbiwgTm92IDA0LCAyMDE5IGF0IDA0OjQyOjQ5UE0gKzA4MDAsIGFsbGVu IHdyb3RlOgo+ID4gQWNjb3JkaW5nIHRvIFZFU0EgRU5IQU5DRUQgRVhURU5ERUQgRElTUExBWSBJ REVOVElGSUNBVElPTiBEQVRBIFNUQU5EQVJECj4gPiAoRGVmaW5lcyBFRElEIFN0cnVjdHVyZSBW ZXJzaW9uIDEsIFJldmlzaW9uIDQpIHBhZ2U6IDM5Cj4gPiBIb3cgdG8gZGV0ZXJtaW5lIHdoZXRo ZXIgdGhlIG1vbml0b3Igc3VwcG9ydCBSQiB0aW1pbmcgb3Igbm90Pwo+ID4gRURJRCAxLjQKPiA+ IEZpcnN0OiAgcmVhZCBkZXRhaWxlZCB0aW1pbmcgZGVzY3JpcHRvciBhbmQgbWFrZSBzdXJlIGJ5 dGUwID0gMCwKPiA+IAlieXRlMSA9IDAsIGJ5dGUyID0gMCBhbmQgYnl0ZTMgPSAweEZECj4gCj4g VGhhdCBzaG91bGQgcHJvYmFibHkgYmUgc29tZSBuZXcgZnVuY3Rpb246Cj4gYm9vbCBpc19kaXNw bGF5X2Rlc2NyaXB0b3IoY29uc3QgdTggKmRlc2MsIHU4IHRhZyk7Cj4gaXNfZGlzcGxheV9kZXNj cmlwdG9yKEVESURfREVUQUlMX01PTklUT1JfUkFOR0UpCj4gb3Igc29tZXRoaW5nIGFsb25nIHRo b3NlIGxpbmVzCj4gCj4gV2UgZG9uJ3Qgc2VlbSB0byBjaGVjayB0aGF0IGluIG1vc3QgcGxhY2Vz IHNvIHNob3VsZCBiZSByb2xsZWQgb3V0IGFsbAo+IG92ZXIuIFRoZSB1c2FnZSBvZiBzdHJ1Y3Qg ZGV0YWlsZWRfdGltaW5nIGFsbCBvdmVyIGFsc28gbWFrZXMgZXZlcnl0aGluZwo+IHJhdGhlciBj b25mdXNpbmcuCj4gCj4gPiBTZWNvbmQ6IHJlYWQgZGV0YWlsZWQgdGltaW5nIGRlc2NyaXB0b3Ig Ynl0ZTEwID0gMHgwNCBhbmQKPiA+IAlFRElEIGJ5dGUxOGggYml0MCA9IDEKPiAKPiBJbmRpY2F0 ZXMgQ1ZUIHN1cHBvcnQuIFNob3VsZCBnaXZlIHRoZXNlIHRoaW5ncyByZWFsIG5hbWVzIHNvCj4g b25lIHdvdWxkbid0IGhhdmUgdG8gZGVjb2RlIGJ5IGhhbmQuCj4gCj4gPiBUaGlyZDogIGlmIEVE SUQgYnl0ZTE4aCBiaXQwID09IDEgJiYgYnl0ZTEwID09IDB4MDQsCj4gPiAJdGhlbiB3ZSBjYW4g Y2hlY2sgYnl0ZTE1LCBpZiBieXRlMTUgYml0NCA9MSBpcyBzdXBwb3J0IFJCCj4gPiAgICAgICAg IGlmIEVESUQgYnl0ZTE4aCBiaXQwICE9IDEgfHwgYnl0ZTEwICE9IDB4MDQsCj4gPiAJdGhlbiBi eXRlMTUgY2FuIG5vdCBiZSB1c2VkCj4gPiAKPiA+IFRoZSBsaW51eCBjb2RlIGlzX3JiIGZ1bmN0 aW9uIG5vdCBmb2xsb3cgdGhlIFZFU0EncyBydWxlCj4gPiAKPiA+IEVESUQgMS4zCj4gPiBMQ0Ti gIJmbGF04oCCcGFuZWxzIGRv4oCCbm904oCCcmVxdWlyZeKAgmxvbmfigIJibGFua2luZ+KAgmlu dGVydmFsc+KAgmFz4oCCYeKAgnJldHJhY2UKPiA+IHBlcmlvZCBzbyBkZWZhdWx0IHN1cHBvcnQg cmVkdWNlZC1ibGFua2luZyB0aW1pbmdzLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBBbGxlbiBD aGVuIDxhbGxlbi5jaGVuQGl0ZS5jb20udHc+Cj4gPiBSZXBvcnRlZC1ieToga2J1aWxkIHRlc3Qg cm9ib3QgPGxrcEBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2Vk aWQuYyB8IDI4ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdl ZCwgMjEgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMK PiA+IGluZGV4IGU1ZTdlNjUuLjliNjdiODAgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2VkaWQuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMKPiA+IEBA IC05Myw2ICs5MywxMSBAQCBzdHJ1Y3QgZGV0YWlsZWRfbW9kZV9jbG9zdXJlIHsKPiA+ICAJaW50 IG1vZGVzOwo+ID4gIH07Cj4gPiAgCj4gPiArc3RydWN0IGVkaWRfc3VwcG9ydF9yYl9jbG9zdXJl IHsKPiA+ICsJc3RydWN0IGVkaWQgKmVkaWQ7Cj4gPiArCXM4IHN1cHBvcnRfcmI7Cj4gCj4gYm9v bAo+IAo+ID09PiBJVEU6ICBJZiB1c2UgYm9vbCwgd2UgY291bGQgbm90IHJldHVybiBFRElEMS4z IHdoZW4gRURJRDEuNCBsb2dpYyBjYW4gbm90IGJlIGFwcGxpZWQKCkhtbS4gQ291bGQgdXNlIHR3 byBib29scyB0aGVuLgoKPiA+ICt9Owo+ID4gKwo+ID4gICNkZWZpbmUgTEVWRUxfRE1UCTAKPiA+ ICAjZGVmaW5lIExFVkVMX0dURgkxCj4gPiAgI2RlZmluZSBMRVZFTF9HVEYyCTIKPiA+IEBAIC0y MDE4LDIyICsyMDIzLDMxIEBAIHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpkcm1fbW9kZV9maW5k X2RtdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4gIGlzX3JiKHN0cnVjdCBkZXRhaWxlZF90 aW1pbmcgKnQsIHZvaWQgKmRhdGEpCj4gPiAgewo+ID4gIAl1OCAqciA9ICh1OCAqKXQ7Cj4gPiAt CWlmIChyWzNdID09IEVESURfREVUQUlMX01PTklUT1JfUkFOR0UpCj4gPiAtCQlpZiAoclsxNV0g JiAweDEwKQo+ID4gLQkJCSooYm9vbCAqKWRhdGEgPSB0cnVlOwo+ID4gKwlzdHJ1Y3QgZWRpZF9z dXBwb3J0X3JiX2Nsb3N1cmUgKmNsb3N1cmUgPSBkYXRhOwo+ID4gKwlzdHJ1Y3QgZWRpZCAqZWRp ZCA9IGNsb3N1cmUtPmVkaWQ7Cj4gPiArCj4gPiArCWlmICghclswXSAmJiAhclsxXSAmJiAhclsy XSAmJiByWzNdID09IEVESURfREVUQUlMX01PTklUT1JfUkFOR0UpIHsKPiA+ICsJCWlmIChlZGlk LT5mZWF0dXJlcyAmIEJJVCgwKSAmJiByWzEwXSA9PSBCSVQoMikpCj4gPiArCQkJY2xvc3VyZS0+ c3VwcG9ydF9yYiA9IChyWzE1XSAmIDB4MTApID8gMSA6IDA7Cj4gCj4gV2l0aCB0aGUgYm9vbCB0 aGUgdGVybmFyeSBvcGVyYXRvciBpcyBub3QgbmVlZGVkLiBBbHNvIHNob3VsZCBtYXliZSAKPiBi ZSB8PSBpbiBjYXNlIHdlIGhhdmUgbXVsdGlwbGUgcmFuZ2UgZGVzY3JpcHRvcnM/IE5vdCBzdXJl IHRoYXQgaXMKPiBsZWdhbC4KPiAKPiA+ICsJfQo+ID4gIH0KPiA+ICAKPiA+ICAvKiBFRElEIDEu NCBkZWZpbmVzIHRoaXMgZXhwbGljaXRseS4gIEZvciBFRElEIDEuMywgd2UgZ3Vlc3MsIGJhZGx5 LiAqLwo+ID4gIHN0YXRpYyBib29sCj4gPiAgZHJtX21vbml0b3Jfc3VwcG9ydHNfcmIoc3RydWN0 IGVkaWQgKmVkaWQpCj4gPiAgewo+ID4gKwlzdHJ1Y3QgZWRpZF9zdXBwb3J0X3JiX2Nsb3N1cmUg Y2xvc3VyZSA9IHsKPiA+ICsJCS5lZGlkID0gZWRpZCwKPiA+ICsJCS5zdXBwb3J0X3JiID0gLTEs Cj4gPiArCX07Cj4gPiArCj4gPiAgCWlmIChlZGlkLT5yZXZpc2lvbiA+PSA0KSB7Cj4gPiAtCQli b29sIHJldCA9IGZhbHNlOwo+ID4gLQkJZHJtX2Zvcl9lYWNoX2RldGFpbGVkX2Jsb2NrKCh1OCAq KWVkaWQsIGlzX3JiLCAmcmV0KTsKPiA+IC0JCXJldHVybiByZXQ7Cj4gPiArCQlkcm1fZm9yX2Vh Y2hfZGV0YWlsZWRfYmxvY2soKHU4ICopZWRpZCwgaXNfcmIsICZjbG9zdXJlKTsKPiA+ICsJCWlm IChjbG9zdXJlLnN1cHBvcnRfcmIgPj0gMCkKPiA+ICsJCQlyZXR1cm4gY2xvc3VyZS5zdXBwb3J0 X3JiOwo+ID4gIAl9Cj4gPiAgCj4gPiAtCXJldHVybiAoKGVkaWQtPmlucHV0ICYgRFJNX0VESURf SU5QVVRfRElHSVRBTCkgIT0gMCk7Cj4gPiArCXJldHVybiB0cnVlOwo+IAo+IFdoeSBhcmUgd2Ug bm93IGFzc3VtaW5nIHJiIGZvciBhbGwgcHJlIDEuNCBFRElEcz8KPiAKPiA9PT4gSVRFOiBUb2Rh eSwgbW9zdCBvZiB0aGUgbW9uaXRvciBhcmUgTENEIGFuZCBMQ0QgbW9uaXRvciBkbyBub3QgcmVx dWlyZSBsb25nIGJsYW5raW5nIGludGVydmFscyBhcyBhIHJldHJhY2UgcGVyaW9kIHNvIGRlZmF1 bHQgc3VwcG9ydCByZWR1Y2VkLWJsYW5raW5nIHRpbWluZ3MuCgpZb3UgY2FuJ3QgYXNzdW1lIHN1 Y2ggdGhpbmdzLiBTb21lb25lIG91dCB0aGVyZSBpcyBzdXJlbHkgc3RpbGwgdXNpbmcKc29tZXRo aW5nIHRoYXQgZG9lc24ndCBkbyByZWR1Y2VkIGJsYW5raW5nLgoKPiAKPiA+ICB9Cj4gPiAgCj4g PiAgc3RhdGljIHZvaWQKPiA+IC0tIAo+ID4gMS45LjEKPiA+IAo+ID4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IGRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4gCj4gLS0gCj4gVmls bGUgU3lyasOkbMOkCj4gSW50ZWwKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B0EC43331 for ; Mon, 11 Nov 2019 13:55:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6D56206A3 for ; Mon, 11 Nov 2019 13:55:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbfKKNzB (ORCPT ); Mon, 11 Nov 2019 08:55:01 -0500 Received: from mga04.intel.com ([192.55.52.120]:58271 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726915AbfKKNzB (ORCPT ); Mon, 11 Nov 2019 08:55:01 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 05:55:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,293,1569308400"; d="scan'208";a="207119211" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga006.jf.intel.com with SMTP; 11 Nov 2019 05:54:57 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 11 Nov 2019 15:54:56 +0200 Date: Mon, 11 Nov 2019 15:54:56 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: allen.chen@ite.com.tw Cc: Jau-Chih.Tseng@ite.com.tw, maxime.ripard@bootlin.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, pihsun@chromium.org, sean@poorly.run Subject: Re: [PATCH] drm/edid: fixup EDID 1.3 and 1.4 judge reduced-blanking timings logic Message-ID: <20191111135456.GL1208@intel.com> References: <1572856969-12115-1-git-send-email-allen.chen@ite.com.tw> <20191107154209.GC1208@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2019 at 01:43:52AM +0000, allen.chen@ite.com.tw wrote: > Hi Ville Syrjälä > > Thanks for your suggestion and I have replied two comments below. > > From: Ville Syrjälä [mailto:ville.syrjala@linux.intel.com] > Sent: Thursday, November 07, 2019 11:42 PM > To: Allen Chen (陳柏宇) > Cc: Jau-Chih Tseng (曾昭智); Maxime Ripard; open list; open list:DRM DRIVERS; David Airlie; Pi-Hsun Shih; Sean Paul > Subject: Re: [PATCH] drm/edid: fixup EDID 1.3 and 1.4 judge reduced-blanking timings logic > > On Mon, Nov 04, 2019 at 04:42:49PM +0800, allen wrote: > > According to VESA ENHANCED EXTENDED DISPLAY IDENTIFICATION DATA STANDARD > > (Defines EDID Structure Version 1, Revision 4) page: 39 > > How to determine whether the monitor support RB timing or not? > > EDID 1.4 > > First: read detailed timing descriptor and make sure byte0 = 0, > > byte1 = 0, byte2 = 0 and byte3 = 0xFD > > That should probably be some new function: > bool is_display_descriptor(const u8 *desc, u8 tag); > is_display_descriptor(EDID_DETAIL_MONITOR_RANGE) > or something along those lines > > We don't seem to check that in most places so should be rolled out all > over. The usage of struct detailed_timing all over also makes everything > rather confusing. > > > Second: read detailed timing descriptor byte10 = 0x04 and > > EDID byte18h bit0 = 1 > > Indicates CVT support. Should give these things real names so > one wouldn't have to decode by hand. > > > Third: if EDID byte18h bit0 == 1 && byte10 == 0x04, > > then we can check byte15, if byte15 bit4 =1 is support RB > > if EDID byte18h bit0 != 1 || byte10 != 0x04, > > then byte15 can not be used > > > > The linux code is_rb function not follow the VESA's rule > > > > EDID 1.3 > > LCD flat panels do not require long blanking intervals as a retrace > > period so default support reduced-blanking timings. > > > > Signed-off-by: Allen Chen > > Reported-by: kbuild test robot > > --- > > drivers/gpu/drm/drm_edid.c | 28 +++++++++++++++++++++------- > > 1 file changed, 21 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > index e5e7e65..9b67b80 100644 > > --- a/drivers/gpu/drm/drm_edid.c > > +++ b/drivers/gpu/drm/drm_edid.c > > @@ -93,6 +93,11 @@ struct detailed_mode_closure { > > int modes; > > }; > > > > +struct edid_support_rb_closure { > > + struct edid *edid; > > + s8 support_rb; > > bool > > ==> ITE: If use bool, we could not return EDID1.3 when EDID1.4 logic can not be applied Hmm. Could use two bools then. > > +}; > > + > > #define LEVEL_DMT 0 > > #define LEVEL_GTF 1 > > #define LEVEL_GTF2 2 > > @@ -2018,22 +2023,31 @@ struct drm_display_mode *drm_mode_find_dmt(struct drm_device *dev, > > is_rb(struct detailed_timing *t, void *data) > > { > > u8 *r = (u8 *)t; > > - if (r[3] == EDID_DETAIL_MONITOR_RANGE) > > - if (r[15] & 0x10) > > - *(bool *)data = true; > > + struct edid_support_rb_closure *closure = data; > > + struct edid *edid = closure->edid; > > + > > + if (!r[0] && !r[1] && !r[2] && r[3] == EDID_DETAIL_MONITOR_RANGE) { > > + if (edid->features & BIT(0) && r[10] == BIT(2)) > > + closure->support_rb = (r[15] & 0x10) ? 1 : 0; > > With the bool the ternary operator is not needed. Also should maybe > be |= in case we have multiple range descriptors? Not sure that is > legal. > > > + } > > } > > > > /* EDID 1.4 defines this explicitly. For EDID 1.3, we guess, badly. */ > > static bool > > drm_monitor_supports_rb(struct edid *edid) > > { > > + struct edid_support_rb_closure closure = { > > + .edid = edid, > > + .support_rb = -1, > > + }; > > + > > if (edid->revision >= 4) { > > - bool ret = false; > > - drm_for_each_detailed_block((u8 *)edid, is_rb, &ret); > > - return ret; > > + drm_for_each_detailed_block((u8 *)edid, is_rb, &closure); > > + if (closure.support_rb >= 0) > > + return closure.support_rb; > > } > > > > - return ((edid->input & DRM_EDID_INPUT_DIGITAL) != 0); > > + return true; > > Why are we now assuming rb for all pre 1.4 EDIDs? > > ==> ITE: Today, most of the monitor are LCD and LCD monitor do not require long blanking intervals as a retrace period so default support reduced-blanking timings. You can't assume such things. Someone out there is surely still using something that doesn't do reduced blanking. > > > } > > > > static void > > -- > > 1.9.1 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel