Re: [PATCH rdma-next 00/16] MAD cleanup

[Leon Romanovsky <leon@kernel.org>]

On Wed, Nov 06, 2019 at 04:14:48PM -0400, Jason Gunthorpe wrote:
> On Tue, Oct 29, 2019 at 08:27:29AM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > Let's clean MAD code a little bit.
> >
> > It is based on
> > https://lore.kernel.org/linux-rdma/20191027070621.11711-1-leon@kernel.org
>
> It doesn't seem related to this at all
>
> > Leon Romanovsky (16):
> >   RDMA/mad: Delete never implemented functions
> >   RDMA/mad: Allocate zeroed MAD buffer
> >   RDMA/mlx4: Delete redundant zero memset
> >   RDMA/mlx5: Delete redundant zero memset
>
> We don't need a patch for every driver just to change the same
> repeating 2 line pattern, I squashed these
>
> >   RDMA/ocrdma: Clean MAD processing logic
> >   RDMA/qib: Delete redundant memset for MAD output buffer
> >   RDMA/mlx4: Delete unreachable code
> >   RDMA/mlx5: Delete unreachable code
> >   RDMA/mthca: Delete unreachable code
>
> Same here
>
> >   RDMA/ocrdma: Simplify process_mad function
> >   RDMA/qib: Delete unreachable code
> >   RDMA/mlx5: Rewrite MAD processing logic to be readable
> >   RDMA/qib: Delete extra line
>
> >   RDMA/qib: Delete unused variable in process_cc call
>
> This is actually a bug from an earlier patch that oddly removed
> check_cc_key, I put that into its own patch
>
> >   RDMA/hfi1: Delete unreachable code
> >   RDMA: Change MAD processing function to remove extra casting and
> >     parameter
>
> Ira seems concerned, so I didn't apply these until we hear from Dennis
>
> Otherwise the rest were applied with re-organization to for-next

Jason,

Can you please take missing two patches?

Thanks

>
> Thanks,
> Jason