All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] staging: wfx: wrap characters
Date: Mon, 11 Nov 2019 16:34:14 +0100	[thread overview]
Message-ID: <20191111153414.GA798254@kroah.com> (raw)
In-Reply-To: <20191111133055.214410-2-jbi.octave@gmail.com>

On Mon, Nov 11, 2019 at 01:30:54PM +0000, Jules Irenge wrote:
> Wrap characters to fix line of over 80 characters.
> Issue detected by Checkpatch tool

You did other things in here as well:

>  {
> -	struct ieee80211_hdr *frame = (struct ieee80211_hdr *) skb->data;
> +	struct ieee80211_hdr *frame = (struct ieee80211_hdr *)skb->data;

Please only do "one type of change per patch".

thanks,

greg k-h

  reply	other threads:[~2019-11-11 15:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 13:30 [PATCH v2 1/3] staging: wfx: replace uintXX_t to uXX and intXX_t to sXX Jules Irenge
2019-11-11 13:30 ` [PATCH v2 2/3] staging: wfx: wrap characters Jules Irenge
2019-11-11 15:34   ` Greg KH [this message]
2019-11-11 13:30 ` [PATCH v2 3/3] staging: wfx: replace u32 by __le32 Jules Irenge
2019-11-11 14:12   ` Greg KH
2019-11-11 16:58   ` Jerome Pouiller
2019-11-11 23:15     ` Joe Perches
2019-11-11 17:04 ` [PATCH v2 1/3] staging: wfx: replace uintXX_t to uXX and intXX_t to sXX Jerome Pouiller
2019-11-11 17:48   ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191111153414.GA798254@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=jbi.octave@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.