From: Andrew Morton <akpm@linux-foundation.org>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Seth Jennings <sjenning@redhat.com>,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitalywool@gmail.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] zswap: allow setting default status, compressor and allocator in Kconfig
Date: Mon, 11 Nov 2019 15:39:31 -0800 [thread overview]
Message-ID: <20191111153931.199e4c729bfad2e8201e75a5@linux-foundation.org> (raw)
In-Reply-To: <20191108235107.2837339-1-mail@maciej.szmigiero.name>
On Sat, 9 Nov 2019 00:51:07 +0100 "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> wrote:
> The compressed cache for swap pages (zswap) currently needs from 1 to 3
> extra kernel command line parameters in order to make it work: it has to be
> enabled by adding a "zswap.enabled=1" command line parameter and if one
> wants a different compressor or pool allocator than the default lzo / zbud
> combination then these choices also need to be specified on the kernel
> command line in additional parameters.
>
> Using a different compressor and allocator for zswap is actually pretty
> common as guides often recommend using the lz4 / z3fold pair instead of
> the default one.
> In such case it is also necessary to remember to enable the appropriate
> compression algorithm and pool allocator in the kernel config manually.
>
> Let's avoid the need for adding these kernel command line parameters and
> automatically pull in the dependencies for the selected compressor
> algorithm and pool allocator by adding an appropriate default switches to
> Kconfig.
>
> The default values for these options match what the code was using
> previously as its defaults.
Shouldn't there be a Documentation/ update along with this change?
next prev parent reply other threads:[~2019-11-11 23:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 23:51 [PATCH v3] zswap: allow setting default status, compressor and allocator in Kconfig Maciej S. Szmigiero
2019-11-11 23:39 ` Andrew Morton [this message]
2019-11-11 23:46 ` Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111153931.199e4c729bfad2e8201e75a5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mail@maciej.szmigiero.name \
--cc=sjenning@redhat.com \
--cc=vbabka@suse.cz \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.