All of lore.kernel.org
 help / color / mirror / Atom feed
From: coverity-bot <keescook@chromium.org>
To: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Harry Wentland <harry.wentland@amd.com>,
	Hersen Wu <hersenxs.wu@amd.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	linux-next@vger.kernel.org
Subject: Coverity: transmitter_control_dmcub(): Memory - corruptions
Date: Mon, 11 Nov 2019 17:35:43 -0800	[thread overview]
Message-ID: <201911111735.323A3C22CE@keescook> (raw)

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191108 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

c264644545d2 ("drm/amd/display: Add DMUB support to DC")

Coverity reported the following:

*** CID 1487842:  Memory - corruptions  (OVERRUN)
/drivers/gpu/drm/amd/display/dc/bios/command_table2.c: 225 in transmitter_control_dmcub()
219     {
220     	struct dmub_rb_cmd_dig1_transmitter_control transmitter_control;
221
222     	transmitter_control.header.type = DMUB_CMD__DIG1_TRANSMITTER_CONTROL;
223     	transmitter_control.transmitter_control.dig = *dig;
224
vvv     CID 1487842:  Memory - corruptions  (OVERRUN)
vvv     Overrunning struct type dmub_cmd_header of 4 bytes by passing it to a function which accesses it at byte offset 63.
225     	dc_dmub_srv_cmd_queue(dmcub, &transmitter_control.header);
226     	dc_dmub_srv_cmd_execute(dmcub);
227     	dc_dmub_srv_wait_idle(dmcub);
228     }
229
230     static enum bp_result transmitter_control_v1_6(

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487842 ("Memory - corruptions")
Fixes: c264644545d2 ("drm/amd/display: Add DMUB support to DC")


Thanks for your attention!

-- 
Coverity-bot

                 reply	other threads:[~2019-11-12  1:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201911111735.323A3C22CE@keescook \
    --to=keescook@chromium.org \
    --cc=alexander.deucher@amd.com \
    --cc=gustavo@embeddedor.com \
    --cc=harry.wentland@amd.com \
    --cc=hersenxs.wu@amd.com \
    --cc=linux-next@vger.kernel.org \
    --cc=nicholas.kazlauskas@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.