All of lore.kernel.org
 help / color / mirror / Atom feed
From: coverity-bot <keescook@chromium.org>
To: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Harry Wentland <harry.wentland@amd.com>,
	Hersen Wu <hersenxs.wu@amd.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	linux-next@vger.kernel.org
Subject: Coverity: amdgpu_dm_fini(): Null pointer dereferences
Date: Mon, 11 Nov 2019 17:36:08 -0800	[thread overview]
Message-ID: <201911111736.85B8387@keescook> (raw)

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191108 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

c9dc20afe70a ("drm/amd/display: Register DMUB service with DC")

Coverity reported the following:

*** CID 1487836:  Null pointer dereferences  (FORWARD_NULL)
/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: 1037 in amdgpu_dm_fini()
1031     		adev->dm.hdcp_workqueue = NULL;
1032     	}
1033
1034     	if (adev->dm.dc)
1035     		dc_deinit_callbacks(adev->dm.dc);
1036     #endif
vvv     CID 1487836:  Null pointer dereferences  (FORWARD_NULL)
vvv     Dereferencing null pointer "adev->dm.dc".
1037     	if (adev->dm.dc->ctx->dmub_srv) {
1038     		dc_dmub_srv_destroy(&adev->dm.dc->ctx->dmub_srv);
1039     		adev->dm.dc->ctx->dmub_srv = NULL;
1040     	}
1041
1042     	if (adev->dm.dmub_bo)

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487836 ("Null pointer dereferences")
Fixes: c9dc20afe70a ("drm/amd/display: Register DMUB service with DC")


Thanks for your attention!

-- 
Coverity-bot

                 reply	other threads:[~2019-11-12  1:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201911111736.85B8387@keescook \
    --to=keescook@chromium.org \
    --cc=alexander.deucher@amd.com \
    --cc=gustavo@embeddedor.com \
    --cc=harry.wentland@amd.com \
    --cc=hersenxs.wu@amd.com \
    --cc=linux-next@vger.kernel.org \
    --cc=nicholas.kazlauskas@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.