From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9154AC43331 for ; Mon, 11 Nov 2019 18:30:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D4782184C for ; Mon, 11 Nov 2019 18:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497032; bh=Sqbampuhig29iZISFyfb6C1PpY/BmZ/PIh7jhn3D0hI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=O96N2uahaOg3Qpkta/D4liZE41IuPu5iYida4w4uBuApAnz47B5jfxOaoXIGMI6Eb CgwFiHJyvz204DLX0QViTxMYXpMvlamdjipo2PCOpKLnJ9D64pQt1kN5tKtea9oCZ3 TsXn5orq/DmyDKT15gYjHw1If/PytWOaexXE4HFE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727351AbfKKSab (ORCPT ); Mon, 11 Nov 2019 13:30:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:46804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727325AbfKKSa3 (ORCPT ); Mon, 11 Nov 2019 13:30:29 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E0FE7214E0; Mon, 11 Nov 2019 18:30:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497029; bh=Sqbampuhig29iZISFyfb6C1PpY/BmZ/PIh7jhn3D0hI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BQO0l0ggQ/iVzZyqK3OoCkPxu/WbjVf41IsjCxCnEFoc06sIuHsriiTfcgzynpqdk E51+fy18esga0xHoI9AWZrETrU2ycTEcZQbgDi8iAz2eZ2dX94QtqEHOupasagHwmM Ni2Q4Z/LwFGByDNzxHtZqHewdETv3LtNrgwnTqH8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , Marc Kleine-Budde Subject: [PATCH 4.4 21/43] can: gs_usb: gs_can_open(): prevent memory leak Date: Mon, 11 Nov 2019 19:28:35 +0100 Message-Id: <20191111181312.879687111@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181246.772983347@linuxfoundation.org> References: <20191111181246.772983347@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost commit fb5be6a7b4863ecc44963bb80ca614584b6c7817 upstream. In gs_can_open() if usb_submit_urb() fails the allocated urb should be released. Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN devices") Cc: linux-stable Signed-off-by: Navid Emamdoost Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/usb/gs_usb.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/can/usb/gs_usb.c +++ b/drivers/net/can/usb/gs_usb.c @@ -617,6 +617,7 @@ static int gs_can_open(struct net_device rc); usb_unanchor_urb(urb); + usb_free_urb(urb); break; }