From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC7BC17441 for ; Mon, 11 Nov 2019 18:51:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04BAD204FD for ; Mon, 11 Nov 2019 18:51:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573498298; bh=qjwvcjKxjfkXr+vX77CHHtO2r93CjSFaGGEQRJ8PZoI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RvubHBdZF93MWbGK9+L7LmpnHHLUrC/cL6qulbRMWIJ/Q8/ELO1WmQqHHwfDWh5cy 0r9ECJG6A2ph0z7ca997b5oska0qgzLiwaxWJZZrGVroNjiqX0feNf372AqpPZ7gv5 p/p5Ykz88DT8G944KFctOi7PGoGoxiyt0UFGv2mY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730436AbfKKSvg (ORCPT ); Mon, 11 Nov 2019 13:51:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:45710 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728971AbfKKSvc (ORCPT ); Mon, 11 Nov 2019 13:51:32 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FB06204FD; Mon, 11 Nov 2019 18:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573498291; bh=qjwvcjKxjfkXr+vX77CHHtO2r93CjSFaGGEQRJ8PZoI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SJlDcaF7LGUFtB8/F5i7bi9hV59ym1dUfY8dscxkMEIF2R8GnToC9xkl2Mp5fxFps NCxU0dFcUwMCJFLYWYDa+yWwgUxAu9Z42Bn2/1sTstxX8XvFKy6Y6UiUH9IuMEYbmb sNj/VMlCSF/+ZBoH0xuUBSsm5bsl7OZ91/K4hSn0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Remigiusz=20Ko=C5=82=C5=82=C4=85taj?= , syzbot+e29b17e5042bbc56fae9@syzkaller.appspotmail.com, Johan Hovold , Marc Kleine-Budde Subject: [PATCH 5.3 079/193] can: mcba_usb: fix use-after-free on disconnect Date: Mon, 11 Nov 2019 19:27:41 +0100 Message-Id: <20191111181506.966509523@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181459.850623879@linuxfoundation.org> References: <20191111181459.850623879@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 4d6636498c41891d0482a914dd570343a838ad79 upstream. The driver was accessing its driver data after having freed it. Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer") Cc: stable # 4.12 Cc: Remigiusz Kołłątaj Reported-by: syzbot+e29b17e5042bbc56fae9@syzkaller.appspotmail.com Signed-off-by: Johan Hovold Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/usb/mcba_usb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/can/usb/mcba_usb.c +++ b/drivers/net/can/usb/mcba_usb.c @@ -876,9 +876,8 @@ static void mcba_usb_disconnect(struct u netdev_info(priv->netdev, "device disconnected\n"); unregister_candev(priv->netdev); - free_candev(priv->netdev); - mcba_urb_unlink(priv); + free_candev(priv->netdev); } static struct usb_driver mcba_usb_driver = {