From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A7DC43331 for ; Mon, 11 Nov 2019 18:57:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D624222C2 for ; Mon, 11 Nov 2019 18:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573498635; bh=+5/pU0gbGGuMiC4hy+LUaYzqzR/jLjZp+mldKJOoD4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=z0SuDvWCNltxlXzj9r855SWv61JyBJ1FZCVseQ8WAbSwhpr++o3RnQ/aXOACn+U9l ZxIm+k0CGw11G9QLuDOcFp+RpHSfvcYJRPixyJXrvQNner5aALHYDpICyFNrt0GXhe cXUWdIhO9hIN0FCNDbRNuoB6RlGFSGR5tS79X1mc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730217AbfKKS5O (ORCPT ); Mon, 11 Nov 2019 13:57:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:56232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730591AbfKKS5K (ORCPT ); Mon, 11 Nov 2019 13:57:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6773721783; Mon, 11 Nov 2019 18:57:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573498629; bh=+5/pU0gbGGuMiC4hy+LUaYzqzR/jLjZp+mldKJOoD4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Loh0fsIZqMQi2dlygUGpInJfD8gLxLM+jWLMDoELbtiJ5dpZBAoBYJs6R236eYyv8 RD+ysUA8LDlLjrAghSFkATcb8CfyuhnwIBHuJOQ++BLqTfDgbdVc/i6KngfxXXolg/ dBbE1DeTZlJaCAlWjkjFVjVR7rrBNaY9UdfFk1GE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Haiyang Zhang , "David S. Miller" , Sasha Levin Subject: [PATCH 5.3 174/193] hv_netvsc: Fix error handling in netvsc_attach() Date: Mon, 11 Nov 2019 19:29:16 +0100 Message-Id: <20191111181513.956647550@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181459.850623879@linuxfoundation.org> References: <20191111181459.850623879@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang [ Upstream commit 719b85c336ed35565d0f3982269d6f684087bb00 ] If rndis_filter_open() fails, we need to remove the rndis device created in earlier steps, before returning an error code. Otherwise, the retry of netvsc_attach() from its callers will fail and hang. Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic") Signed-off-by: Haiyang Zhang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/hyperv/netvsc_drv.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index e8fce6d715ef0..8ed79b418d88a 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -982,7 +982,7 @@ static int netvsc_attach(struct net_device *ndev, if (netif_running(ndev)) { ret = rndis_filter_open(nvdev); if (ret) - return ret; + goto err; rdev = nvdev->extension; if (!rdev->link_state) @@ -990,6 +990,13 @@ static int netvsc_attach(struct net_device *ndev, } return 0; + +err: + netif_device_detach(ndev); + + rndis_filter_device_remove(hdev, nvdev); + + return ret; } static int netvsc_set_channels(struct net_device *net, -- 2.20.1