From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [RFC PATCH 3/6] subflow: store known available bytes in subflow
Date: Tue, 12 Nov 2019 01:51:12 +0100 [thread overview]
Message-ID: <20191112005112.GD19558@breakpoint.cc> (raw)
In-Reply-To: alpine.OSX.2.21.1911111637500.7818@mjmartin-mac01.local
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
Mat Martineau <mathew.j.martineau(a)linux.intel.com> wrote:
> > skb = skb_peek(&sk->sk_receive_queue);
> > - subflow->data_avail = skb &&
> > - before(tcp_sk(sk)->copied_seq, TCP_SKB_CB(skb)->end_seq);
> > - return subflow->data_avail;
> > + if (skb) {
> > + const struct tcp_sock *tp = tcp_sk(sk);
> > + u32 map_remaining = subflow->map_data_len -
> > + mptcp_subflow_get_map_offset(subflow);
> > +
>
> It looks like the mapping can be assumed valid here, since
> subflow_check_data_avail() returned true. It's not obvious looking at this
> function that map_valid should be true at this point - is it worth a
> WARN_ONCE or a comment?
I think I'll go with a WARN_ON_ONCE().
next reply other threads:[~2019-11-12 0:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 0:51 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-12 0:46 [MPTCP] Re: [RFC PATCH 3/6] subflow: store known available bytes in subflow Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112005112.GD19558@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.