From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A790CC43331 for ; Tue, 12 Nov 2019 05:40:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79D192084F for ; Tue, 12 Nov 2019 05:40:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OgHRvNz1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EIdklnhR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79D192084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ux+Z5aib7kzXEzkNBF9h21aQXGnPubeQtlLi4KK3I1g=; b=OgHRvNz13/2iXH lPG2zvEXx3xf9yLBW1RJVB6YPlkNqQdUyCYe5PI78UhNNcP1U2Zz9GyfMjRUWWTFCU0Z0NhpNTKFl gMaNBbVvWitiIIE4tOvioEGyPOIa9SO/eZR47HNDhBriiO3z0N3hEf6k0ZZihTxU+fRIB3lHNK53u zNsttExYN6J0/+UdeTsDnA2OlbZGEmtK8UPqCaay8m6Wus/SllDxvM8VX9jY5mB9/+B6G7apH3fOr fDWg9BbIJZEVKXm3fWtEg8B1MWaDM9rKo3rNkGLAPCu+oPyt7Rr9TM1t9t79t0R+IeoIDfxuo2VEp 3cnCjVvb2sOpfQHBtl7Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUOuP-0001SH-4F; Tue, 12 Nov 2019 05:40:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUOuM-00011E-EJ; Tue, 12 Nov 2019 05:40:07 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 817A02084F; Tue, 12 Nov 2019 05:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573537206; bh=DHULJ5PDA2aurBq/UHbqIfg+vBBq4iEHEwdqVLa0Rak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EIdklnhR1wHAYbf9dcmZZxeSETsXhU1RQofV1TABiA/LMIwkDJkONzhxeGrMd9WEb 2YK+IKes8uDqeh0oeI+DUgPMeA3THWY3Hv/yBaurld+YtEEiCThT5vKHsWJbjw/kl4 aEkJL5Ymp45+COr4Cr2hcDGVlVHJoUbuiF33Zil0= Date: Tue, 12 Nov 2019 06:40:03 +0100 From: Greg Kroah-Hartman To: Andreas =?iso-8859-1?Q?F=E4rber?= Subject: Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() Message-ID: <20191112054003.GD1210104@kroah.com> References: <20191111221521.1587-1-afaerber@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191111221521.1587-1-afaerber@suse.de> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_214006_515380_317134FA X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Martin Blumenstingl , Kevin Hilman , linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas F=E4rber wrote: > The helper soc_device_to_device() is considered deprecated. > For a driver __init function the predictable prefix text > "soc soc0:" from dev_info() does not add real value, so use > pr_info() to emit the info text without such prefix. > = > While at it, normalize the casing of "detected" for GX. > = > Cc: Greg Kroah-Hartman > Cc: Martin Blumenstingl > Cc: Neil Armstrong > Signed-off-by: Andreas F=E4rber > --- > drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- > drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- > 2 files changed, 3 insertions(+), 5 deletions(-) > = > diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic= /meson-gx-socinfo.c > index 01fc0d20a70d..105b819bbd5f 100644 > --- a/drivers/soc/amlogic/meson-gx-socinfo.c > +++ b/drivers/soc/amlogic/meson-gx-socinfo.c > @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) > struct device_node *np; > struct regmap *regmap; > unsigned int socinfo; > - struct device *dev; > int ret; > = > /* look up for chipid node */ > @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) > kfree(soc_dev_attr); > return PTR_ERR(soc_dev); > } > - dev =3D soc_device_to_device(soc_dev); > = > - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", > + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", This should message should just be removed entirely. > soc_dev_attr->soc_id, > socinfo_to_major(socinfo), > socinfo_to_minor(socinfo), > diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic= /meson-mx-socinfo.c > index 78f0f1aeca57..7db2c94a7130 100644 > --- a/drivers/soc/amlogic/meson-mx-socinfo.c > +++ b/drivers/soc/amlogic/meson-mx-socinfo.c > @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) > return PTR_ERR(soc_dev); > } > = > - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", > - soc_dev_attr->soc_id, soc_dev_attr->revision); > + pr_info("Amlogic %s %s detected\n", > + soc_dev_attr->soc_id, soc_dev_attr->revision); Same here, no need to polute the kernel log for when all is going just fine. That's why we created "common" driver init helpers, to prevent the ability for this type of noise from even being able to be created at all. thanks, greg k-h _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4495C43331 for ; Tue, 12 Nov 2019 05:40:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 817FC2084F for ; Tue, 12 Nov 2019 05:40:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lm+QfrSN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EIdklnhR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 817FC2084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YQButa/cwxJomjl3o8EwaAGHI093MpeVrueGOJ9FFnw=; b=Lm+QfrSNlZF+3q 6ScTHAkIEEYtnssNnghhs3mAn0qkbPCa+5x+Uloh1vGdp7as8qrYAWfeiWooSJOvE4q3ruTWH0P/s KtmaUo7eI3tCDUncEpGMrAjVVLTH8wbc2lFsB/tAIEQt/NB3ruDOUacuc1olh1D6cak4iMIFFkm+j UxNvgIOCFKiR7BjxwGPTfGijk+kRBjZj9CUgo1HXyhxIzwxajcK07KAw/OaEyAnDgnRLPgL2TdM75 ud6zCUQcC9GWBfBTqJRya6lEcEnC6zJVeqPyP2dBNO4y7W/Em1/0ZizMgs5RNfUS6LftscspGb7Ev 6FX8BT2aFGPAQQPVj8UA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUOuR-0001dO-RV; Tue, 12 Nov 2019 05:40:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUOuM-00011E-EJ; Tue, 12 Nov 2019 05:40:07 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 817A02084F; Tue, 12 Nov 2019 05:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573537206; bh=DHULJ5PDA2aurBq/UHbqIfg+vBBq4iEHEwdqVLa0Rak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EIdklnhR1wHAYbf9dcmZZxeSETsXhU1RQofV1TABiA/LMIwkDJkONzhxeGrMd9WEb 2YK+IKes8uDqeh0oeI+DUgPMeA3THWY3Hv/yBaurld+YtEEiCThT5vKHsWJbjw/kl4 aEkJL5Ymp45+COr4Cr2hcDGVlVHJoUbuiF33Zil0= Date: Tue, 12 Nov 2019 06:40:03 +0100 From: Greg Kroah-Hartman To: Andreas =?iso-8859-1?Q?F=E4rber?= Subject: Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() Message-ID: <20191112054003.GD1210104@kroah.com> References: <20191111221521.1587-1-afaerber@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191111221521.1587-1-afaerber@suse.de> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_214006_515380_317134FA X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Martin Blumenstingl , Kevin Hilman , linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas F=E4rber wrote: > The helper soc_device_to_device() is considered deprecated. > For a driver __init function the predictable prefix text > "soc soc0:" from dev_info() does not add real value, so use > pr_info() to emit the info text without such prefix. > = > While at it, normalize the casing of "detected" for GX. > = > Cc: Greg Kroah-Hartman > Cc: Martin Blumenstingl > Cc: Neil Armstrong > Signed-off-by: Andreas F=E4rber > --- > drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- > drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- > 2 files changed, 3 insertions(+), 5 deletions(-) > = > diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic= /meson-gx-socinfo.c > index 01fc0d20a70d..105b819bbd5f 100644 > --- a/drivers/soc/amlogic/meson-gx-socinfo.c > +++ b/drivers/soc/amlogic/meson-gx-socinfo.c > @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) > struct device_node *np; > struct regmap *regmap; > unsigned int socinfo; > - struct device *dev; > int ret; > = > /* look up for chipid node */ > @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) > kfree(soc_dev_attr); > return PTR_ERR(soc_dev); > } > - dev =3D soc_device_to_device(soc_dev); > = > - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", > + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", This should message should just be removed entirely. > soc_dev_attr->soc_id, > socinfo_to_major(socinfo), > socinfo_to_minor(socinfo), > diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic= /meson-mx-socinfo.c > index 78f0f1aeca57..7db2c94a7130 100644 > --- a/drivers/soc/amlogic/meson-mx-socinfo.c > +++ b/drivers/soc/amlogic/meson-mx-socinfo.c > @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) > return PTR_ERR(soc_dev); > } > = > - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", > - soc_dev_attr->soc_id, soc_dev_attr->revision); > + pr_info("Amlogic %s %s detected\n", > + soc_dev_attr->soc_id, soc_dev_attr->revision); Same here, no need to polute the kernel log for when all is going just fine. That's why we created "common" driver init helpers, to prevent the ability for this type of noise from even being able to be created at all. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CC92C43331 for ; Tue, 12 Nov 2019 05:40:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 045EE2084F for ; Tue, 12 Nov 2019 05:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573537208; bh=DHULJ5PDA2aurBq/UHbqIfg+vBBq4iEHEwdqVLa0Rak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WremyTj6OhgH6MNAETnVwUGPl1kwKzKmixiHwDMKH6Ixl6SGQXTwajRbKlgAnR1LI q4ARsR7N9E7Ic6l5XW2DrGy9VgEeQVdyJqfobO2qowfsa2L92WsQbp5awYedOPfkSs dGquAzxTjlYr/lJGH47nZUq1SIANhutlzWAQ54zw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726188AbfKLFkG (ORCPT ); Tue, 12 Nov 2019 00:40:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:34646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfKLFkG (ORCPT ); Tue, 12 Nov 2019 00:40:06 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 817A02084F; Tue, 12 Nov 2019 05:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573537206; bh=DHULJ5PDA2aurBq/UHbqIfg+vBBq4iEHEwdqVLa0Rak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EIdklnhR1wHAYbf9dcmZZxeSETsXhU1RQofV1TABiA/LMIwkDJkONzhxeGrMd9WEb 2YK+IKes8uDqeh0oeI+DUgPMeA3THWY3Hv/yBaurld+YtEEiCThT5vKHsWJbjw/kl4 aEkJL5Ymp45+COr4Cr2hcDGVlVHJoUbuiF33Zil0= Date: Tue, 12 Nov 2019 06:40:03 +0100 From: Greg Kroah-Hartman To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , Neil Armstrong , Kevin Hilman Subject: Re: [PATCH] soc: amlogic: socinfo: Avoid soc_device_to_device() Message-ID: <20191112054003.GD1210104@kroah.com> References: <20191111221521.1587-1-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191111221521.1587-1-afaerber@suse.de> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2019 at 11:15:21PM +0100, Andreas Färber wrote: > The helper soc_device_to_device() is considered deprecated. > For a driver __init function the predictable prefix text > "soc soc0:" from dev_info() does not add real value, so use > pr_info() to emit the info text without such prefix. > > While at it, normalize the casing of "detected" for GX. > > Cc: Greg Kroah-Hartman > Cc: Martin Blumenstingl > Cc: Neil Armstrong > Signed-off-by: Andreas Färber > --- > drivers/soc/amlogic/meson-gx-socinfo.c | 4 +--- > drivers/soc/amlogic/meson-mx-socinfo.c | 4 ++-- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c > index 01fc0d20a70d..105b819bbd5f 100644 > --- a/drivers/soc/amlogic/meson-gx-socinfo.c > +++ b/drivers/soc/amlogic/meson-gx-socinfo.c > @@ -129,7 +129,6 @@ static int __init meson_gx_socinfo_init(void) > struct device_node *np; > struct regmap *regmap; > unsigned int socinfo; > - struct device *dev; > int ret; > > /* look up for chipid node */ > @@ -192,9 +191,8 @@ static int __init meson_gx_socinfo_init(void) > kfree(soc_dev_attr); > return PTR_ERR(soc_dev); > } > - dev = soc_device_to_device(soc_dev); > > - dev_info(dev, "Amlogic Meson %s Revision %x:%x (%x:%x) Detected\n", > + pr_info("Amlogic Meson %s Revision %x:%x (%x:%x) detected\n", This should message should just be removed entirely. > soc_dev_attr->soc_id, > socinfo_to_major(socinfo), > socinfo_to_minor(socinfo), > diff --git a/drivers/soc/amlogic/meson-mx-socinfo.c b/drivers/soc/amlogic/meson-mx-socinfo.c > index 78f0f1aeca57..7db2c94a7130 100644 > --- a/drivers/soc/amlogic/meson-mx-socinfo.c > +++ b/drivers/soc/amlogic/meson-mx-socinfo.c > @@ -167,8 +167,8 @@ static int __init meson_mx_socinfo_init(void) > return PTR_ERR(soc_dev); > } > > - dev_info(soc_device_to_device(soc_dev), "Amlogic %s %s detected\n", > - soc_dev_attr->soc_id, soc_dev_attr->revision); > + pr_info("Amlogic %s %s detected\n", > + soc_dev_attr->soc_id, soc_dev_attr->revision); Same here, no need to polute the kernel log for when all is going just fine. That's why we created "common" driver init helpers, to prevent the ability for this type of noise from even being able to be created at all. thanks, greg k-h